From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F3D13A3ED; Sun, 30 Nov 2025 18:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764527641; cv=none; b=p4ulmYuRJ120a2pdaBbuNC+HexUNZAfr1imf1iNKXe3VO82ER7ZjMi+mXzlHqy4Hn1x7yCENSpT9CyRroYwOeZbCSL+gq6tNcwv7aaW/gCKis2l5GCJnmCXy1zpKth1SciDvS37HsGKbsMPiTWVeWnpPEPXo+PiiBnjX40xu+vQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764527641; c=relaxed/simple; bh=BYIrTTSVxXc1HabQ88UTUwwWE2cNqChrEagcfgIifHM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=V9bttCDUEwkpN0RwKNG4VcIb7LEQMmjMI6nc4P0Kzx38MxlqEpneOv3kRO+53p/GThFwtnC9Y87x47DHxrxfHLkMagkJX7riz/V5ckUfKgsMpY/eq02c5JpQ6S9cl5CZAvixUniVOuvPG534K9di8kS4bwuqfwhFSJcJAc6ySHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kBFXLUn9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kBFXLUn9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E94BAC4CEF8; Sun, 30 Nov 2025 18:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764527641; bh=BYIrTTSVxXc1HabQ88UTUwwWE2cNqChrEagcfgIifHM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kBFXLUn9eUUFE4hB9wG21BIV2zOMN07LikUdlSj0RvlJDXhVqa215EW/n6VTfVHcv F845ySyClHanxEDEJDysjtCqNufWrG0UWe1rZ9akTgwmjHRPylnJXjt6s6ZU4298Ar EPA5ZJaIVvTYHsE96tgy1HlAERMGGDM5VYcBrkWMy9zZdWAAVB+d0dgO2A3ovaumzG 2XtYroo6lgEXWW8/gpv/XtaJmPNjlhzexoAR0MWVmUGCI2rsdwlA/X3EGkCWY7cMw/ It30Yk8Tw8ecoSZLXWsq44aSzte+1xPwYrAWTuP5SI+CNM5u2K+266oecI+orhbqnl EVvQsbTDV9uQw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vPmFC-00000009RQq-3VZl; Sun, 30 Nov 2025 18:33:58 +0000 Date: Sun, 30 Nov 2025 18:33:58 +0000 Message-ID: <875xarfjzd.wl-maz@kernel.org> From: Marc Zyngier To: Vincent Donnefort Cc: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 24/28] KVM: arm64: Add trace reset to the pKVM hyp In-Reply-To: <20251107093840.3779150-25-vdonnefort@google.com> References: <20251107093840.3779150-1-vdonnefort@google.com> <20251107093840.3779150-25-vdonnefort@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vdonnefort@google.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 07 Nov 2025 09:38:36 +0000, Vincent Donnefort wrote: > [...] > +int __pkvm_reset_tracing(unsigned int cpu) > +{ > + int ret = 0; > + > + if (cpu >= hyp_nr_cpus) > + return -EINVAL; > + > + hyp_spin_lock(&trace_buffer.lock); > + > + if (hyp_trace_buffer_loaded(&trace_buffer)) > + ret = simple_ring_buffer_reset(per_cpu_ptr(trace_buffer.simple_rbs, cpu)); > + else > + ret = -ENODEV; > + > + hyp_spin_unlock(&trace_buffer.lock); > + > + return ret; nit; there is no case where the 'ret' default value can be used. Either drop the init or make it so that the default value is meaningful (-ENODEV). Thanks, M. -- Jazz isn't dead. It just smells funny.