From: Thomas Gleixner <tglx@linutronix.de>
To: Wentao Zhang <wentaoz5@illinois.edu>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-um@lists.infradead.org,
linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
llvm@lists.linux.dev, x86@kernel.org
Cc: wentaoz5@illinois.edu, marinov@illinois.edu, tyxu@illinois.edu,
jinghao7@illinois.edu, tingxur@illinois.edu,
steven.h.vanderleest@boeing.com, chuck.wolber@boeing.com,
matthew.l.weber3@boeing.com, Matt.Kelly2@boeing.com,
andrew.j.oppelt@boeing.com, samuel.sarkisian@boeing.com,
morbo@google.com, samitolvanen@google.com, masahiroy@kernel.org,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
luto@kernel.org, ardb@kernel.org, richard@nod.at,
anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net,
arnd@arndb.de, rostedt@goodmis.org, mhiramat@kernel.org,
oberpar@linux.ibm.com, akpm@linux-foundation.org,
paulmck@kernel.org, bhelgaas@google.com, kees@kernel.org,
jpoimboe@kernel.org, peterz@infradead.org,
kent.overstreet@linux.dev, nathan@kernel.org, hpa@zytor.com,
mathieu.desnoyers@efficios.com, ndesaulniers@google.com,
justinstitt@google.com, maskray@google.com, dvyukov@google.com
Subject: Re: [RFC PATCH 2/3] kbuild, llvm-cov: disable instrumentation in odd or sensitive code
Date: Sun, 25 Aug 2024 14:12:27 +0200 [thread overview]
Message-ID: <878qwkg5sk.ffs@tglx> (raw)
In-Reply-To: <20240824230641.385839-3-wentaoz5@illinois.edu>
On Sat, Aug 24 2024 at 18:06, Wentao Zhang wrote:
The subject line is really not useful. What's 'odd' code?
> Disable instrumentation in the same areas that were disabled for
> kernel/gcov/
> Signed-off-by: Wentao Zhang <wentaoz5@illinois.edu>
> Signed-off-by: Chuck Wolber <chuck.wolber@boeing.com>
This Signed-off-by chain is broken. See Documentation/process/
> diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
> index 9cc0ff6e9067..2cc2c55af305 100644
> --- a/arch/x86/boot/Makefile
> +++ b/arch/x86/boot/Makefile
> @@ -57,6 +57,7 @@ KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
> KBUILD_CFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)
> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> KBUILD_CFLAGS += $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
> +LLVM_COV_PROFILE := n
See 7f7f6f7ad654 ("Makefile: remove redundant tool coverage variables")
Also a 'git grep GCOV_PROFILE' shows way more places. Can't LLVM_COV
just use the already existing GCOV_PROFILE annotations or is LLVM_COV
suitable for all the files which have been excluded for GCOV?
GCOV has GCOV_PROFILE_obj.o, GCOV_PROFILE and CONFIG_GCOV_PROFILE_ALL
for a reason, no?
Thanks,
tglx
next prev parent reply other threads:[~2024-08-25 12:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 23:06 [RFC PATCH 0/3] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Wentao Zhang
2024-08-24 23:06 ` [RFC PATCH 1/3] llvm-cov: add Clang's Source-based Code Coverage support Wentao Zhang
2024-08-25 11:52 ` Thomas Gleixner
2024-08-24 23:06 ` [RFC PATCH 2/3] kbuild, llvm-cov: disable instrumentation in odd or sensitive code Wentao Zhang
2024-08-25 12:12 ` Thomas Gleixner [this message]
2024-08-24 23:06 ` [RFC PATCH 3/3] llvm-cov: add Clang's MC/DC support Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 1/4] llvm-cov: add Clang's Source-based Code Coverage support Wentao Zhang
2024-10-02 0:30 ` Nathan Chancellor
2024-09-05 4:32 ` [PATCH v2 2/4] llvm-cov: add Clang's MC/DC support Wentao Zhang
2024-10-02 1:10 ` Nathan Chancellor
2024-10-03 3:14 ` Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 3/4] x86: disable llvm-cov instrumentation Wentao Zhang
2024-10-02 1:17 ` Nathan Chancellor
2024-09-05 4:32 ` [PATCH v2 4/4] x86: enable llvm-cov support Wentao Zhang
2024-10-02 1:18 ` Nathan Chancellor
2024-09-05 11:41 ` [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Peter Zijlstra
[not found] ` <BN0P110MB1785427A8771BD53DADB2E4DAB9DA@BN0P110MB1785.NAMP110.PROD.OUTLOOK.COM>
[not found] ` <BN0P110MB1785CA856C1898EEC22ACD7EAB9DA@BN0P110MB1785.NAMP110.PROD.OUTLOOK.COM>
2024-09-05 12:24 ` FW: [EXTERNAL] " Steve VanderLeest
2024-09-05 18:07 ` Wentao Zhang
2024-10-02 4:53 ` Nathan Chancellor
2024-10-02 6:42 ` Wentao Zhang
2024-10-03 23:29 ` Nathan Chancellor
2024-10-09 3:17 ` Wentao Zhang
2024-11-22 5:05 ` Jinghao Jia
2024-11-23 4:39 ` Nathan Chancellor
2025-08-29 18:10 ` Nathan Chancellor
2024-11-22 12:27 ` Peter Zijlstra
2024-11-22 19:28 ` [EXTERNAL] " Wolber (US), Chuck
2024-11-23 3:09 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qwkg5sk.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Matt.Kelly2@boeing.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.j.oppelt@boeing.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=chuck.wolber@boeing.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=jinghao7@illinois.edu \
--cc=johannes@sipsolutions.net \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=marinov@illinois.edu \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.l.weber3@boeing.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=samuel.sarkisian@boeing.com \
--cc=steven.h.vanderleest@boeing.com \
--cc=tingxur@illinois.edu \
--cc=tyxu@illinois.edu \
--cc=wentaoz5@illinois.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).