From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D5AEC4500B; Tue, 5 Mar 2024 07:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=153.127.30.23 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709622335; cv=none; b=B1dEQxPcsnTitqb00w1gyDdsZ4TtEPwwjluLN5k2EIGDG2badXgeFIHvONpZj75/RqK+dNNuWvWMXjbP6XiWuSP6dUM0n6I7vUsFAK+xZGy9FnsVOT1ArKu2PLbXREgDHedeaA/9R7dpXrW6eVznGdR6s4QxzLtX5OqZlSJ+5i4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709622335; c=relaxed/simple; bh=XIzBUHoiVeCQAMPUCNXTA2fFmTK4/1wOs2592jH8r1U=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=SByelEwC0M2pniIqF7jf+vXZoNWGcR3TOUbUQV74DnHWHg3AtcwNVK5dmF4zcy0m1grsq8gQTOSHqq5EX+df2na7drkbv4gTeKwIPYIC3jkM5kVESLKbtwd8YV/tZ2brsft8owq7PZ4zT3ahcoyA19sqyO+u0gD25Th/nFQHBNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp; spf=fail smtp.mailfrom=users.sourceforge.jp; arc=none smtp.client-ip=153.127.30.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=users.sourceforge.jp Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 38F3D1C00A0; Tue, 5 Mar 2024 15:56:29 +0900 (JST) Date: Tue, 05 Mar 2024 15:56:26 +0900 Message-ID: <87bk7tjhet.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: Rich Felker , John Paul Adrian Glaubitz , Arnd Bergmann , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , linux-sh@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 08/20] sh: boot: Add proper forward declarations In-Reply-To: <2614d991c816ece903ef47c715bcc53881d34f3f.1709326528.git.geert+renesas@glider.be> References: <2614d991c816ece903ef47c715bcc53881d34f3f.1709326528.git.geert+renesas@glider.be> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable On Sat, 02 Mar 2024 06:02:22 +0900, Geert Uytterhoeven wrote: >=20 > arch/sh/boot/compressed/cache.c:2:5: warning: no previous prototype for = =A1cache_control=A2 [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:115:6: warning: no previous prototype for = =A1ftrace_stub=A2 [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:118:6: warning: no previous prototype for = =A1arch_ftrace_ops_list_func=A2 [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:128:6: warning: no previous prototype for = =A1decompress_kernel=A2 [-Wmissing-prototypes] >=20 > Signed-off-by: Geert Uytterhoeven > --- > arch/sh/boot/compressed/cache.c | 3 +++ > arch/sh/boot/compressed/cache.h | 10 ++++++++++ > arch/sh/boot/compressed/misc.c | 8 +++----- > arch/sh/boot/compressed/misc.h | 9 +++++++++ > 4 files changed, 25 insertions(+), 5 deletions(-) > create mode 100644 arch/sh/boot/compressed/cache.h > create mode 100644 arch/sh/boot/compressed/misc.h >=20 > diff --git a/arch/sh/boot/compressed/cache.c b/arch/sh/boot/compressed/ca= che.c > index 31e04ff4841ed084..95c1e73ccbb7e011 100644 > --- a/arch/sh/boot/compressed/cache.c > +++ b/arch/sh/boot/compressed/cache.c > @@ -1,4 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > + > +#include "cache.h" > + > int cache_control(unsigned int command) > { > volatile unsigned int *p =3D (volatile unsigned int *) 0x80000000; > diff --git a/arch/sh/boot/compressed/cache.h b/arch/sh/boot/compressed/ca= che.h > new file mode 100644 > index 0000000000000000..b622b68c87f59b97 > --- /dev/null > +++ b/arch/sh/boot/compressed/cache.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef CACHE_H > +#define CACHE_H > + > +#define CACHE_ENABLE 0 > +#define CACHE_DISABLE 1 > + > +int cache_control(unsigned int command); > + > +#endif /* CACHE_H */ > diff --git a/arch/sh/boot/compressed/misc.c b/arch/sh/boot/compressed/mis= c.c > index ca05c99a3d5b488d..5178150ca6650dcf 100644 > --- a/arch/sh/boot/compressed/misc.c > +++ b/arch/sh/boot/compressed/misc.c > @@ -16,6 +16,9 @@ > #include > #include > =20 > +#include "cache.h" > +#include "misc.h" > + > /* > * gzip declarations > */ > @@ -26,11 +29,6 @@ > #undef memcpy > #define memzero(s, n) memset ((s), 0, (n)) > =20 > -/* cache.c */ > -#define CACHE_ENABLE 0 > -#define CACHE_DISABLE 1 > -int cache_control(unsigned int command); > - > extern char input_data[]; > extern int input_len; > static unsigned char *output; > diff --git a/arch/sh/boot/compressed/misc.h b/arch/sh/boot/compressed/mis= c.h > new file mode 100644 > index 0000000000000000..2b4534faa3052857 > --- /dev/null > +++ b/arch/sh/boot/compressed/misc.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef MISC_H > +#define MISC_H > + > +void arch_ftrace_ops_list_func(void); > +void decompress_kernel(void); > +void ftrace_stub(void); > + > +#endif /* MISC_H */ > --=20 > 2.34.1 >=20 >=20 This cache control is from SH5, so it is no longer needed. I think it's better to simply delete chace.c and cache_control. --=20 Yosinori Sato