Linux Trace Kernel
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Wander Lairson Costa <wander@redhat.com>,
	linux-trace-kernel@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/13] verification/rvgen: Implement state and transition parser based on Lark
Date: Tue, 09 Jun 2026 15:23:45 +0200	[thread overview]
Message-ID: <8a6bdffa673dcfa2df269b1e9d55f093ac4c7394.camel@redhat.com> (raw)
In-Reply-To: <8964bf8b7c20fa1a5b8ef2a7081cf8ba11d70526.1780908661.git.namcao@linutronix.de>

On Mon, 2026-06-08 at 10:56 +0200, Nam Cao wrote:
> +class ConstraintRule:
> +    grammar = r'''
> +        rule: condition (OP condition)*
> +
> +        OP: "&&" | "||"
> +
> +        condition: ENV CMP_OP VAL UNIT?
> +
> +        ENV: CNAME
> +
> +        CMP_OP: "==" | "<=" | "<" | ">=" | ">"
> +
> +        VAL: /[0-9]+/
> +           | /[A-Z_]+\(\)/	
> +           | /[A-Z_]+/
> +           | /[a-z_]+\(\)/
> +           | /[a-z_]+/
> +
> +        UNIT: "ns" | "us" | "ms" | "s"
> +    '''

One more (that sashiko couldn't find), we're talking about "j" as a
unit, it should be allowed also on literals (so we need to add it as a
valid UNIT).

Thanks,
Gabriele


  parent reply	other threads:[~2026-06-09 13:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  8:56 [PATCH v3 00/13] rv: Convert rvgen to Lark Nam Cao
2026-06-08  8:56 ` [PATCH v3 01/13] verification/rvgen: Switch LTL parser " Nam Cao
2026-06-08  8:56 ` [PATCH v3 02/13] verification/rvgen: Introduce a parse tree for automata using Lark Nam Cao
2026-06-08  8:56 ` [PATCH v3 03/13] verification/rvgen: Implement state and transition parser based on Lark Nam Cao
2026-06-09 12:54   ` Gabriele Monaco
2026-06-09 13:23   ` Gabriele Monaco [this message]
2026-06-08  8:57 ` [PATCH v3 04/13] verification/rvgen: Convert __fill_verify_invariants_func() to Lark Nam Cao
2026-06-08  8:57 ` [PATCH v3 05/13] verification/rvgen: Convert __fill_setup_invariants_func() " Nam Cao
2026-06-09 12:39   ` Gabriele Monaco
2026-06-08  8:57 ` [PATCH v3 06/13] verification/rvgen: Convert __fill_verify_guards_func() " Nam Cao
2026-06-08  8:57 ` [PATCH v3 07/13] rv: Simplify hybrid automata monitors's clock variables Nam Cao
2026-06-08  8:57 ` [PATCH v3 08/13] verification/rvgen: Simplify the generation for " Nam Cao
2026-06-08  8:57 ` [PATCH v3 09/13] verification/rvgen: Delete __parse_constraint() Nam Cao
2026-06-10 15:04   ` Gabriele Monaco
2026-06-08  8:57 ` [PATCH v3 10/13] verification/rvgen: Switch __get_event_variables() to Lark Nam Cao
2026-06-10 15:04   ` Gabriele Monaco
2026-06-08  8:57 ` [PATCH v3 11/13] verification/rvgen: Switch __create_matrix() " Nam Cao
2026-06-10 15:05   ` Gabriele Monaco
2026-06-08  8:57 ` [PATCH v3 12/13] verification/rvgen: Remove the old state variables Nam Cao
2026-06-10 15:06   ` Gabriele Monaco
2026-06-08  8:57 ` [PATCH v3 13/13] verification/rvgen: Remove dead code Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a6bdffa673dcfa2df269b1e9d55f093ac4c7394.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox