From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "jolsa@kernel.org" <jolsa@kernel.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"ast@kernel.org" <ast@kernel.org>,
"andrii@kernel.org" <andrii@kernel.org>,
"oleg@redhat.com" <oleg@redhat.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "debug@rivosinc.com" <debug@rivosinc.com>,
"luto@kernel.org" <luto@kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "yhs@fb.com" <yhs@fb.com>,
"songliubraving@fb.com" <songliubraving@fb.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>
Subject: Re: [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with shadow stack
Date: Thu, 30 May 2024 23:04:37 +0000 [thread overview]
Message-ID: <8b70a995dda46c020c9e7c78f0e68560f0b61441.camel@intel.com> (raw)
In-Reply-To: <20240521104825.1060966-2-jolsa@kernel.org>
On Tue, 2024-05-21 at 12:48 +0200, Jiri Olsa wrote:
> Currently the application with enabled shadow stack will crash
> if it sets up return uprobe. The reason is the uretprobe kernel
> code changes the user space task's stack, but does not update
> shadow stack accordingly.
>
> Adding new functions to update values on shadow stack and using
> them in uprobe code to keep shadow stack in sync with uretprobe
> changes to user stack.
>
> Fixes: 8b1c23543436 ("x86/shstk: Add return uprobe support")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
Acked-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
next prev parent reply other threads:[~2024-05-30 23:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 10:48 [PATCHv6 bpf-next 0/9] uprobe: uretprobe speed up Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with shadow stack Jiri Olsa
2024-05-21 14:22 ` Oleg Nesterov
2024-05-21 16:54 ` Jiri Olsa
2024-05-30 23:04 ` Edgecombe, Rick P [this message]
2024-05-21 10:48 ` [PATCHv6 bpf-next 2/9] uprobe: Wire up uretprobe system call Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 4/9] selftests/x86: Add return uprobe shadow stack test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 5/9] selftests/bpf: Add uretprobe syscall test for regs integrity Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 6/9] selftests/bpf: Add uretprobe syscall test for regs changes Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 7/9] selftests/bpf: Add uretprobe syscall call from user space test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 8/9] selftests/bpf: Add uretprobe shadow stack test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 9/9] man2: Add uretprobe syscall page Jiri Olsa
2024-05-21 11:36 ` Alejandro Colomar
2024-05-21 11:48 ` Jiri Olsa
2024-05-21 20:24 ` Jiri Olsa
2024-05-21 20:54 ` Alejandro Colomar
2024-05-22 7:54 ` Jiri Olsa
2024-05-22 10:59 ` Alejandro Colomar
2024-05-22 11:52 ` Jiri Olsa
2024-05-21 20:49 ` [PATCHv6 bpf-next 0/9] uprobe: uretprobe speed up Deepak Gupta
2024-05-21 20:57 ` Alexei Starovoitov
2024-05-22 8:55 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b70a995dda46c020c9e7c78f0e68560f0b61441.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=debug@rivosinc.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).