From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: John Kacur <jkacur@redhat.com>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Clark Williams <williams@redhat.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtla/osnoise: Better report when histogram is empty
Date: Fri, 21 Jun 2024 10:26:11 +0200 [thread overview]
Message-ID: <8ce9d171-4120-4129-ae70-6a54342e0922@kernel.org> (raw)
In-Reply-To: <9d283173-4ff6-fbac-bcc3-e712daa99572@redhat.com>
On 6/12/24 16:12, John Kacur wrote:
>> + /* There are samples above the threshold */
> IMHO The comment isn't needed because the variable had_samples is
> descriptive, but it's not a big deal either
Yeah, I would not do it too, but it is fine.
I am adding it to my queue.
Thanks Luis and John!
-- Daniel
prev parent reply other threads:[~2024-06-21 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 10:36 [PATCH] rtla/osnoise: Better report when histogram is empty Luis Claudio R. Goncalves
2024-06-12 14:12 ` John Kacur
2024-06-21 8:26 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce9d171-4120-4129-ae70-6a54342e0922@kernel.org \
--to=bristot@kernel.org \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).