linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Chen <chen.dylane@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Add WARN_ON_ONCE for syscall_nr check
Date: Thu, 28 Nov 2024 21:15:31 +0800	[thread overview]
Message-ID: <8d4796dc-ef5b-43d8-8ec0-3891b7994428@gmail.com> (raw)
In-Reply-To: <20241128074623.063bf253@rorschach.local.home>

在 2024/11/28 20:46, Steven Rostedt 写道:
> On Thu, 28 Nov 2024 19:53:19 +0800
> Tao Chen <chen.dylane@gmail.com> wrote:
> 
>> Now, x86_64 kernel not support to trace syscall for ia32 syscall.
>> As a result, there is no any trace output when tracing a ia32 task.
>> Like unreg_event_syscall_enter, add a WARN_ON_ONCE judgment for
>> syscall_nr in perf_syscall_enter and ftrace_syscall_enter to give
>> some message.
> 
> So on a system that has "panic_on_warn" set and they trace a 32 bit
> system call, it will cause their system to crash. Is that the intended
> behavior?
> 
> WARN*() is for self testing the kernel to detect real bugs, not to
> inform users that something isn't supported.
> 
> BIG NAK!
> 
> -- Steve

Hi, Steve, thank you for your reply, as you say, so what about 
pr_warn_once api just to print something ?

-- 
Best Regards
Dylane Chen

  reply	other threads:[~2024-11-28 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 11:53 [PATCH] tracing: Add WARN_ON_ONCE for syscall_nr check Tao Chen
2024-11-28 12:46 ` Steven Rostedt
2024-11-28 13:15   ` Tao Chen [this message]
2024-11-28 14:27     ` Mathieu Desnoyers
2024-11-29  2:48       ` Tao Chen
2024-11-28 15:03     ` Steven Rostedt
2024-11-28 16:02       ` Mathieu Desnoyers
2024-11-28 16:52         ` Steven Rostedt
2024-11-29  2:51       ` Tao Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d4796dc-ef5b-43d8-8ec0-3891b7994428@gmail.com \
    --to=chen.dylane@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).