From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Cc: "wuqiang . matt" <wuqiang.matt@bytedance.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()
Date: Tue, 24 Oct 2023 18:43:06 +0200 [thread overview]
Message-ID: <94eb50973fb770586496d2a791b9980a105d7429.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <169815917362.8695.13904684741526725648.stgit@devnote2>
On Tue, 2023-10-24 at 23:52 +0900, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Use generic_cmpxchg_local() for arch_cmpxchg_local() implementation
> in SH architecture because it does not implement arch_cmpxchg_local().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310241310.Ir5uukOG-lkp@intel.com/
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> arch/sh/include/asm/cmpxchg.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sh/include/asm/cmpxchg.h b/arch/sh/include/asm/cmpxchg.h
> index 288f6f38d98f..e920e61fb817 100644
> --- a/arch/sh/include/asm/cmpxchg.h
> +++ b/arch/sh/include/asm/cmpxchg.h
> @@ -71,4 +71,6 @@ static inline unsigned long __cmpxchg(volatile void * ptr, unsigned long old,
> (unsigned long)_n_, sizeof(*(ptr))); \
> })
>
> +#include <asm-generic/cmpxchg-local.h>
> +
> #endif /* __ASM_SH_CMPXCHG_H */
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2023-10-24 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:52 [PATCH] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local() Masami Hiramatsu (Google)
2023-10-24 15:08 ` Mark Rutland
2023-10-24 23:42 ` Masami Hiramatsu
2023-10-25 1:51 ` wuqiang.matt
2023-10-25 11:06 ` wuqiang.matt
2023-10-25 10:30 ` Mark Rutland
2023-10-25 10:32 ` John Paul Adrian Glaubitz
2023-10-25 13:16 ` Geert Uytterhoeven
2023-10-25 14:57 ` Masami Hiramatsu
2023-10-24 16:43 ` John Paul Adrian Glaubitz [this message]
2023-10-25 11:26 ` [External] " wuqiang.matt
2023-10-25 15:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94eb50973fb770586496d2a791b9980a105d7429.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=wuqiang.matt@bytedance.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).