From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Qais Yousef <qyousef@layalina.io>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Metin Kaya <metin.kaya@arm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task()
Date: Wed, 5 Jun 2024 16:05:19 +0200 [thread overview]
Message-ID: <9f21c8e5-1103-44fa-82bd-cf608f8a96f6@redhat.com> (raw)
In-Reply-To: <20240605093246.4h0kCR67@linutronix.de>
On 6/5/24 11:32, Sebastian Andrzej Siewior wrote:
> On 2024-06-04 17:57:46 [+0200], Daniel Bristot de Oliveira wrote:
>> On 6/4/24 16:42, Qais Yousef wrote:
>>> - (wakeup_rt && !dl_task(p) && !rt_task(p)) ||
>>> + (wakeup_rt && !realtime_task(p)) ||
>>
>> I do not like bikeshedding, and no hard feelings...
>>
>> But rt is a shortened version of realtime, and so it is making *it less*
>> clear that we also have DL here.
>
> Can SCHED_DL be considered a real-time scheduling class as in opposite
> to SCHED_BATCH for instance? Due to its requirements it fits for a real
> time scheduling class, right?
> And RT (as in real time) already includes SCHED_RR and SCHED_FIFO.
It is a real-time scheduler, but the problem is that FIFO and RR are in rt.c and
they are called the "realtime" ones, so they are the first to come in mind.
-- Daniel
>> -- Daniel
>
> Sebastian
>
next prev parent reply other threads:[~2024-06-05 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 14:42 [PATCH v5 0/2] Clean up usage of rt_task() Qais Yousef
2024-06-04 14:42 ` [PATCH v5 1/2] sched/rt: " Qais Yousef
2024-06-04 15:57 ` Daniel Bristot de Oliveira
2024-06-04 16:37 ` Steven Rostedt
2024-06-04 17:30 ` Daniel Bristot de Oliveira
2024-06-05 9:32 ` Sebastian Andrzej Siewior
2024-06-05 13:24 ` Qais Yousef
2024-06-05 14:07 ` Daniel Bristot de Oliveira
2024-06-10 19:21 ` Qais Yousef
2024-06-05 14:05 ` Daniel Bristot de Oliveira [this message]
2024-06-04 14:42 ` [PATCH v5 2/2] sched/rt, dl: Convert functions to return bool Qais Yousef
2024-06-04 16:28 ` Steven Rostedt
2024-06-05 6:54 ` Metin Kaya
2024-06-05 9:33 ` [PATCH v5 0/2] Clean up usage of rt_task() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f21c8e5-1103-44fa-82bd-cf608f8a96f6@redhat.com \
--to=bristot@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=brauner@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=metin.kaya@arm.com \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).