Linux Trace Kernel
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: <sashiko-reviews@lists.linux.dev>
Cc: <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 10/17] mm/page-flags: check page/folio->private instead of PG_private
Date: Mon, 21 Sep 2026 21:23:28 -0400	[thread overview]
Message-ID: <A794FFD4-DAC4-468B-95D2-BC7FCBF02AAC@nvidia.com> (raw)
In-Reply-To: <2F224947-7601-4266-8A85-7B6B3410C289@nvidia.com>

>>
>>> diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c
>>> index 7fc5a8be5997f..47e4781c5fc38 100644
>>> --- a/tools/mm/page-types.c
>>> +++ b/tools/mm/page-types.c
>>
>> [ ... ]
>>
>>> @@ -131,7 +130,6 @@ static const char * const page_flag_names[] = {
>>>  	[KPF_RESERVED]		= "r:reserved",
>>>  	[KPF_MLOCKED]		= "m:mlocked",
>>>  	[KPF_OWNER_2]		= "d:owner_2",
>>> -	[KPF_PRIVATE]		= "P:private",
>>>  	[KPF_PRIVATE_2]		= "p:private_2",
>>
>> [Severity: Medium]
>> Does removing the flag name from page_flag_names in page-types.c break
>> parsing tools relying on the P:private designation?
>
> Will send a separate patch to fix page-type.c

Misread the review. The change is intended. Any related parsing tool
needs to adapt to the change.

>
>>
>> -- 
>> Sashiko AI review · https://sashiko.dev/#/patchset/20260920-remove-pg_private-v5-0-bb68b6a21869@nvidia.com?part=10


Best Regards,
Yan, Zi

  reply	other threads:[~2026-09-22  1:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  2:27 [PATCH v5 00/17] Remove PG_private by using page/folio->private checks instead Zi Yan
2026-09-21  2:28 ` [PATCH v5 10/17] mm/page-flags: check page/folio->private instead of PG_private Zi Yan
2026-09-21  2:44   ` sashiko-bot
2026-09-21 15:38     ` Zi Yan
2026-09-22  1:23       ` Zi Yan [this message]
2026-09-21  9:22   ` David Hildenbrand (Arm)
2026-09-21  2:28 ` [PATCH v5 17/17] mm/page-flags: remove PG_private Zi Yan
2026-09-21  2:55   ` sashiko-bot
2026-09-21 15:36     ` Zi Yan
2026-09-21  4:08 ` [PATCH v5 00/17] Remove PG_private by using page/folio->private checks instead Andrew Morton
2026-09-22  4:16 ` Nanzhe Zhao
2026-09-22 15:31   ` [f2fs-dev] " Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A794FFD4-DAC4-468B-95D2-BC7FCBF02AAC@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox