From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010053.outbound.protection.outlook.com [52.101.61.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB14C34AAF3; Thu, 18 Dec 2025 15:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073277; cv=fail; b=e0RxvwdmxWZL+KITVFYStfxRcc0S1O19VTh9wS8fdN0EIk7mZ0cphXBhBSV9XPl+s642OwCKQuaPabjofZHnrYNzWr78fQqxl+hzuJF9je17S+E8BFLCCI8ffKc6n/KEGWVccBBXhcKFsQ8UWu+7/gH91xd4JKiPBT9vOchmLOw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073277; c=relaxed/simple; bh=Qk3otDwEgm3a63rxqlpinDW31TePUAyCxZc/ZM4+3us=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dlO2qKLGKY3oSI1ki7GEZtyqCpEjxcxJt4Cw5pjBvm6cURPGjkkpsOEoQrtEa9L4C8/W1kbjXwVZnA0kqS2GRWz1gWSmx6YAXbIDDVb3i770UhJobRYNAa5IQVk2ZRUUuh1woec5jVnMXFx3bfbbkCgvpZLiS2rW4tB3YpSCQjQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=geUy1JgY; arc=fail smtp.client-ip=52.101.61.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="geUy1JgY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q1uLEaINZDa4m7L5fSPTTwJgUUqZLgfy3xElPQcwr8gnBQt7UZFGRvXqjcDr/PQjvyloB+5qFhBjP/toT9ugaGUFW3ft0bZOxg7d5cVjCytiwnOyKZsZNpfndZwrMw3zx2VlYzn1jBbu05FK59aTmaHXtSyVYRlMA5TqdfKP+D6OSRg6wGQqRXHmpsIsVQGdAjRByGJl9Zc1Eej/CrwJA++Rhg28nGHn8DYicuDq449nbkiEK1eROfgFvM215pDfGmOOe6TfUwoVPoff/suMQ4ILYlAXQVYow8J9dVw7kTypgSsYuJhVGU9dTN4TOuIpdXe7H3MX0+WJJpTd4eoCBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ubOI3RAdhIpJWqIrFgi+2kr5PF4dCzie2rZziYOzxKY=; b=Is+e/s8oZnhxWWPV8FVKdQNo1tOVESRGd2Y2iJqgRRRLdNkrcgN11eVrztbyrwJBTL2dLcxW67x7bEdlc5ZtzMxGb9qxRaS6HuozOxu0fVWemeJMHtQ9gRiCHXo+dGa9cPKOwOAtQ2TDM38MYyhLTK1NWDBoVgS6E1i9wJU3s+FYsN5kkqfCklX9EstiZfiJ+4wpvAwL+tSBGYVSP/4c/Tb4kDYs2vhDmezSBN9immIhQZgOi0zVhv1UEheNExWXrqpkpP0W1oufStT1nTNYIptmadoeh06hzzl+QcJeD2qqVWxMwUaHW1VL0v2a3l6KTVeugVuJaaYrDGoEgXgR8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ubOI3RAdhIpJWqIrFgi+2kr5PF4dCzie2rZziYOzxKY=; b=geUy1JgYEgRiUKc95Sn3rnCqVEi1lvwVl10IGEhfxmIZnRtq5+fSHR7ajZJOvilZ8njQA/Xo3LG67iQpcpZ/N3/mgMag0hD8C3Cp1tTbyhxfMMTkuo7FYCPaVm0OK+d1fUm0NUE59PFjuro+Ra4vIuv6MarOg80xEXeVdC/R19Nt1L6b4mmjHn6I01Vmua7swLcCAYqjE+Xa4IbxlPt96Pij6leaaqHlok0LbY6gbjKhcM5C1bpdt1zJ7xd0hiNOT/LjdcVDAX8m9QcsGOkTd4KZQGZjdlN/IRuo8V6LywGyFf1JnO9HvkPmLuCpi9RDmmJ5dpgiWSOv2gzBuJUYZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by BL1PR12MB5825.namprd12.prod.outlook.com (2603:10b6:208:394::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.8; Thu, 18 Dec 2025 15:54:33 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.9434.001; Thu, 18 Dec 2025 15:54:32 +0000 From: Zi Yan To: "David Hildenbrand (Red Hat)" Cc: "Garg, Shivank" , Andrew Morton , Lorenzo Stoakes , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm/khugepaged: use enum scan_result for result variables Date: Thu, 18 Dec 2025 10:54:30 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: In-Reply-To: References: <20251216111139.95438-2-shivankg@amd.com> <20251216111139.95438-6-shivankg@amd.com> <79fb5cb2-8a24-4260-a9e9-bdf2c5ef602f@amd.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL6PEPF00013DF7.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1001:0:9) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|BL1PR12MB5825:EE_ X-MS-Office365-Filtering-Correlation-Id: 46a4d51b-83d1-4441-359e-08de3e4dbc1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gFBASXaZy4kK5UCUYQMDtRIQEcDGeunysB1d4uTu9r26LG5nMnP6iOBHpLK7?= =?us-ascii?Q?dDKAffloZOtMNLDjekNYu7Ox1MsCy+rN4bLW27ZEB9laocB7KrT/y/7PniTF?= =?us-ascii?Q?ZCfP2THbikb+YLpiHqCMHzwwOuOqtNQcoxUPnMYhc5vSljJpmtIwE/9UI0sx?= =?us-ascii?Q?NYSSywTcz0h+vV1pWQSWIII4NTJdkF7HWUBOHhboIX35i7SzwwqM05GS7IC1?= =?us-ascii?Q?dFwNTVzbec8xHWexBOYcul7xkqfScbQsbGi+OJiTD/6hG2oDp3GjBcAKRw5z?= =?us-ascii?Q?89KIEzNoTLaDv7tyNsXgk6JpNsK3NG4TtAIL6NVnDTRjUZenK6fEakHK53t2?= =?us-ascii?Q?UKyGRJ+38HNXScQzqhtFl8nPz6oryIFWfF+Rdl3o7i7LZMxeAAdHKvu8LfDz?= =?us-ascii?Q?bZnaHCSOP41NeHa1UTO4aPhtxYHx7woWKqIrKgLIKN/I8RGx9NJL4Wtdv6Yu?= =?us-ascii?Q?C/iBdWVG7X55pTqjTVFEm9KR82TVkJ9l7VcaxvqAkx/nEV8IveizNGamV8s6?= =?us-ascii?Q?uVJ2qx1Gngtl9vNMqUupzpidNvwwjHpMixFu9ZGE3Y8IxsaBkJ4bkWYsQqho?= =?us-ascii?Q?eEQVED2QPsqr9s3z/ciFERDqZw+Qz0oW6lSL68dWmVvt+66fIimu51sEj7ir?= =?us-ascii?Q?gIlvxeFuB5SLTlk3c+/dfAvqvhY3+7v+hilvPDY5qvWEFOyoTI1eIRXA3DrB?= =?us-ascii?Q?BbeVrACoB6JnHKJWx9wVYODTUr7gAslHzOZEpLN80Z7E9WGIuTCypUM9zNsz?= =?us-ascii?Q?6PTeTJVmhKC5UTYxpJ1TIn5l1QKdu1tcdgqZhWTczPZtDcJp+FCiMHWCEjE5?= =?us-ascii?Q?iZ6/ImChvx264TBDlFzmMheP2azktHuZCmpMk5kQrmWQilNUDs7lHVJ+bNa+?= =?us-ascii?Q?0uRMpWaKk0HT0HheG+dzHv6NfTd2jFRD2JZj0joS2yLpEy3meEBjkAeQhGDJ?= =?us-ascii?Q?NM3aUCBBkHwNmmvZv+oH0HLwZZjZU94DnGVyEz33tv6RzVXiZ7bLMnPWASXV?= =?us-ascii?Q?tN4e/zCxarH4Eb8V6TLTgxpazelCtNYmGPNZr0N7azvPOzLGl7b/rtEPt/Xp?= =?us-ascii?Q?uZaYBN9p7eTEMg1v5FEpT1aDrlNBkQA3YQvu1iKFf9m4o6l7if8FKKkpbMar?= =?us-ascii?Q?JfjwI/xgj1QeonHmJSFAHE2bIhMRp07FZfKHoXiGfv4HU9rgnWseEYzOzIU8?= =?us-ascii?Q?OV+hfiXt9EtpXWeDmY5EtHWtHwl8XgJZu7CKRIrn1HQyXwSgX08GpHwg+6UO?= =?us-ascii?Q?4cCqE/IU7Ud+KkNOGMcKqew5D58e8oVVld9+tfKkEn3m7X/RKJzJHLjgmSe3?= =?us-ascii?Q?K+3WstL97Ws9SbKM/Udqbv2TyZ2u7br2VdpJIBeHer1AOLYOpmWQbsjTpn3s?= =?us-ascii?Q?I4YBhTP83keUgzvGbOouPn0ULzECqj40ZGuQT4FZ5mgTnkcH1IsLo6eWnmex?= =?us-ascii?Q?yWQMIUP2dfuTpt5jtKmyH/1p47ZPF1+Q?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xjiDR07+fOEt90gqgFQVeSAZsn8rhSzfH64q95ymUdemWRkChnfAWL4qB54X?= =?us-ascii?Q?CFbWujgJY6SA7vdGaAPE86/mMVeHg0UZah4LKzcAi8FJM3oodCsX4YSIDiBc?= =?us-ascii?Q?+TinKkpnq/FsDP5ktw6V9TNnjb25LTEiVXKhygOQluCR8NCOnypwXOisU1Xf?= =?us-ascii?Q?FM1X3+SfboppWKpR4pvTxBJKUhXthTK/N88FWy3Bv0gCffWnXh5pKEs2kDoq?= =?us-ascii?Q?rBEKrMU1pCKMHwjLV9Sd/IqXhMR591nrdtw43P0FvMMpswMevtqO4+VhqC4f?= =?us-ascii?Q?KAEvkZ+6zhyxYvbl/ml2VeslyebcSQOe9HRQg39kt8xNnwFxBfX9sahJGZc3?= =?us-ascii?Q?IVjP8zGSg2Ju7+Nlhkw3N0o4ZlBQbSB/QHzXnDPXv44WM2LDoq3pQZaLQNCn?= =?us-ascii?Q?O7C1O/fe2nrsZkw4qTWazAmyH68gvnYZv/fMqDvNqdakRsb8iQY0iJ7ywM+i?= =?us-ascii?Q?mCRd3tPeHiQiQjTRZhgpAvn29YVp4M3gcviPHNHg0azB3OPoGTZ0Ph2TE4Sw?= =?us-ascii?Q?uMNZ74ehMSxyALZ3HCDPCcisWuHTN/gCx90Om4mHUWOY4xlci711Yw1yHWmq?= =?us-ascii?Q?aJGxLX4Kb3Tfbkl1QpcIRcF36zm2NLK+nC1NGzWNe6RDjDA8oy2tOltwIRe0?= =?us-ascii?Q?eXNVYF3RWGJalv7rj7X+CFzSMkw6ltQT2n+ZZwcUL0hC55nKEDOoO17f2unm?= =?us-ascii?Q?U6jTpRSFFPAUx0j2QoIdlfU9Rtl1z1JsLqraquuZVzEta9dKkRh7BaEnXrxb?= =?us-ascii?Q?FDGdwi8mgb9lgkh9iijbmlhOuW+4UIvKdninEKsE+kdij94R8L/6lae/Tc5G?= =?us-ascii?Q?TV2LOSNSNaatm2qhGD15Wq2mr0Jdnd6M+F6HRa9aiV/+rjDsb6IBxcK6ItBO?= =?us-ascii?Q?uR91POAsofLeI3/m9Cv+vDIH9Q641dJ2lRMUbB7SXaPoAB5DRtSZB6kPO60X?= =?us-ascii?Q?aUn6iecAcdmj6PAL+qTvYdg9YDjsVRXHOkT0xtLcfARPhYNgxCuTgKMHci/G?= =?us-ascii?Q?eeI8aq3bL52LFdjrGJggVZhLtE7iJB9ndm2JzdnWi139b9pweSb84rBWCJWB?= =?us-ascii?Q?xkKev9Z+cpND9BIaPDfrVXjGKQiG5hKY8UXOBniwjtmGe6Uq6I47PymNb7wL?= =?us-ascii?Q?EzTAtyfDwAY0aKgxXrekDY+C5IjDc2e0+bTBi4EfNpgCSpFOIOJSZtPgX6k9?= =?us-ascii?Q?lKm76KaLZb1DOq7nRZW1WQf/FLcRzS2LS0jrDknA1SWv1L4nNMquaLkY8NXc?= =?us-ascii?Q?zED7C1Vvkwu1PGhCS5y1+hV6bocnfgCr/KB0CvZT3eRH0iaoz6MIzNR+hmbJ?= =?us-ascii?Q?Z1rdtYZOQOMyNwoyfuJELMvQicSy2sKIm7pQZpUrmqhVb+AyR87fpPR0rUdM?= =?us-ascii?Q?Etw5T78NyvgVW66f99LgKzW99rCxmaMqIcHvabK0W93bOLNOnBfdiH7lcUEF?= =?us-ascii?Q?Ed8v6Lgr0+sJwLxUgnAW7BNLLKkT7moLcLVHkNKsVkfOTJuzaNPZu5DDD2RE?= =?us-ascii?Q?B1Emsgz4EmX2ov016MBbBMOyyb23qdb2pMgPrRBUc4wXYBbS05jTG4J6Z3ei?= =?us-ascii?Q?vCLGKmYGyTIeU1OYWXtB2u07xby/kL/BMAKNMChd?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46a4d51b-83d1-4441-359e-08de3e4dbc1c X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2025 15:54:32.3853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FPV8I/yqJG3vF3iPVkR1Svnk6IosSyEJtqnG6MSyjrLGU8RXR6iw6MMJfRLOqSTO X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5825 On 18 Dec 2025, at 4:17, David Hildenbrand (Red Hat) wrote: > On 12/18/25 06:40, Garg, Shivank wrote: >> >> >> On 12/16/2025 9:08 PM, Zi Yan wrote: >>> On 16 Dec 2025, at 6:11, Shivank Garg wrote: >>> >> >>> >>>> int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long ad= dr, >>>> bool install_pmd) >>>> { >>> >>> And here. >> Since this function is declared in khugepaged.h, I need to >> move the enum definition to that header. I see two options for handlin= g >> the CONFIG_TRANSPARENT_HUGEPAGE check: >> >> 1. Define enum OUTSIDE the ifdef: This allows the static inline stub >> to also return enum scan_result, keeping the API consistent. >> 2. Define enum INSIDE the ifdef: The enum is hidden when THP is disabl= ed, >> forcing the stub to return int 0 instead. >> >> The only external caller (uprobes.c) of collapse_pte_mapped_thp curren= tly >> ignores the return value. > > Probably best to not expose that enum (especially when nobody cares ...= ) and instead expose a new void function for uprobe purposes. > > Maybe > > void collapse_pte_mapped_thp(...) > { > try_collapse_pte_mapped_thp(); > } > > Maybe something like that? Sounds good to me. Best Regards, Yan, Zi