From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-trace-kernel@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] tracing/user_events: Run BPF program if attached
Date: Tue, 9 May 2023 08:24:29 -0700 [thread overview]
Message-ID: <CAADnVQLYL-ZaP_2vViaktw0G4UKkmpOK2q4ZXBa+f=M7cC25Rg@mail.gmail.com> (raw)
In-Reply-To: <20230508163751.841-1-beaub@linux.microsoft.com>
On Mon, May 8, 2023 at 9:38 AM Beau Belgrave <beaub@linux.microsoft.com> wrote:
>
> Programs that utilize user_events today only get the event payloads via
> perf or ftrace when writing event data. When BPF programs are attached
> to tracepoints created by user_events the BPF programs do not get run
> even though the attach succeeds. This causes confusion by the users of
> the programs, as they expect the data to be available via BPF programs
> they write. We have several projects that have hit this and requested
> BPF program support when publishing data via user_events from their
> user processes in production.
>
> Swap out perf_trace_buf_submit() for perf_trace_run_bpf_submit() to
> ensure BPF programs that are attached are run in addition to writing to
> perf or ftrace buffers. This requires no changes to the BPF infrastructure
> and only utilizes the GPL exported function that modules and other
> components may use for the same purpose. This keeps user_events consistent
> with how other kernel, modules, and probes expose tracepoint data to allow
> attachment of a BPF program.
Sorry, I have to keep my Nack here.
I see no practical use case for bpf progs to be connected to user events.
There must be a different way to solve your user needs
and this is not bpf.
next prev parent reply other threads:[~2023-05-09 15:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 16:37 [PATCH] tracing/user_events: Run BPF program if attached Beau Belgrave
2023-05-09 15:24 ` Alexei Starovoitov [this message]
2023-05-09 17:01 ` Steven Rostedt
2023-05-09 20:30 ` Steven Rostedt
2023-05-09 20:42 ` Steven Rostedt
2023-05-15 16:57 ` Alexei Starovoitov
2023-05-15 18:33 ` Steven Rostedt
2023-05-15 19:35 ` Beau Belgrave
2023-05-15 21:38 ` Steven Rostedt
2023-05-15 19:24 ` Beau Belgrave
2023-05-15 21:57 ` Steven Rostedt
2023-05-17 0:36 ` Alexei Starovoitov
2023-05-17 0:56 ` Linus Torvalds
2023-05-17 1:46 ` Linus Torvalds
2023-05-17 2:29 ` Steven Rostedt
2023-05-17 3:03 ` Linus Torvalds
2023-05-17 17:22 ` Beau Belgrave
2023-05-17 18:15 ` Linus Torvalds
2023-05-17 19:07 ` Beau Belgrave
2023-05-17 19:26 ` Linus Torvalds
2023-05-17 19:36 ` Beau Belgrave
2023-05-17 19:36 ` Linus Torvalds
2023-05-17 19:37 ` Linus Torvalds
2023-05-17 23:00 ` Beau Belgrave
2023-05-17 23:14 ` Linus Torvalds
2023-05-17 23:25 ` Steven Rostedt
2023-05-18 0:14 ` Beau Belgrave
2023-05-18 0:23 ` Linus Torvalds
2023-05-17 20:08 ` Linus Torvalds
2023-05-17 1:26 ` Steven Rostedt
2023-05-17 16:50 ` Beau Belgrave
2023-05-18 0:10 ` Alexei Starovoitov
2023-05-18 0:19 ` Beau Belgrave
2023-05-18 0:56 ` Alexei Starovoitov
2023-05-18 1:18 ` Beau Belgrave
2023-05-18 2:08 ` Steven Rostedt
2023-05-18 3:14 ` Alexei Starovoitov
2023-05-18 13:36 ` Steven Rostedt
2023-05-18 17:28 ` Beau Belgrave
2023-06-01 9:46 ` Christian Brauner
2023-06-01 15:24 ` Beau Belgrave
2023-06-01 15:57 ` Christian Brauner
2023-06-01 16:29 ` Beau Belgrave
2023-06-06 13:37 ` Masami Hiramatsu
2023-06-06 17:05 ` Beau Belgrave
2023-06-07 14:07 ` Masami Hiramatsu
2023-06-07 19:26 ` Beau Belgrave
2023-06-08 0:25 ` Masami Hiramatsu
2023-05-17 17:51 ` Beau Belgrave
2023-06-06 13:57 ` Masami Hiramatsu
2023-06-06 16:57 ` Andrii Nakryiko
2023-06-06 20:57 ` Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQLYL-ZaP_2vViaktw0G4UKkmpOK2q4ZXBa+f=M7cC25Rg@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=beaub@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).