From: Alexander Potapenko <glider@google.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Marco Elver <elver@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-s390@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v3 27/34] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN
Date: Fri, 22 Dec 2023 12:27:50 +0100 [thread overview]
Message-ID: <CAG_fn=VfYNpMynQtXiKemoDy3LjH5Hn8N-VpzH6AGVZ3jDHPUQ@mail.gmail.com> (raw)
In-Reply-To: <20231213233605.661251-28-iii@linux.ibm.com>
On Thu, Dec 14, 2023 at 12:36 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> KMSAN generates the following false positives on s390x:
>
> [ 6.063666] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled())
> [ ...]
> [ 6.577050] Call Trace:
> [ 6.619637] [<000000000690d2de>] check_flags+0x1fe/0x210
> [ 6.665411] ([<000000000690d2da>] check_flags+0x1fa/0x210)
> [ 6.707478] [<00000000006cec1a>] lock_acquire+0x2ca/0xce0
> [ 6.749959] [<00000000069820ea>] _raw_spin_lock_irqsave+0xea/0x190
> [ 6.794912] [<00000000041fc988>] __stack_depot_save+0x218/0x5b0
> [ 6.838420] [<000000000197affe>] __msan_poison_alloca+0xfe/0x1a0
> [ 6.882985] [<0000000007c5827c>] start_kernel+0x70c/0xd50
> [ 6.927454] [<0000000000100036>] startup_continue+0x36/0x40
>
> Between trace_hardirqs_on() and `stosm __mask, 3` lockdep thinks that
> interrupts are on, but on the CPU they are still off. KMSAN
> instrumentation takes spinlocks, giving lockdep a chance to see and
> complain about this discrepancy.
>
> KMSAN instrumentation is inserted in order to poison the __mask
> variable. Disable instrumentation in the respective functions. They are
> very small and it's easy to see that no important metadata updates are
> lost because of this.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
next prev parent reply other threads:[~2023-12-22 11:28 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 23:24 [PATCH v3 00/34] kmsan: Enable on s390 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 01/34] ftrace: Unpoison ftrace_regs in ftrace_ops_list_func() Ilya Leoshkevich
2024-01-02 15:17 ` Steven Rostedt
2024-06-12 15:37 ` Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 02/34] kmsan: Make the tests compatible with kmsan.panic=1 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 03/34] kmsan: Disable KMSAN when DEFERRED_STRUCT_PAGE_INIT is enabled Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 04/34] kmsan: Increase the maximum store size to 4096 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 05/34] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 06/34] kmsan: Fix kmsan_copy_to_user() " Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 07/34] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 08/34] kmsan: Remove an x86-specific #include from kmsan.h Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 09/34] kmsan: Expose kmsan_get_metadata() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 10/34] kmsan: Export panic_on_kmsan Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 11/34] kmsan: Allow disabling KMSAN checks for the current task Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 12/34] kmsan: Support SLAB_POISON Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 13/34] kmsan: Use ALIGN_DOWN() in kmsan_get_metadata() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 14/34] mm: slub: Let KMSAN access metadata Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 15/34] mm: slub: Unpoison the memchr_inv() return value Ilya Leoshkevich
2024-01-02 16:10 ` Vlastimil Babka
2023-12-13 23:24 ` [PATCH v3 16/34] mm: kfence: Disable KMSAN when checking the canary Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 17/34] lib/zlib: Unpoison DFLTCC output buffers Ilya Leoshkevich
2023-12-22 11:35 ` Alexander Potapenko
2023-12-13 23:24 ` [PATCH v3 18/34] kmsan: Accept ranges starting with 0 on s390 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 19/34] s390: Turn off KMSAN for boot, vdso and purgatory Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 20/34] s390: Use a larger stack for KMSAN Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 21/34] s390/boot: Add the KMSAN runtime stub Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 22/34] s390/checksum: Add a KMSAN check Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 23/34] s390/cpacf: Unpoison the results of cpacf_trng() Ilya Leoshkevich
2024-01-02 14:34 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 24/34] s390/cpumf: Unpoison STCCTM output buffer Ilya Leoshkevich
2023-12-20 11:04 ` Alexander Potapenko
2024-01-02 14:38 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 25/34] s390/diag: Unpoison diag224() " Ilya Leoshkevich
2024-01-02 14:56 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 26/34] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() Ilya Leoshkevich
2024-01-02 14:56 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 27/34] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN Ilya Leoshkevich
2023-12-22 11:27 ` Alexander Potapenko [this message]
2024-01-02 15:01 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules Ilya Leoshkevich
2023-12-21 12:14 ` Alexander Gordeev
2024-01-02 15:05 ` Heiko Carstens
2024-01-04 10:03 ` Alexander Gordeev
2024-01-04 11:34 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 29/34] s390/string: Add KMSAN support Ilya Leoshkevich
2024-01-02 15:05 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 30/34] s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs Ilya Leoshkevich
2024-01-02 15:06 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 31/34] s390/uaccess: Add KMSAN support to put_user() and get_user() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 32/34] s390/unwind: Disable KMSAN checks Ilya Leoshkevich
2024-01-02 15:09 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 33/34] s390: Implement the architecture-specific kmsan functions Ilya Leoshkevich
2023-12-20 11:27 ` Alexander Potapenko
2024-01-02 15:14 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 34/34] kmsan: Enable on s390 Ilya Leoshkevich
2024-01-02 15:15 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=VfYNpMynQtXiKemoDy3LjH5Hn8N-VpzH6AGVZ3jDHPUQ@mail.gmail.com' \
--to=glider@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=iii@linux.ibm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).