* [PATCH] writeback: Refine the show_inode_state() macro definition
@ 2024-08-20 9:49 Julian Sun
2024-08-20 9:54 ` Julian Sun
0 siblings, 1 reply; 5+ messages in thread
From: Julian Sun @ 2024-08-20 9:49 UTC (permalink / raw)
To: linux-trace-kernel, linux-fsdevel
Cc: jack, brauner, viro, mhiramat, rostedt, mathieu.desnoyers,
Julian Sun
Currently, the show_inode_state() macro only prints
part of the state of inode->i_state. Let’s improve it
to display more of its state.
Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
---
include/trace/events/writeback.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 54e353c9f919..a2c2bb1cddd7 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -21,6 +21,15 @@
{I_SYNC, "I_SYNC"}, \
{I_DIRTY_TIME, "I_DIRTY_TIME"}, \
{I_REFERENCED, "I_REFERENCED"} \
+ {I_DIO_WAKEUP, "I_DIO_WAKEUP"} \
+ {I_LINKABLE, "I_LINKABLE"} \
+ {I_DIRTY_TIME, "I_DIRTY_TIME"} \
+ {I_WB_SWITCH, "I_WB_SWITCH"} \
+ {I_OVL_INUSE, "I_OVL_INUSE"} \
+ {I_CREATING, "I_CREATING"} \
+ {I_DONTCACHE, "I_DONTCACHE"} \
+ {I_SYNC_QUEUED, "I_SYNC_QUEUED"} \
+ {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
)
/* enums need to be exported to user space */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] writeback: Refine the show_inode_state() macro definition
2024-08-20 9:49 [PATCH] writeback: Refine the show_inode_state() macro definition Julian Sun
@ 2024-08-20 9:54 ` Julian Sun
0 siblings, 0 replies; 5+ messages in thread
From: Julian Sun @ 2024-08-20 9:54 UTC (permalink / raw)
To: linux-trace-kernel, linux-fsdevel
Cc: jack, brauner, viro, mhiramat, rostedt, mathieu.desnoyers
Apologies, this patch was sent by mistake. Please refer to the latest patch
Julian Sun <sunjunchao2870@gmail.com> 于2024年8月20日周二 17:49写道：
>
> Currently, the show_inode_state() macro only prints
> part of the state of inode->i_state. Let’s improve it
> to display more of its state.
>
> Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
> ---
> include/trace/events/writeback.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 54e353c9f919..a2c2bb1cddd7 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -21,6 +21,15 @@
> {I_SYNC, "I_SYNC"}, \
> {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
> {I_REFERENCED, "I_REFERENCED"} \
> + {I_DIO_WAKEUP, "I_DIO_WAKEUP"} \
> + {I_LINKABLE, "I_LINKABLE"} \
> + {I_DIRTY_TIME, "I_DIRTY_TIME"} \
> + {I_WB_SWITCH, "I_WB_SWITCH"} \
> + {I_OVL_INUSE, "I_OVL_INUSE"} \
> + {I_CREATING, "I_CREATING"} \
> + {I_DONTCACHE, "I_DONTCACHE"} \
> + {I_SYNC_QUEUED, "I_SYNC_QUEUED"} \
> + {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
> )
>
> /* enums need to be exported to user space */
> --
> 2.39.2
>
--
Julian Sun <sunjunchao2870@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] writeback: Refine the show_inode_state() macro definition
@ 2024-08-20 9:52 Julian Sun
2024-08-27 16:21 ` Jan Kara
0 siblings, 1 reply; 5+ messages in thread
From: Julian Sun @ 2024-08-20 9:52 UTC (permalink / raw)
To: linux-trace-kernel, linux-fsdevel
Cc: jack, brauner, viro, mhiramat, rostedt, mathieu.desnoyers,
Julian Sun
Currently, the show_inode_state() macro only prints
part of the state of inode->i_state. Let’s improve it
to display more of its state.
Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
---
include/trace/events/writeback.h | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 54e353c9f919..f3e0edc1a311 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -20,7 +20,16 @@
{I_CLEAR, "I_CLEAR"}, \
{I_SYNC, "I_SYNC"}, \
{I_DIRTY_TIME, "I_DIRTY_TIME"}, \
- {I_REFERENCED, "I_REFERENCED"} \
+ {I_REFERENCED, "I_REFERENCED"}, \
+ {I_DIO_WAKEUP, "I_DIO_WAKEUP"}, \
+ {I_LINKABLE, "I_LINKABLE"}, \
+ {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
+ {I_WB_SWITCH, "I_WB_SWITCH"}, \
+ {I_OVL_INUSE, "I_OVL_INUSE"}, \
+ {I_CREATING, "I_CREATING"}, \
+ {I_DONTCACHE, "I_DONTCACHE"}, \
+ {I_SYNC_QUEUED, "I_SYNC_QUEUED"}, \
+ {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
)
/* enums need to be exported to user space */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] writeback: Refine the show_inode_state() macro definition
2024-08-20 9:52 Julian Sun
@ 2024-08-27 16:21 ` Jan Kara
2024-08-28 7:44 ` Julian Sun
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kara @ 2024-08-27 16:21 UTC (permalink / raw)
To: Julian Sun
Cc: linux-trace-kernel, linux-fsdevel, jack, brauner, viro, mhiramat,
rostedt, mathieu.desnoyers
On Tue 20-08-24 17:52:29, Julian Sun wrote:
> Currently, the show_inode_state() macro only prints
> part of the state of inode->i_state. Let’s improve it
> to display more of its state.
>
> Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
> ---
> include/trace/events/writeback.h | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Yeah, it could be useful at times. Some comments below.
> @@ -20,7 +20,16 @@
> {I_CLEAR, "I_CLEAR"}, \
> {I_SYNC, "I_SYNC"}, \
> {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
> - {I_REFERENCED, "I_REFERENCED"} \
> + {I_REFERENCED, "I_REFERENCED"}, \
> + {I_DIO_WAKEUP, "I_DIO_WAKEUP"}, \
I_DIO_WAKEUP is never set and is being removed, please don't put it here.
> + {I_LINKABLE, "I_LINKABLE"}, \
> + {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
Um, I_DIRTY_TIME is already included.
> + {I_WB_SWITCH, "I_WB_SWITCH"}, \
> + {I_OVL_INUSE, "I_OVL_INUSE"}, \
> + {I_CREATING, "I_CREATING"}, \
> + {I_DONTCACHE, "I_DONTCACHE"}, \
> + {I_SYNC_QUEUED, "I_SYNC_QUEUED"}, \
> + {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
> )
Otherwise the patch looks good to me.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] writeback: Refine the show_inode_state() macro definition
2024-08-27 16:21 ` Jan Kara
@ 2024-08-28 7:44 ` Julian Sun
0 siblings, 0 replies; 5+ messages in thread
From: Julian Sun @ 2024-08-28 7:44 UTC (permalink / raw)
To: Jan Kara
Cc: linux-trace-kernel, linux-fsdevel, brauner, viro, mhiramat,
rostedt, mathieu.desnoyers
On Tue, 2024-08-27 at 18:21 +0200, Jan Kara wrote:
> On Tue 20-08-24 17:52:29, Julian Sun wrote:
> > Currently, the show_inode_state() macro only prints
> > part of the state of inode->i_state. Let’s improve it
> > to display more of its state.
> >
> > Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
> > ---
> > include/trace/events/writeback.h | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
>
> Yeah, it could be useful at times. Some comments below.
>
> > @@ -20,7 +20,16 @@
> > {I_CLEAR, "I_CLEAR"}, \
> > {I_SYNC, "I_SYNC"}, \
> > {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
> > - {I_REFERENCED, "I_REFERENCED"} \
> > + {I_REFERENCED, "I_REFERENCED"}, \
> > + {I_DIO_WAKEUP, "I_DIO_WAKEUP"}, \
>
> I_DIO_WAKEUP is never set and is being removed, please don't put it
> here.
>
> > + {I_LINKABLE, "I_LINKABLE"}, \
> > + {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
>
> Um, I_DIRTY_TIME is already included.
>
> > + {I_WB_SWITCH, "I_WB_SWITCH"}, \
> > + {I_OVL_INUSE, "I_OVL_INUSE"}, \
> > + {I_CREATING, "I_CREATING"}, \
> > + {I_DONTCACHE, "I_DONTCACHE"}, \
> > + {I_SYNC_QUEUED, "I_SYNC_QUEUED"}, \
> > + {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"} \
> > )
>
> Otherwise the patch looks good to me.
Thanks for your review and comments, I will fix them in patch v2.
>
> Honza
Thanks,
--
Julian Sun <sunjunchao2870@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-28 7:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 9:49 [PATCH] writeback: Refine the show_inode_state() macro definition Julian Sun
2024-08-20 9:54 ` Julian Sun
-- strict thread matches above, loose matches on Subject: below --
2024-08-20 9:52 Julian Sun
2024-08-27 16:21 ` Jan Kara
2024-08-28 7:44 ` Julian Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).