From: Jason Xing <kerneljasonxing@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Yushan Zhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function
Date: Fri, 16 May 2025 13:44:32 +0800 [thread overview]
Message-ID: <CAL+tcoBmLvPh-OhmUP2O5BoR3_FPWPXyLFhipNh5b-xHTGCb7A@mail.gmail.com> (raw)
In-Reply-To: <aCbH1eA8Iicg_Fq_@infradead.org>
On Fri, May 16, 2025 at 1:06 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, May 16, 2025 at 01:02:59PM +0800, Jason Xing wrote:
> > Do you mean make it inline in include/linux/relay.h like how
> > relay_write() works?
> >
> > Will do that.
>
> Just drop the extern, which is not needed:
>
> size_t relay_dump(struct rchan *chan, int flags);
Got it.
>
> > >
> > > This export seems unused even with the entire series applied.
> >
> > My initial thought was to provide a symbol for some kernel modules to use.
>
> The only user is blktrace, which can't be modular. Or you plan to
> submit a modular user soon, like in the next merge window/ If so
> note that and add a pointer to it in the cover letter.
I'm still thinking about how to upstream my internal module... So in
this series, I will remove it.
Thanks,
Jason
next prev parent reply other threads:[~2025-05-16 5:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 6:16 [PATCH v2 0/4] relayfs: misc changes Jason Xing
2025-05-15 6:16 ` [PATCH v2 1/4] relayfs: support a counter tracking if per-cpu buffers is full Jason Xing
2025-05-15 18:17 ` Jens Axboe
2025-05-15 6:16 ` [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 23:24 ` Jason Xing
2025-05-16 2:08 ` Masami Hiramatsu
2025-05-16 2:32 ` Jason Xing
2025-05-16 4:37 ` Christoph Hellwig
2025-05-16 5:02 ` Jason Xing
2025-05-16 5:06 ` Christoph Hellwig
2025-05-16 5:44 ` Jason Xing [this message]
2025-05-15 6:16 ` [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 18:21 ` Jens Axboe
2025-05-15 23:26 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 4/4] relayfs: support a counter tracking if data is too big to write Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL+tcoBmLvPh-OhmUP2O5BoR3_FPWPXyLFhipNh5b-xHTGCb7A@mail.gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=katrinzhou@tencent.com \
--cc=kernelxing@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).