From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC1B21B45C; Fri, 11 Oct 2024 14:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728656082; cv=none; b=ax2fM2bSK2rW+HGj1BYawU0+HV86mpK1KZizXmagqQZ8958hFnf7GTFHg0DhU2vANsBRhsNlj/nxtMgO0snlMcBO/0UBno35qiyMaF6BrdR5V1cdZCg17xlpcqFbMj/tZMIX1G05hrrXnIShnm0pTz7MpY4g36doRGZa+8McJy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728656082; c=relaxed/simple; bh=ryyL7dxIat+0r10d+WkpqRKV7UFPwxP7xx/GPr0VPuo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=C1rPPbZIPj0dbHkAX9KTkjIw/LGEZDZDUHqvt3D9PvpohkxHK910iy7b4Rvr7nIXUdraXkV2CMH7FYE3hJ8em4RwQJYAE+eKI/x1g07Djh0h+Ev455DeGzAJFWTocwZ9KKsKTxT1TahpcUXeMhXUfnTQPswfh++dJi6oFE3GR6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e291b96a64dso801854276.3; Fri, 11 Oct 2024 07:14:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728656077; x=1729260877; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gKxV6SBUpmC9EeWLExsOgYq7J6RKtlJifOwyXdEfMFs=; b=bi5WIXRHq6KenqTi6MdjLUFe1o1I0TLBwnBuioAD/JdSakCWRgt57Yn1CI93W/qHIs qO8g/9JVnm6PUCOmb7NnIlgk2lIoiKCc90GVEAoSaLKUrFkU87GUT24rxBUr2fJbqOp8 dFfEVDnt6NWNk/glhNIQ13VRlWqcm9+imvnZs9qqcil8XqFVbsseOLA1ovTv36D1NTtF WIJcNEcmA/hrzGK+IQO7k+/Gl9CCqWF3yKLyvi1V6Qhn+PHw9UXNdVOAMLynu3aLtZ41 L33KKRdeqVbgh36fUOZtd0dAdvTXO1Cj+ZX58xswEDKvNu2/6i5b2t3IHbKuszRmh7oE l4Bg== X-Forwarded-Encrypted: i=1; AJvYcCUGKNcG4V23JJwh55Ncmr1tFQVeiGGPfwSjStInJS26gFkBnIaBCCPUEMBsTE8uDBnMBOxFaF8/Xw4aKf0XD9XM@vger.kernel.org, AJvYcCUhnbxJ/AnobMAX60ymTxxVLegweX6+m1F18rUFfIAVsMXb4MgkJafyGg55OQzPGtqxx8Dmoz5pbqkjb72v7sc=@vger.kernel.org, AJvYcCVdNE4bjy9aunlHXd3H5ELPg7iXIL6pro5YjAFULn+kzD0vpGSfG+eOfUKDqId8PkukVywMYTJuqjxLB+IS@vger.kernel.org, AJvYcCVqX/PvNphbWwr0pnJSZuXvIqXIvsySMnPHgzKcX3W1W+yCPdl62fp1lSFIlcNhhyTGbZlQ3lyTD8FU4evjzVoaTbDI@vger.kernel.org X-Gm-Message-State: AOJu0Yw1Lgejb447dCFXw8cmu0hEpzzlGXcH0/nHiyaCNy/nBMN4Ssml Y5IkFWfgj5ufT7Ic1fLmKNmA8VMfZzB5vosRAVPaMMtTXDJTNr/pa4P83eaC7s0= X-Google-Smtp-Source: AGHT+IGTGqF0lbsKbzdsjjpRLwPnSYvYN3jwWle7fZAE9967toH1WgDPgGhPoiX6its1dQztCIVWxQ== X-Received: by 2002:a05:6902:1503:b0:e20:2e8a:5b95 with SMTP id 3f1490d57ef6-e2919fe5e9cmr2674502276.39.1728656077261; Fri, 11 Oct 2024 07:14:37 -0700 (PDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e290ef7a8easm824512276.57.2024.10.11.07.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 07:14:36 -0700 (PDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6dbc9a60480so19562197b3.0; Fri, 11 Oct 2024 07:14:36 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVNNb79bCN3NrwZKEUwrh1+s68GfEw82mFSRgW3uKgDPBAVdcKF+LjB04TUIgOAcFg0hA36LFRF3deARCkrwP0+VMhS@vger.kernel.org, AJvYcCWYC6+jIKC2JbcG/F/lB/QSGOXuz0G+UyHfuuseBWQuJZDIOx463MFWMRTjm/R2LhSWz6oKxlILTl1jaw7U@vger.kernel.org, AJvYcCWc94QVCG2PrRSiOjDjBYQQSeOHjoPbzE5PrMm45pOvGTbsE0NeQyd5WEoidCdfd8ua1flInUoD06AubJo8Ek0=@vger.kernel.org, AJvYcCXGlcFOwZCqOwNCnaSP3QT7yLiXG2l5852T/1C5xwLIBUb+UiyaeK5gyz0b0g0r7noWJNNag0h8RUba334wrGGS@vger.kernel.org X-Received: by 2002:a05:690c:d85:b0:6de:351:3e with SMTP id 00721157ae682-6e3477c0654mr20357467b3.8.1728656076179; Fri, 11 Oct 2024 07:14:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241011072509.3068328-2-davidgow@google.com> <20241011072509.3068328-5-davidgow@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 11 Oct 2024 16:14:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/6] lib: Move KUnit tests into tests/ subdirectory To: Andy Shevchenko Cc: David Gow , Andrew Morton , Shuah Khan , Brendan Higgins , Rae Moar , Kees Cook , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Stephen Rothwell , Yury Norov , Rasmus Villemoes , "Jason A . Donenfeld" , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" , Masami Hiramatsu , Mark Brown , linux-hardening@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Palmer Dabbelt , Christophe Leroy , Charlie Jenkins , Simon Horman , Jakub Kicinski , Arnd Bergmann , Daniel Latypov , Guenter Roeck , David Howells , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Marco Elver , Mark Rutland , "Gustavo A. R. Silva" , Vlastimil Babka , Nathan Chancellor , Fangrui Song , "Steven Rostedt (Google)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andy, On Fri, Oct 11, 2024 at 3:57=E2=80=AFPM Andy Shevchenko w= rote: > On Fri, Oct 11, 2024 at 03:38:00PM +0200, Geert Uytterhoeven wrote: > > On Fri, Oct 11, 2024 at 12:44=E2=80=AFPM Andy Shevchenko wrote: > > > On Fri, Oct 11, 2024 at 03:25:07PM +0800, David Gow wrote: > > > > From: Kees Cook > > > > > > > > Following from the recent KUnit file naming discussion[1], move all > > > > KUnit tests in lib/ into lib/tests/. > > > > > > > > Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@kerne= l.org/ [1] > > > > Signed-off-by: Kees Cook > > > > Acked-by: "Steven Rostedt (Google)" > > > > Acked-by: Jakub Kicinski > > > > Acked-by: "Masami Hiramatsu (Google)" > > > > Reviewed-by: David Gow > > > > [Rebased onto mm-nonmm-unstable, moved usercopy_kunit] > > > > Signed-off-by: David Gow > > > > > > > rename lib/{ =3D> tests}/bitfield_kunit.c (100%) > > > > rename lib/{ =3D> tests}/checksum_kunit.c (100%) > > > > rename lib/{ =3D> tests}/cmdline_kunit.c (100%) > > > > rename lib/{ =3D> tests}/cpumask_kunit.c (100%) > > > > rename lib/{ =3D> tests}/fortify_kunit.c (100%) > > > > rename lib/{ =3D> tests}/hashtable_test.c (100%) > > > > rename lib/{ =3D> tests}/is_signed_type_kunit.c (100%) > > > > rename lib/{ =3D> tests}/kunit_iov_iter.c (100%) > > > > rename lib/{ =3D> tests}/list-test.c (100%) > > > > rename lib/{ =3D> tests}/memcpy_kunit.c (100%) > > > > rename lib/{ =3D> tests}/overflow_kunit.c (100%) > > > > rename lib/{ =3D> tests}/siphash_kunit.c (100%) > > > > rename lib/{ =3D> tests}/slub_kunit.c (100%) > > > > rename lib/{ =3D> tests}/stackinit_kunit.c (100%) > > > > rename lib/{ =3D> tests}/string_helpers_kunit.c (100%) > > > > rename lib/{ =3D> tests}/string_kunit.c (100%) > > > > rename lib/{ =3D> tests}/test_bits.c (100%) > > > > rename lib/{ =3D> tests}/test_fprobe.c (100%) > > > > rename lib/{ =3D> tests}/test_hash.c (100%) > > > > rename lib/{ =3D> tests}/test_kprobes.c (100%) > > > > rename lib/{ =3D> tests}/test_linear_ranges.c (100%) > > > > rename lib/{ =3D> tests}/test_list_sort.c (100%) > > > > rename lib/{ =3D> tests}/test_sort.c (100%) > > > > rename lib/{ =3D> tests}/usercopy_kunit.c (100%) > > > > > > While I support the idea, I think this adds an additional churn in cr= eating a > > > duplicate 'test' in the filenames. Why they all can't be cut while re= moving? > > > (at least this question is not answered in the commit message) > > > > To avoid duplicate *.ko file names? > > With what? Sorry, but I don't see how it's a problem. These are test case= s. > Do they use kernel command line parameters? If so, shouldn't KUnit take c= are > about it in a more proper way? If .e.g. lib/list_sort.o could be modular, its module would be called "list_sort.ko", conflicting with the "list_sort.ko" test module. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds