From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271593715A; Wed, 8 Nov 2023 21:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8524D2580; Wed, 8 Nov 2023 13:10:19 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-5b499b18b28so2133447b3.0; Wed, 08 Nov 2023 13:10:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699477818; x=1700082618; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bav5/FGayyEQonBNC4kdS6ICDtnFE4p01QngumR4dg4=; b=ipwWhpKRdtmh+Uh6VvmrxWywQK9Q9c1fyFkHq6ayzI/hoFkgARWPYRg7X4Xr3FzFLR c4G6aiTPD+wkruVmz3pRfMeLBmbpqO1HbwzQp4tUQVnIizUPo3zNjom/4AuV0V7+Lg1Q 1q2cR3Bc7acbJnBJAdgxckR6G4u8qQqFdLJQUhvqW9CnjOyzfYL5qlagBwnqD3iSFzxX hLlVOnE+vbEnX/JObB4UNFIFfF1D3iTiEXAcT7nrWqwHy5qDkup5xZtILGCe101g17cK ZlFVoDUFUg/44K/H2HkkdNaJ+cf8Lf6IaDGVg6jg8le3yrun8Gaw6WQCOZvtSmRDk7oS KPQg== X-Gm-Message-State: AOJu0Ywm+iqe0tYvEdAkpz+r3ecFqCmZWws2QYyTyarGcn3EjMhys9Br ncbDEwLWhmrkVazpI4Yn0jrK87BUX3QC0w== X-Google-Smtp-Source: AGHT+IF0f+EnWpL39uPcb0Isgr8GcwJ2K7wJjaLgpat0Vo/euboSWtRuvVqOY1mQa+U4sJvOqCYELw== X-Received: by 2002:a0d:c042:0:b0:5a7:ba51:9c1b with SMTP id b63-20020a0dc042000000b005a7ba519c1bmr2761143ywd.37.1699477818216; Wed, 08 Nov 2023 13:10:18 -0800 (PST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id o14-20020a81de4e000000b005956b451fb8sm7201882ywl.100.2023.11.08.13.10.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 13:10:16 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-5b31c5143a0so1848457b3.3; Wed, 08 Nov 2023 13:10:16 -0800 (PST) X-Received: by 2002:a0d:f3c2:0:b0:59b:54b5:7d66 with SMTP id c185-20020a0df3c2000000b0059b54b57d66mr2960037ywf.34.1699477816210; Wed, 08 Nov 2023 13:10:16 -0800 (PST) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-11-arnd@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 8 Nov 2023 22:10:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype To: Arnd Bergmann Cc: Arnd Bergmann , Andrew Morton , linux-kernel@vger.kernel.org, Masahiro Yamada , linux-kbuild@vger.kernel.org, Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Netdev , linux-parisc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "linux-bcachefs@vger.kernel.org" , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Arnd, On Wed, Nov 8, 2023 at 10:07=E2=80=AFPM Arnd Bergmann wrote= : > On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01=E2=80=AFPM Arnd Bergmann = wrote: > >> From: Arnd Bergmann > >> > >> Microblaze runs into a single -Wmissing-prototypes warning when that i= s > >> enabled: > >> > >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype fo= r 'trap_init' [-Wmissing-prototypes] > >> > >> Include the right header to avoid this. > >> > >> Signed-off-by: Arnd Bergmann > > > > Thanks for your patch! > > > >> arch/alpha/kernel/traps.c | 1 + > >> arch/csky/include/asm/traps.h | 2 -- > >> arch/csky/kernel/traps.c | 1 + > >> arch/m68k/coldfire/vectors.c | 3 +-- > >> arch/m68k/coldfire/vectors.h | 3 --- > > > > Ah, so this is where the m68k changes listed in the cover letter are > > hiding ;-) > > > >> arch/microblaze/kernel/traps.c | 1 + > >> arch/sparc/kernel/traps_32.c | 1 + > >> arch/sparc/kernel/traps_64.c | 1 + > >> arch/x86/include/asm/traps.h | 1 - > >> arch/x86/kernel/traps.c | 1 + > >> 10 files changed, 7 insertions(+), 8 deletions(-) > >> delete mode 100644 arch/m68k/coldfire/vectors.h > > > > Obviously the non-microblaze changes should be spun off in separate > > patches. > > I messed up one of my rebases here and accidentally sent > the wrong changelog text. My intention was to have the > combined patch but with this text: > > arch: include linux/cpu.h for trap_init() prototype > > some architectures run into a -Wmissing-prototypes warning > for trap_init() > > arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype f= or 'trap_init' [-Wmissing-prototypes] > > Include the right header to avoid this consistently, removing > the extra declarations on m68k and x86 that were added as local > workarounds already. > > Signed-off-by: Arnd Bergmann That makes sense, although it's hard to combine this with "my preference would be for the patches to make it through the respective subsystem maintainer trees"... Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds