From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 742E8804; Fri, 11 Oct 2024 13:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728653900; cv=none; b=NatQOluGFoxvVPs7rHEvT4bLtht8YSu9CTMpN7VcEqJvApJSit1Oy/NIfvFNv+pwJLD+IdnRBeOqCHRb/pPNj8+5f0HqINeWQzv0U6UCWllr6KtTFYNMsWqGzbPgoNqHyhEV3arFAdb0+RsSHSUlBKAhI7mGuAEWY76zRcuEn8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728653900; c=relaxed/simple; bh=q+rW7hWH5Ignpu2pV6JUl1UdxQOkukoVb2hXg2WCsNs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Mgs4+ESN/WwRb61Hk2sMx8nQOJIGk71VIyiZp0T/LLeZ6VBGC+6B8YSZFpTvoYVJbp3H6bh166R0zyPDmRxl8MX0UljwmGKhBio/RVnTLmdJ5JMr2JwIH725g8uEli9swRNmQs7RGkcpTsVxSz3t92et2/aW0n4/Rn/8SDQIaHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.219.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e290bf7adaaso2066026276.1; Fri, 11 Oct 2024 06:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728653895; x=1729258695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6GQ33tgjUstB7i6Y5B0N4m09rhIX1en3xDn/TMfIc30=; b=p7iSc3AJxgj8rY1VdwIX5ue3pT9cpw6BicPPfitQeLgt5kLEMVrzWjSP0MPOeDfZAo sr+3lN1j0dJkQKockQSTfvumbRXtDYU4qNKuFpGX4leB5zYX2dhJqHxKxJua42UD5M3M j96LYMFKFur6zJV5Z02sKPdhB5rwNCMd8qurCU1TezMwfrlhrG8ig3k5Xz2PFV1BzQwv HxrG6WCkdlq5xrfMmtRRXRpzZkdcGvcVI1XXPyGYFnjHOr+UZQI8qYJ4XYAtFRq1uJpi RWQOPt5plhSE1VjwlpJHRq6+2cTaPOd8bfXi+Hm7lGQnpXnoJxpKXhTa3nppigJq4OqO Gu5Q== X-Forwarded-Encrypted: i=1; AJvYcCVdfLoQZ6Cm2bNbad7KLAPHBi4cTU1AsB5gD7qA3Y7KP8/bb328rAjYmKHHICL1ObPlH9oWBaugkv0asv7Ajsbb@vger.kernel.org, AJvYcCWmX6jggYF7A46ewug9XmSywUj6UXKDgiTKzApjMXlWjY7UpPXF7WO04WnZG3vKjtG5LNwus6SdLhkMiHjiPzuiwQht@vger.kernel.org, AJvYcCX3VvCht7kzkekbN0HpSSXZGDq+4oIzi3tNV51m0T6p31oN7U5Mzb/r+kYCHdIsOhsiBri1Nf7hmOqiCU5u@vger.kernel.org, AJvYcCXw7qG9HIBf7BJPeEmCkwTUvqet+IgLZRVegDT7kkt5tT6P8aS/3aiYk97LT0bv30Z3oBXv6giDrIE+hjVznRc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyp/irLhEehgSk1BBxZDXPYIiDixZO9qE9/9W4HRQx1WP/WZzbb L+DRLvjqf6JvzVNZAsuX1ZQFpkOhl46zoPaC/JwK0lqIQMdphdgzpYZLlcT94C4= X-Google-Smtp-Source: AGHT+IH3uTNQbX/0461XjwlRWu2FuceeLOeyk08qSrrU4Js1E3kyYCJ71To0Atr69ctjT63/uOHVnw== X-Received: by 2002:a05:6902:2b83:b0:e29:10ff:bb6 with SMTP id 3f1490d57ef6-e2919da0252mr1852609276.23.1728653894939; Fri, 11 Oct 2024 06:38:14 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e290ee00ef6sm812803276.14.2024.10.11.06.38.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 06:38:14 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-e28fd83b5bbso2077721276.0; Fri, 11 Oct 2024 06:38:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU2/L7Kgdt4coSS47KdII67y3Wmubsf8Qi92F882m/ljCxckk01knHthvVbqAH7jCutg2JwGt26ffykJqP3@vger.kernel.org, AJvYcCUfCDLtSn1tyhobTx6eOw9RuZ7uL4nWJyt7hN2S4QCN4yAw2/XHocLyrE8XQSrNFdEILyoby6gmX5YTI5gqtkQ=@vger.kernel.org, AJvYcCVSkcy1NgwTfM/H0NAwMkXwBeMaUHZueFvQGFDZPKx0Ac3feV7SZ/T6UIpl3jGqXLOMdeMNtgm7xOAwPiQMf+bf@vger.kernel.org, AJvYcCXn3A7LQPA2BZUceo1EQtrY2+rCWyVMv0/AMkKpWKLVxvGPV/t0nIM8oa+GWVWNbAM3mtflQy+sKse7o2ubqSLGcULV@vger.kernel.org X-Received: by 2002:a05:690c:6bc7:b0:6e2:50a:f436 with SMTP id 00721157ae682-6e347c4e77emr12305637b3.36.1728653893515; Fri, 11 Oct 2024 06:38:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241011072509.3068328-2-davidgow@google.com> <20241011072509.3068328-5-davidgow@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 11 Oct 2024 15:38:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/6] lib: Move KUnit tests into tests/ subdirectory To: Andy Shevchenko Cc: David Gow , Andrew Morton , Shuah Khan , Brendan Higgins , Rae Moar , Kees Cook , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Stephen Rothwell , Yury Norov , Rasmus Villemoes , "Jason A . Donenfeld" , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" , Masami Hiramatsu , Mark Brown , linux-hardening@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Palmer Dabbelt , Christophe Leroy , Charlie Jenkins , Simon Horman , Jakub Kicinski , Arnd Bergmann , Daniel Latypov , Guenter Roeck , David Howells , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Marco Elver , Mark Rutland , "Gustavo A. R. Silva" , Vlastimil Babka , Nathan Chancellor , Fangrui Song , "Steven Rostedt (Google)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andy, On Fri, Oct 11, 2024 at 12:44=E2=80=AFPM Andy Shevchenko = wrote: > On Fri, Oct 11, 2024 at 03:25:07PM +0800, David Gow wrote: > > From: Kees Cook > > > > Following from the recent KUnit file naming discussion[1], move all > > KUnit tests in lib/ into lib/tests/. > > > > Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@kernel.or= g/ [1] > > Signed-off-by: Kees Cook > > Acked-by: "Steven Rostedt (Google)" > > Acked-by: Jakub Kicinski > > Acked-by: "Masami Hiramatsu (Google)" > > Reviewed-by: David Gow > > [Rebased onto mm-nonmm-unstable, moved usercopy_kunit] > > Signed-off-by: David Gow > > > rename lib/{ =3D> tests}/bitfield_kunit.c (100%) > > rename lib/{ =3D> tests}/checksum_kunit.c (100%) > > rename lib/{ =3D> tests}/cmdline_kunit.c (100%) > > rename lib/{ =3D> tests}/cpumask_kunit.c (100%) > > rename lib/{ =3D> tests}/fortify_kunit.c (100%) > > rename lib/{ =3D> tests}/hashtable_test.c (100%) > > rename lib/{ =3D> tests}/is_signed_type_kunit.c (100%) > > rename lib/{ =3D> tests}/kunit_iov_iter.c (100%) > > rename lib/{ =3D> tests}/list-test.c (100%) > > rename lib/{ =3D> tests}/memcpy_kunit.c (100%) > > rename lib/{ =3D> tests}/overflow_kunit.c (100%) > > rename lib/{ =3D> tests}/siphash_kunit.c (100%) > > rename lib/{ =3D> tests}/slub_kunit.c (100%) > > rename lib/{ =3D> tests}/stackinit_kunit.c (100%) > > rename lib/{ =3D> tests}/string_helpers_kunit.c (100%) > > rename lib/{ =3D> tests}/string_kunit.c (100%) > > rename lib/{ =3D> tests}/test_bits.c (100%) > > rename lib/{ =3D> tests}/test_fprobe.c (100%) > > rename lib/{ =3D> tests}/test_hash.c (100%) > > rename lib/{ =3D> tests}/test_kprobes.c (100%) > > rename lib/{ =3D> tests}/test_linear_ranges.c (100%) > > rename lib/{ =3D> tests}/test_list_sort.c (100%) > > rename lib/{ =3D> tests}/test_sort.c (100%) > > rename lib/{ =3D> tests}/usercopy_kunit.c (100%) > > While I support the idea, I think this adds an additional churn in creati= ng a > duplicate 'test' in the filenames. Why they all can't be cut while removi= ng? > (at least this question is not answered in the commit message) To avoid duplicate *.ko file names? Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds