* [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes
2023-08-10 14:19 [PATCH 00/17] -Wmissing-prototype warning fixes Arnd Bergmann
@ 2023-08-10 14:19 ` Arnd Bergmann
2023-08-11 11:46 ` Masami Hiramatsu
2023-08-16 14:38 ` [PATCH 00/17] -Wmissing-prototype warning fixes Palmer Dabbelt
2023-08-25 1:12 ` (subset) " Martin K. Petersen
2 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2023-08-10 14:19 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Naveen N. Rao, Anil S Keshavamurthy,
Masami Hiramatsu
Cc: Arnd Bergmann, Vineet Gupta, Russell King, Catalin Marinas,
Will Deacon, Thomas Bogendoerfer, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, H. Peter Anvin, Gaosheng Cui,
Steven Rostedt (Google), Yang Jihong, Jiri Olsa,
Alexei Starovoitov, linux-snps-arc, linux-arm-kernel, linux-ia64,
linux-mips, linuxppc-dev, linux-s390, linux-sh, sparclinux,
linux-trace-kernel
From: Arnd Bergmann <arnd@arndb.de>
Most architectures that support kprobes declare this function in their
own asm/kprobes.h header and provide an override, but some are missing
the prototype, which causes a warning for the __weak stub implementation:
kernel/kprobes.c:1865:12: error: no previous prototype for 'kprobe_exceptions_notify' [-Werror=missing-prototypes]
1865 | int __weak kprobe_exceptions_notify(struct notifier_block *self,
Move the prototype into linux/kprobes.h so it is visible to all
the definitions.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arc/include/asm/kprobes.h | 3 ---
arch/arm/include/asm/kprobes.h | 2 --
arch/arm64/include/asm/kprobes.h | 2 --
arch/ia64/include/asm/kprobes.h | 2 --
arch/mips/include/asm/kprobes.h | 2 --
arch/powerpc/include/asm/kprobes.h | 2 --
arch/s390/include/asm/kprobes.h | 2 --
arch/sh/include/asm/kprobes.h | 2 --
arch/sparc/include/asm/kprobes.h | 2 --
arch/x86/include/asm/kprobes.h | 2 --
include/linux/kprobes.h | 4 ++++
11 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/arch/arc/include/asm/kprobes.h b/arch/arc/include/asm/kprobes.h
index de1566e32cb89..68e8301c0df2c 100644
--- a/arch/arc/include/asm/kprobes.h
+++ b/arch/arc/include/asm/kprobes.h
@@ -32,9 +32,6 @@ struct kprobe;
void arch_remove_kprobe(struct kprobe *p);
-int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
-
struct prev_kprobe {
struct kprobe *kp;
unsigned long status;
diff --git a/arch/arm/include/asm/kprobes.h b/arch/arm/include/asm/kprobes.h
index e26a278d301ab..5b8dbf1b0be49 100644
--- a/arch/arm/include/asm/kprobes.h
+++ b/arch/arm/include/asm/kprobes.h
@@ -40,8 +40,6 @@ struct kprobe_ctlblk {
void arch_remove_kprobe(struct kprobe *);
int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr);
-int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
/* optinsn template addresses */
extern __visible kprobe_opcode_t optprobe_template_entry[];
diff --git a/arch/arm64/include/asm/kprobes.h b/arch/arm64/include/asm/kprobes.h
index 05cd82eeca136..be7a3680dadff 100644
--- a/arch/arm64/include/asm/kprobes.h
+++ b/arch/arm64/include/asm/kprobes.h
@@ -37,8 +37,6 @@ struct kprobe_ctlblk {
void arch_remove_kprobe(struct kprobe *);
int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr);
-int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
void __kretprobe_trampoline(void);
void __kprobes *trampoline_probe_handler(struct pt_regs *regs);
diff --git a/arch/ia64/include/asm/kprobes.h b/arch/ia64/include/asm/kprobes.h
index 9e956768946cc..56004f97df6d2 100644
--- a/arch/ia64/include/asm/kprobes.h
+++ b/arch/ia64/include/asm/kprobes.h
@@ -107,8 +107,6 @@ struct arch_specific_insn {
};
extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
-extern int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
extern void arch_remove_kprobe(struct kprobe *p);
diff --git a/arch/mips/include/asm/kprobes.h b/arch/mips/include/asm/kprobes.h
index 68b1e5d458cfb..bc27d99c94363 100644
--- a/arch/mips/include/asm/kprobes.h
+++ b/arch/mips/include/asm/kprobes.h
@@ -71,8 +71,6 @@ struct kprobe_ctlblk {
struct prev_kprobe prev_kprobe;
};
-extern int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
#endif /* CONFIG_KPROBES */
#endif /* _ASM_KPROBES_H */
diff --git a/arch/powerpc/include/asm/kprobes.h b/arch/powerpc/include/asm/kprobes.h
index c8e4b4fd4e330..4525a9c68260d 100644
--- a/arch/powerpc/include/asm/kprobes.h
+++ b/arch/powerpc/include/asm/kprobes.h
@@ -84,8 +84,6 @@ struct arch_optimized_insn {
kprobe_opcode_t *insn;
};
-extern int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
extern int kprobe_handler(struct pt_regs *regs);
extern int kprobe_post_handler(struct pt_regs *regs);
diff --git a/arch/s390/include/asm/kprobes.h b/arch/s390/include/asm/kprobes.h
index 83f732ca3af4d..3f87125dd9b0d 100644
--- a/arch/s390/include/asm/kprobes.h
+++ b/arch/s390/include/asm/kprobes.h
@@ -72,8 +72,6 @@ struct kprobe_ctlblk {
void arch_remove_kprobe(struct kprobe *p);
int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
-int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
#define flush_insn_slot(p) do { } while (0)
diff --git a/arch/sh/include/asm/kprobes.h b/arch/sh/include/asm/kprobes.h
index eeba83e0a7d29..65d4c3316a5bd 100644
--- a/arch/sh/include/asm/kprobes.h
+++ b/arch/sh/include/asm/kprobes.h
@@ -46,8 +46,6 @@ struct kprobe_ctlblk {
};
extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
-extern int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
extern int kprobe_handle_illslot(unsigned long pc);
#else
diff --git a/arch/sparc/include/asm/kprobes.h b/arch/sparc/include/asm/kprobes.h
index 06c2bc767ef75..aec742cd898f2 100644
--- a/arch/sparc/include/asm/kprobes.h
+++ b/arch/sparc/include/asm/kprobes.h
@@ -47,8 +47,6 @@ struct kprobe_ctlblk {
struct prev_kprobe prev_kprobe;
};
-int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
asmlinkage void __kprobes kprobe_trap(unsigned long trap_level,
struct pt_regs *regs);
diff --git a/arch/x86/include/asm/kprobes.h b/arch/x86/include/asm/kprobes.h
index a2e9317aad495..5939694dfb28d 100644
--- a/arch/x86/include/asm/kprobes.h
+++ b/arch/x86/include/asm/kprobes.h
@@ -113,8 +113,6 @@ struct kprobe_ctlblk {
};
extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
-extern int kprobe_exceptions_notify(struct notifier_block *self,
- unsigned long val, void *data);
extern int kprobe_int3_handler(struct pt_regs *regs);
#else
diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index 85a64cb95d755..987911cdc90a2 100644
--- a/include/linux/kprobes.h
+++ b/include/linux/kprobes.h
@@ -450,6 +450,10 @@ int kprobe_get_kallsym(unsigned int symnum, unsigned long *value, char *type,
int arch_kprobe_get_kallsym(unsigned int *symnum, unsigned long *value,
char *type, char *sym);
+
+int kprobe_exceptions_notify(struct notifier_block *self,
+ unsigned long val, void *data);
+
#else /* !CONFIG_KPROBES: */
static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes
2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann
@ 2023-08-11 11:46 ` Masami Hiramatsu
0 siblings, 0 replies; 10+ messages in thread
From: Masami Hiramatsu @ 2023-08-11 11:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Morton, linux-kernel, Naveen N. Rao, Anil S Keshavamurthy,
Arnd Bergmann, Vineet Gupta, Russell King, Catalin Marinas,
Will Deacon, Thomas Bogendoerfer, Michael Ellerman,
Nicholas Piggin, Christophe Leroy, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, H. Peter Anvin, Gaosheng Cui,
Steven Rostedt (Google), Yang Jihong, Jiri Olsa,
Alexei Starovoitov, linux-snps-arc, linux-arm-kernel, linux-ia64,
linux-mips, linuxppc-dev, linux-s390, linux-sh, sparclinux,
linux-trace-kernel
On Thu, 10 Aug 2023 16:19:32 +0200
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most architectures that support kprobes declare this function in their
> own asm/kprobes.h header and provide an override, but some are missing
> the prototype, which causes a warning for the __weak stub implementation:
>
> kernel/kprobes.c:1865:12: error: no previous prototype for 'kprobe_exceptions_notify' [-Werror=missing-prototypes]
> 1865 | int __weak kprobe_exceptions_notify(struct notifier_block *self,
>
> Move the prototype into linux/kprobes.h so it is visible to all
> the definitions.
Good catch! and it seems x86 has no implementation, so this is more resonable.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you,
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arc/include/asm/kprobes.h | 3 ---
> arch/arm/include/asm/kprobes.h | 2 --
> arch/arm64/include/asm/kprobes.h | 2 --
> arch/ia64/include/asm/kprobes.h | 2 --
> arch/mips/include/asm/kprobes.h | 2 --
> arch/powerpc/include/asm/kprobes.h | 2 --
> arch/s390/include/asm/kprobes.h | 2 --
> arch/sh/include/asm/kprobes.h | 2 --
> arch/sparc/include/asm/kprobes.h | 2 --
> arch/x86/include/asm/kprobes.h | 2 --
> include/linux/kprobes.h | 4 ++++
> 11 files changed, 4 insertions(+), 21 deletions(-)
>
> diff --git a/arch/arc/include/asm/kprobes.h b/arch/arc/include/asm/kprobes.h
> index de1566e32cb89..68e8301c0df2c 100644
> --- a/arch/arc/include/asm/kprobes.h
> +++ b/arch/arc/include/asm/kprobes.h
> @@ -32,9 +32,6 @@ struct kprobe;
>
> void arch_remove_kprobe(struct kprobe *p);
>
> -int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> -
> struct prev_kprobe {
> struct kprobe *kp;
> unsigned long status;
> diff --git a/arch/arm/include/asm/kprobes.h b/arch/arm/include/asm/kprobes.h
> index e26a278d301ab..5b8dbf1b0be49 100644
> --- a/arch/arm/include/asm/kprobes.h
> +++ b/arch/arm/include/asm/kprobes.h
> @@ -40,8 +40,6 @@ struct kprobe_ctlblk {
>
> void arch_remove_kprobe(struct kprobe *);
> int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr);
> -int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
>
> /* optinsn template addresses */
> extern __visible kprobe_opcode_t optprobe_template_entry[];
> diff --git a/arch/arm64/include/asm/kprobes.h b/arch/arm64/include/asm/kprobes.h
> index 05cd82eeca136..be7a3680dadff 100644
> --- a/arch/arm64/include/asm/kprobes.h
> +++ b/arch/arm64/include/asm/kprobes.h
> @@ -37,8 +37,6 @@ struct kprobe_ctlblk {
>
> void arch_remove_kprobe(struct kprobe *);
> int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr);
> -int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> void __kretprobe_trampoline(void);
> void __kprobes *trampoline_probe_handler(struct pt_regs *regs);
>
> diff --git a/arch/ia64/include/asm/kprobes.h b/arch/ia64/include/asm/kprobes.h
> index 9e956768946cc..56004f97df6d2 100644
> --- a/arch/ia64/include/asm/kprobes.h
> +++ b/arch/ia64/include/asm/kprobes.h
> @@ -107,8 +107,6 @@ struct arch_specific_insn {
> };
>
> extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> -extern int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
>
> extern void arch_remove_kprobe(struct kprobe *p);
>
> diff --git a/arch/mips/include/asm/kprobes.h b/arch/mips/include/asm/kprobes.h
> index 68b1e5d458cfb..bc27d99c94363 100644
> --- a/arch/mips/include/asm/kprobes.h
> +++ b/arch/mips/include/asm/kprobes.h
> @@ -71,8 +71,6 @@ struct kprobe_ctlblk {
> struct prev_kprobe prev_kprobe;
> };
>
> -extern int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
>
> #endif /* CONFIG_KPROBES */
> #endif /* _ASM_KPROBES_H */
> diff --git a/arch/powerpc/include/asm/kprobes.h b/arch/powerpc/include/asm/kprobes.h
> index c8e4b4fd4e330..4525a9c68260d 100644
> --- a/arch/powerpc/include/asm/kprobes.h
> +++ b/arch/powerpc/include/asm/kprobes.h
> @@ -84,8 +84,6 @@ struct arch_optimized_insn {
> kprobe_opcode_t *insn;
> };
>
> -extern int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> extern int kprobe_handler(struct pt_regs *regs);
> extern int kprobe_post_handler(struct pt_regs *regs);
> diff --git a/arch/s390/include/asm/kprobes.h b/arch/s390/include/asm/kprobes.h
> index 83f732ca3af4d..3f87125dd9b0d 100644
> --- a/arch/s390/include/asm/kprobes.h
> +++ b/arch/s390/include/asm/kprobes.h
> @@ -72,8 +72,6 @@ struct kprobe_ctlblk {
> void arch_remove_kprobe(struct kprobe *p);
>
> int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> -int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
>
> #define flush_insn_slot(p) do { } while (0)
>
> diff --git a/arch/sh/include/asm/kprobes.h b/arch/sh/include/asm/kprobes.h
> index eeba83e0a7d29..65d4c3316a5bd 100644
> --- a/arch/sh/include/asm/kprobes.h
> +++ b/arch/sh/include/asm/kprobes.h
> @@ -46,8 +46,6 @@ struct kprobe_ctlblk {
> };
>
> extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> -extern int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> extern int kprobe_handle_illslot(unsigned long pc);
> #else
>
> diff --git a/arch/sparc/include/asm/kprobes.h b/arch/sparc/include/asm/kprobes.h
> index 06c2bc767ef75..aec742cd898f2 100644
> --- a/arch/sparc/include/asm/kprobes.h
> +++ b/arch/sparc/include/asm/kprobes.h
> @@ -47,8 +47,6 @@ struct kprobe_ctlblk {
> struct prev_kprobe prev_kprobe;
> };
>
> -int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> asmlinkage void __kprobes kprobe_trap(unsigned long trap_level,
> struct pt_regs *regs);
> diff --git a/arch/x86/include/asm/kprobes.h b/arch/x86/include/asm/kprobes.h
> index a2e9317aad495..5939694dfb28d 100644
> --- a/arch/x86/include/asm/kprobes.h
> +++ b/arch/x86/include/asm/kprobes.h
> @@ -113,8 +113,6 @@ struct kprobe_ctlblk {
> };
>
> extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr);
> -extern int kprobe_exceptions_notify(struct notifier_block *self,
> - unsigned long val, void *data);
> extern int kprobe_int3_handler(struct pt_regs *regs);
>
> #else
> diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
> index 85a64cb95d755..987911cdc90a2 100644
> --- a/include/linux/kprobes.h
> +++ b/include/linux/kprobes.h
> @@ -450,6 +450,10 @@ int kprobe_get_kallsym(unsigned int symnum, unsigned long *value, char *type,
>
> int arch_kprobe_get_kallsym(unsigned int *symnum, unsigned long *value,
> char *type, char *sym);
> +
> +int kprobe_exceptions_notify(struct notifier_block *self,
> + unsigned long val, void *data);
> +
> #else /* !CONFIG_KPROBES: */
>
> static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
> --
> 2.39.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-10 14:19 [PATCH 00/17] -Wmissing-prototype warning fixes Arnd Bergmann
2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann
@ 2023-08-16 14:38 ` Palmer Dabbelt
2023-08-25 1:12 ` (subset) " Martin K. Petersen
2 siblings, 0 replies; 10+ messages in thread
From: Palmer Dabbelt @ 2023-08-16 14:38 UTC (permalink / raw)
To: arnd
Cc: akpm, linux-kernel, Arnd Bergmann, mattst88, vgupta, linux,
Catalin Marinas, Will Deacon, guoren, bcain, chenhuacai, kernel,
geert, monstr, tsbogend, dinguyen, jonas, stefan.kristiansson,
shorne, James.Bottomley, deller, mpe, christophe.leroy, hca,
glaubitz, x86, bp, jcmvbkbc, axboe, sudipm.mukherjee,
martin.petersen, richard, bhelgaas, masahiroy, nathan,
ndesaulniers, linux, Stephen Rothwell, linux-next, linux-alpha,
linux-snps-arc, linux-arm-kernel, linux-csky, linux-hexagon,
linux-ia64, loongarch, linux-m68k, linux-mips, linux-openrisc,
linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh,
sparclinux, linux-block, linux-scsi, linux-mtd,
linux-trace-kernel, linux-pci, linux-kbuild
On Thu, 10 Aug 2023 07:19:18 PDT (-0700), arnd@kernel.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most of the patches I sent so far for the -Wmissing-prototype warnings
> have made it into linux-next now. There are a few that I'm resending
> now as nobody has picked them up, and then a number of fixes that I
> found while test-building across all architectures rather than just the
> ones I usually test.
>
> The first 15 patches in this series should be uncontroversial, so
> I expect that either a subsystem maintainer or Andrew Morton can
> apply these directly.
>
> For the last two patches, these might still need some debate about how
> to handle them. I added a Kconfig option to turn off most of the missing
> prototype warnings in the architectures that nobody has fixed yet,
> see patch 16 for those. The last patch does cause some known warnings
> and likely unknown ones for architectures other than x86 and arm,
> so applying it now will bring new problems, but not applying it also
> means that new warnings creep in, so I think this is mainly a question
> of what the best timing is for having this in linux-next.
>
> Arnd Bergmann (17):
> [RESEND] jffs2: mark __jffs2_dbg_superblock_counts() static
> [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
> [RESEND] ida: make 'ida_dump' static
> pci: sysfs: move declarations to linux/pci.h
> swim3: mark swim3_init() static
> macintosh/ams: mark ams_init() static
> scsi: qlogicpti: mark qlogicpti_info() static
> microblaze: mark flush_dcache_folio() inline
> parport: gsc: mark init function static
> zorro: include zorro.h in names.c
> scsi: gvp11: remove unused gvp11_setup() function
> time: make sysfs_get_uname() function visible in header
> stackleak: add declarations for global functions
> kprobes: unify kprobes_exceptions_nofify() prototypes
> arch: fix asm-offsets.c building with -Wmissing-prototypes
> [RFC] arch: turn -Wmissing-prototypes off conditionally
> [RFC] Makefile.extrawarn: turn on missing-prototypes again
>
> arch/alpha/Kbuild | 2 ++
> arch/alpha/include/asm/pci.h | 3 ---
> arch/alpha/kernel/asm-offsets.c | 2 +-
> arch/alpha/lib/Makefile | 1 +
> arch/arc/Kbuild | 2 ++
> arch/arc/include/asm/kprobes.h | 3 ---
> arch/arm/include/asm/irq_work.h | 2 --
> arch/arm/include/asm/kprobes.h | 2 --
> arch/arm64/include/asm/irq_work.h | 2 --
> arch/arm64/include/asm/kprobes.h | 2 --
> arch/csky/Kbuild | 2 ++
> arch/csky/include/asm/irq_work.h | 2 +-
> arch/hexagon/Kbuild | 2 ++
> arch/ia64/Kbuild | 2 ++
> arch/ia64/include/asm/kprobes.h | 2 --
> arch/ia64/kernel/asm-offsets.c | 2 +-
> arch/ia64/lib/Makefile | 1 +
> arch/loongarch/Kbuild | 2 ++
> arch/loongarch/kernel/asm-offsets.c | 12 ++++++++++++
> arch/m68k/Kbuild | 2 ++
> arch/m68k/lib/Makefile | 1 +
> arch/microblaze/Kbuild | 2 ++
> arch/microblaze/include/asm/cacheflush.h | 2 +-
> arch/mips/Kbuild | 2 ++
> arch/mips/boot/compressed/Makefile | 3 ++-
> arch/mips/include/asm/kprobes.h | 2 --
> arch/nios2/Kbuild | 2 ++
> arch/nios2/lib/Makefile | 1 +
> arch/openrisc/Kbuild | 2 ++
> arch/parisc/Kbuild | 2 ++
> arch/parisc/lib/Makefile | 1 +
> arch/powerpc/include/asm/irq_work.h | 1 -
> arch/powerpc/include/asm/kprobes.h | 2 --
> arch/riscv/include/asm/irq_work.h | 2 +-
> arch/s390/include/asm/irq_work.h | 2 --
> arch/s390/include/asm/kprobes.h | 2 --
> arch/sh/Kbuild | 2 ++
> arch/sh/boot/compressed/Makefile | 1 +
> arch/sh/include/asm/kprobes.h | 2 --
> arch/sparc/Kbuild | 2 ++
> arch/sparc/include/asm/kprobes.h | 2 --
> arch/sparc/kernel/asm-offsets.c | 13 ++-----------
> arch/sparc/lib/Makefile | 1 +
> arch/sparc/prom/Makefile | 1 +
> arch/x86/include/asm/irq_work.h | 1 -
> arch/x86/include/asm/kprobes.h | 2 --
> arch/xtensa/Kbuild | 2 ++
> arch/xtensa/boot/lib/Makefile | 2 ++
> drivers/block/swim3.c | 2 +-
> drivers/macintosh/ams/ams-core.c | 2 +-
> drivers/parport/parport_gsc.c | 2 +-
> drivers/scsi/gvp11.c | 5 -----
> drivers/scsi/qlogicpti.c | 2 +-
> drivers/zorro/names.c | 1 +
> fs/jffs2/debug.c | 2 +-
> include/linux/irq_work.h | 3 +++
> include/linux/kprobes.h | 4 ++++
> include/linux/pci.h | 5 +++++
> include/linux/stackleak.h | 6 ++++++
> init/Kconfig | 10 ++++++++++
> kernel/time/tick-internal.h | 3 ++-
> lib/test_ida.c | 2 +-
> scripts/Makefile.extrawarn | 5 +++--
> 63 files changed, 101 insertions(+), 63 deletions(-)
Acked-by: Palmer Dabbelt <palmer@rivosinc.com> # RISC-V
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-10 14:19 [PATCH 00/17] -Wmissing-prototype warning fixes Arnd Bergmann
2023-08-10 14:19 ` [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes Arnd Bergmann
2023-08-16 14:38 ` [PATCH 00/17] -Wmissing-prototype warning fixes Palmer Dabbelt
@ 2023-08-25 1:12 ` Martin K. Petersen
2023-08-25 1:30 ` Michael Schmitz
2 siblings, 1 reply; 10+ messages in thread
From: Martin K. Petersen @ 2023-08-25 1:12 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Arnd Bergmann
Cc: Martin K . Petersen, Arnd Bergmann, Matt Turner, Vineet Gupta,
Russell King, Catalin Marinas, Will Deacon, Guo Ren, Brian Cain,
Huacai Chen, WANG Xuerui, Geert Uytterhoeven, Michal Simek,
Thomas Bogendoerfer, Dinh Nguyen, Jonas Bonn, Stefan Kristiansson,
Stafford Horne, James E.J. Bottomley, Helge Deller,
Michael Ellerman, Christophe Leroy, Palmer Dabbelt,
Heiko Carstens, John Paul Adrian Glaubitz, x86, Borislav Petkov,
Max Filippov, Jens Axboe, Sudip Mukherjee, Richard Weinberger,
Bjorn Helgaas, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, Guenter Roeck, Stephen Rothwell, linux-next,
linux-alpha, linux-snps-arc, linux-arm-kernel, linux-csky,
linux-hexagon, linux-ia64, loongarch, linux-m68k, linux-mips,
linux-openrisc, linux-parisc, linuxppc-dev, linux-riscv,
linux-s390, linux-sh, sparclinux, linux-block, linux-scsi,
linux-mtd, linux-trace-kernel, linux-pci, linux-kbuild
On Thu, 10 Aug 2023 16:19:18 +0200, Arnd Bergmann wrote:
> Most of the patches I sent so far for the -Wmissing-prototype warnings
> have made it into linux-next now. There are a few that I'm resending
> now as nobody has picked them up, and then a number of fixes that I
> found while test-building across all architectures rather than just the
> ones I usually test.
>
> The first 15 patches in this series should be uncontroversial, so
> I expect that either a subsystem maintainer or Andrew Morton can
> apply these directly.
>
> [...]
Applied to 6.6/scsi-queue, thanks!
[07/17] scsi: qlogicpti: mark qlogicpti_info() static
https://git.kernel.org/mkp/scsi/c/71cc486335c4
[11/17] scsi: gvp11: remove unused gvp11_setup() function
https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-25 1:12 ` (subset) " Martin K. Petersen
@ 2023-08-25 1:30 ` Michael Schmitz
2023-08-25 7:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 10+ messages in thread
From: Michael Schmitz @ 2023-08-25 1:30 UTC (permalink / raw)
To: Martin K. Petersen, Andrew Morton, linux-kernel, Arnd Bergmann
Cc: Arnd Bergmann, Matt Turner, Vineet Gupta, Russell King,
Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen,
WANG Xuerui, Geert Uytterhoeven, Michal Simek,
Thomas Bogendoerfer, Dinh Nguyen, Jonas Bonn, Stefan Kristiansson,
Stafford Horne, James E.J. Bottomley, Helge Deller,
Michael Ellerman, Christophe Leroy, Palmer Dabbelt,
Heiko Carstens, John Paul Adrian Glaubitz, x86, Borislav Petkov,
Max Filippov, Jens Axboe, Sudip Mukherjee, Richard Weinberger,
Bjorn Helgaas, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, Guenter Roeck, Stephen Rothwell, linux-next,
linux-alpha, linux-snps-arc, linux-arm-kernel, linux-csky,
linux-hexagon, linux-ia64, loongarch, linux-m68k, linux-mips,
linux-openrisc, linux-parisc, linuxppc-dev, linux-riscv,
linux-s390, linux-sh, sparclinux, linux-block, linux-scsi,
linux-mtd, linux-trace-kernel, linux-pci, linux-kbuild
Hi Martin, Arnd,
On 25/08/23 13:12, Martin K. Petersen wrote:
> On Thu, 10 Aug 2023 16:19:18 +0200, Arnd Bergmann wrote:
>
>> Most of the patches I sent so far for the -Wmissing-prototype warnings
>> have made it into linux-next now. There are a few that I'm resending
>> now as nobody has picked them up, and then a number of fixes that I
>> found while test-building across all architectures rather than just the
>> ones I usually test.
>>
>> The first 15 patches in this series should be uncontroversial, so
>> I expect that either a subsystem maintainer or Andrew Morton can
>> apply these directly.
>>
>> [...]
> Applied to 6.6/scsi-queue, thanks!
>
> [07/17] scsi: qlogicpti: mark qlogicpti_info() static
> https://git.kernel.org/mkp/scsi/c/71cc486335c4
> [11/17] scsi: gvp11: remove unused gvp11_setup() function
> https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb
I somehow missed that one ...
The gvp11_setup() function was probably a relic from the times before
module parameters.
Since gvp11_xfer_mask appears to be required for some Amiga systems to
set the DMA mask, I'd best send a patch to add such a module parameter ...
Do you know any details around the use of DMA masks for Amiga WD33C93
drivers, Geert?
Cheers,
Michael
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-25 1:30 ` Michael Schmitz
@ 2023-08-25 7:39 ` Geert Uytterhoeven
2023-08-25 22:44 ` Michael Schmitz
0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2023-08-25 7:39 UTC (permalink / raw)
To: Michael Schmitz
Cc: Martin K. Petersen, Andrew Morton, linux-kernel, Arnd Bergmann,
Arnd Bergmann, Matt Turner, Vineet Gupta, Russell King,
Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen,
WANG Xuerui, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen,
Jonas Bonn, Stefan Kristiansson, Stafford Horne,
James E.J. Bottomley, Helge Deller, Michael Ellerman,
Christophe Leroy, Palmer Dabbelt, Heiko Carstens,
John Paul Adrian Glaubitz, x86, Borislav Petkov, Max Filippov,
Jens Axboe, Sudip Mukherjee, Richard Weinberger, Bjorn Helgaas,
Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Guenter Roeck, Stephen Rothwell, linux-next, linux-alpha,
linux-snps-arc, linux-arm-kernel, linux-csky, linux-hexagon,
linux-ia64, loongarch, linux-m68k, linux-mips, linux-openrisc,
linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh,
sparclinux, linux-block, linux-scsi, linux-mtd,
linux-trace-kernel, linux-pci, linux-kbuild
Hi Michael,
On Fri, Aug 25, 2023 at 3:31 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> On 25/08/23 13:12, Martin K. Petersen wrote:
> > [11/17] scsi: gvp11: remove unused gvp11_setup() function
> > https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb
>
> I somehow missed that one ...
>
> The gvp11_setup() function was probably a relic from the times before
> module parameters.
>
> Since gvp11_xfer_mask appears to be required for some Amiga systems to
> set the DMA mask, I'd best send a patch to add such a module parameter ...
>
> Do you know any details around the use of DMA masks for Amiga WD33C93
> drivers, Geert?
Doh, it's been a while, and I never had an affected system.
Probably it's needed on A2000 with an accelerator card and GVP II SCSI,
to prevent DMA to RAM banks that do not support fast DMA cycles.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-25 7:39 ` Geert Uytterhoeven
@ 2023-08-25 22:44 ` Michael Schmitz
2023-08-28 6:42 ` Geert Uytterhoeven
0 siblings, 1 reply; 10+ messages in thread
From: Michael Schmitz @ 2023-08-25 22:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Martin K. Petersen, Andrew Morton, linux-kernel, Arnd Bergmann,
Arnd Bergmann, Matt Turner, Vineet Gupta, Russell King,
Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen,
WANG Xuerui, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen,
Jonas Bonn, Stefan Kristiansson, Stafford Horne,
James E.J. Bottomley, Helge Deller, Michael Ellerman,
Christophe Leroy, Palmer Dabbelt, Heiko Carstens,
John Paul Adrian Glaubitz, x86, Borislav Petkov, Max Filippov,
Jens Axboe, Sudip Mukherjee, Richard Weinberger, Bjorn Helgaas,
Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Guenter Roeck, Stephen Rothwell, linux-next, linux-alpha,
linux-snps-arc, linux-arm-kernel, linux-csky, linux-hexagon,
linux-ia64, loongarch, linux-m68k, linux-mips, linux-openrisc,
linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh,
sparclinux, linux-block, linux-scsi, linux-mtd,
linux-trace-kernel, linux-pci, linux-kbuild
Hi Geert,
Am 25.08.23 um 19:39 schrieb Geert Uytterhoeven:
> Hi Michael,
>
> On Fri, Aug 25, 2023 at 3:31 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> On 25/08/23 13:12, Martin K. Petersen wrote:
>>> [11/17] scsi: gvp11: remove unused gvp11_setup() function
>>> https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb
>> I somehow missed that one ...
>>
>> The gvp11_setup() function was probably a relic from the times before
>> module parameters.
>>
>> Since gvp11_xfer_mask appears to be required for some Amiga systems to
>> set the DMA mask, I'd best send a patch to add such a module parameter ...
>>
>> Do you know any details around the use of DMA masks for Amiga WD33C93
>> drivers, Geert?
> Doh, it's been a while, and I never had an affected system.
> Probably it's needed on A2000 with an accelerator card and GVP II SCSI,
> to prevent DMA to RAM banks that do not support fast DMA cycles.
Thanks, that's good enough for me.
Linux 2.0 had this comment:
|/* * DMA transfer mask for GVP Series II SCSI controller. * Some
versions can only DMA into the 24 bit address space * (0->16M). Others
can DMA into the full 32 bit address * space. The default is to only
allow DMA into the 24 bit * address space. The "gvp11=0xFFFFFFFE" setup
parameter can * be supplied to force an alternate (32 bit) mask. */ |
|We now handle that (since 2.6.35) through masks defined in
gvp11_zorro_tbl[] (though I note these don't account for unaligned
addresses such as implied by the example in the comment. Are unaligned
DMA buffers still possible today?). Would that cover the 'A2000 with
accelerator' case?
|
||
I'm happy to send a patch if an override to the device default DMA mask
is still necessary.
(Incidentally - did you ever publish the m68k full history tree anywhere
in git?)
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-25 22:44 ` Michael Schmitz
@ 2023-08-28 6:42 ` Geert Uytterhoeven
2023-08-28 8:07 ` Michael Schmitz
0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2023-08-28 6:42 UTC (permalink / raw)
To: Michael Schmitz
Cc: Martin K. Petersen, Andrew Morton, linux-kernel, Arnd Bergmann,
Arnd Bergmann, Matt Turner, Vineet Gupta, Russell King,
Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen,
WANG Xuerui, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen,
Jonas Bonn, Stefan Kristiansson, Stafford Horne,
James E.J. Bottomley, Helge Deller, Michael Ellerman,
Christophe Leroy, Palmer Dabbelt, Heiko Carstens,
John Paul Adrian Glaubitz, x86, Borislav Petkov, Max Filippov,
Jens Axboe, Sudip Mukherjee, Richard Weinberger, Bjorn Helgaas,
Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Guenter Roeck, Stephen Rothwell, linux-next, linux-alpha,
linux-snps-arc, linux-arm-kernel, linux-csky, linux-hexagon,
linux-ia64, loongarch, linux-m68k, linux-mips, linux-openrisc,
linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh,
sparclinux, linux-block, linux-scsi, linux-mtd,
linux-trace-kernel, linux-pci, linux-kbuild
On Sat, Aug 26, 2023 at 12:44 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> (Incidentally - did you ever publish the m68k full history tree anywhere
> in git?)
You mean the gitified version of the Linux/m68k CVS tree Ralf created
for me because my machine wasn't powerful enough?
No, and I should look into doing that...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes
2023-08-28 6:42 ` Geert Uytterhoeven
@ 2023-08-28 8:07 ` Michael Schmitz
0 siblings, 0 replies; 10+ messages in thread
From: Michael Schmitz @ 2023-08-28 8:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Martin K. Petersen, Andrew Morton, linux-kernel, Arnd Bergmann,
Arnd Bergmann, Matt Turner, Vineet Gupta, Russell King,
Catalin Marinas, Will Deacon, Guo Ren, Brian Cain, Huacai Chen,
WANG Xuerui, Michal Simek, Thomas Bogendoerfer, Dinh Nguyen,
Jonas Bonn, Stefan Kristiansson, Stafford Horne,
James E.J. Bottomley, Helge Deller, Michael Ellerman,
Christophe Leroy, Palmer Dabbelt, Heiko Carstens,
John Paul Adrian Glaubitz, x86, Borislav Petkov, Max Filippov,
Jens Axboe, Sudip Mukherjee, Richard Weinberger, Bjorn Helgaas,
Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Guenter Roeck, Stephen Rothwell, linux-next, linux-alpha,
linux-snps-arc, linux-arm-kernel, linux-csky, linux-hexagon,
linux-ia64, loongarch, linux-m68k, linux-mips, linux-openrisc,
linux-parisc, linuxppc-dev, linux-riscv, linux-s390, linux-sh,
sparclinux, linux-block, linux-scsi, linux-mtd,
linux-trace-kernel, linux-pci, linux-kbuild
Hi Geert,
Am 28.08.2023 um 18:42 schrieb Geert Uytterhoeven:
> On Sat, Aug 26, 2023 at 12:44 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> (Incidentally - did you ever publish the m68k full history tree anywhere
>> in git?)
>
> You mean the gitified version of the Linux/m68k CVS tree Ralf created
> for me because my machine wasn't powerful enough?
The very same ...
> No, and I should look into doing that...
No pressure!
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 10+ messages in thread