From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, patches@lists.linux.dev,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: [PATCH RESEND] samples: rust: fix `rust_print` build making it a combined module
Date: Mon, 11 Nov 2024 20:59:55 +0100 [thread overview]
Message-ID: <CANiq72m_jUUo1ELwyn8qqXUDNxvCfPbv0NVRAxuAyjzU8o02ow@mail.gmail.com> (raw)
In-Reply-To: <20241109165520.1461400-1-ojeda@kernel.org>
On Sat, Nov 9, 2024 at 5:55 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> obj-$(CONFIG_SAMPLE_RUST_MINIMAL) += rust_minimal.o
> -obj-$(CONFIG_SAMPLE_RUST_PRINT) += rust_print.o rust_print_events.o
> +obj-$(CONFIG_SAMPLE_RUST_PRINT) += rust-print.o
> +
> +rust-print-y := rust_print.o rust_print_events.o
Steven: if you have not applied this one yet (I think you didn't), I
think it would be best to rename the main source file instead of the
module name, since we already have users and a couple other places we
should rename.
I am sending v2 in case you can pick that one instead.
Cheers,
Miguel
prev parent reply other threads:[~2024-11-11 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 16:55 [PATCH RESEND] samples: rust: fix `rust_print` build making it a combined module Miguel Ojeda
2024-11-10 10:56 ` Alice Ryhl
2024-11-11 19:59 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72m_jUUo1ELwyn8qqXUDNxvCfPbv0NVRAxuAyjzU8o02ow@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).