From: Eric Dumazet <edumazet@google.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
rostedt@goodmis.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next 0/2] add two missing addresses when using trace
Date: Mon, 4 Mar 2024 09:21:51 +0100 [thread overview]
Message-ID: <CANn89iJPZ-B5yQeNbgxeW94OSL1XTacLgfbJTu8janT8qjWSvQ@mail.gmail.com> (raw)
In-Reply-To: <CAL+tcoBJy4a_wBQbwmvWZWZP7mwaby3xHy+45x-PTEbHsGAH6A@mail.gmail.com>
On Mon, Mar 4, 2024 at 8:01 AM Jason Xing <kerneljasonxing@gmail.com> wrote:
>
> On Fri, Mar 1, 2024 at 1:10 AM Jason Xing <kerneljasonxing@gmail.com> wrote:
> >
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > When I reviewed other people's patch [1], I noticed that similar thing
> > also happens in tcp_event_skb class and tcp_event_sk_skb class. They
> > don't print those two addrs of skb/sk which already exist.
> >
> > They are probably forgotten by the original authors, so this time I
> > finish the work. Also, adding more trace about the socket/skb addr can
> > help us sometime even though the chance is minor.
> >
> > I don't consider it is a bug, thus I chose to target net-next tree.
>
> Gentle ping...No rush. Just in case this simple patchset was lost for
> some reason.
This was a conscious choice I think.
https://yhbt.net/lore/all/20171010173821.6djxyvrggvaivqec@ast-mbp.dhcp.thefacebook.com/
prev parent reply other threads:[~2024-03-04 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 17:09 [PATCH net-next 0/2] add two missing addresses when using trace Jason Xing
2024-02-29 17:09 ` [PATCH net-next 1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class Jason Xing
2024-03-04 8:24 ` Eric Dumazet
2024-03-04 8:31 ` Jason Xing
2024-02-29 17:09 ` [PATCH net-next 2/2] tcp: add tracing of skbaddr in tcp_event_skb class Jason Xing
2024-03-04 7:00 ` [PATCH net-next 0/2] add two missing addresses when using trace Jason Xing
2024-03-04 8:21 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJPZ-B5yQeNbgxeW94OSL1XTacLgfbJTu8janT8qjWSvQ@mail.gmail.com \
--to=edumazet@google.com \
--cc=ast@kernel.org \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).