From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B6717583 for ; Mon, 4 Mar 2024 08:22:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540526; cv=none; b=pXVvUAcFEED8/2RICno5O92iUBaodZE2j/iVF8wqPInd5anelKdbZKPr7MqDz+uLSyAMsX2KHX/qMswEtTT1RjnQJ8z0VUmDci06YdXbYks/MavNXkTdC1VloDNRXtVqKV9LLVKw5r6X/Z2k09LditBSMJk8BEzuJ3i0QvW66EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540526; c=relaxed/simple; bh=EoyygbLnI6vV+Uw7w1G/Xr29iq0XsQRIh4eFJ1Yd/oE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=IqUTMJX5uXGsDFxhjJHJS3MBqnT0VgYn4rCPACptXHEBeJGxZe/8/SGoocZmkdIumeQoadt8jjUc0ADNrVqj+e5lv8H3Hc/E3wjtArMCVSZbvRwv8+rHDTWhIIdwcmGtXU0j50LUAEOKn4+MlsPJb55C+ZvKh3d+usVXOBfO2uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Y/VsbF9A; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y/VsbF9A" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-56693f0d235so19098a12.0 for ; Mon, 04 Mar 2024 00:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709540523; x=1710145323; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EoyygbLnI6vV+Uw7w1G/Xr29iq0XsQRIh4eFJ1Yd/oE=; b=Y/VsbF9A20ihAkwV8YKT3c/nx5nd59ScEMev+9d154lp71rI4A8qDgt9z3YNmPTnzO o/bIl3trMlhXfFjKIbM2F7Clrb3qenuWSMTsG0SrSlfY6n97zqfdz7D4wHLTXP4fvdev L9zBI3epAjzJXtAuw1hJEOSonunXv+mxPinRiNK+Ce5aNsYmyVuPyuPJ4M6Vu4Co8b6E PW28UYTXrMo03YeXn4hYuDaO5TVSub+EkWAaUBBWurX5omeSjrGjlSp6u3vQYgHA3DCn 7DXPjqVXClE4RePbvZX/ekm7BXUcjUYFX4XRMHcqvN5Xce+Tna1S38PUU+4BnU9oKgTy rSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540523; x=1710145323; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EoyygbLnI6vV+Uw7w1G/Xr29iq0XsQRIh4eFJ1Yd/oE=; b=E37xUlLVjPXAqms+LAWxTQ/eXnwts3DHTRg0l+c4+6nvPHWDPoRLbUzI1zXor+SFAh lASxgeBGYFw/dUa+t5M9AwmcEMfInwJVmaQmkfeG8SpinQsswGdVEeigN/hMYsiOUJK9 O9DXpl5HTzjZZnIEQh9Ebhtf9Fa8p8JPpRtY1UVRL/3nLVAYEKknb0pzmBurZ2SjTOns gokFeDqIAnxB+6z3TAWrjVkE12wA0doLY27O457OwCgIhym1Ys2OXQOb2XQRFk2JtGzB IpK7FdqZJ60yNDUe3Huh/6T6u0Fk28U/YnyXSmtT/i9cZ9raIzKrU9tkHS/V8Oz+9Vbu 89Aw== X-Forwarded-Encrypted: i=1; AJvYcCUGRjC33wohuOekWw3dpW7nkCP5YnCEwcxdBY9fwYbMZB2QoD1juqLtYO3y1+H8+FW6vyNYKJHM0/gHa0PRrRXN4ckq+F02vMzzwh4UWRelF1Cg X-Gm-Message-State: AOJu0YyxFJ7svPKAEt+1LdZtA2f554DG4MX24CCqeV8d/UIGb7V3tzED E7InCR2/ZYtiIphpt+Nxh3aJjhYIoGRm4a7vZ8ln5ugffkSprYnWR8vjBDo5WDGWkzsvU2JnWg7 Jt5dckCYGBVm96CHW/jCKRTI8sc8OQdbXAbTW X-Google-Smtp-Source: AGHT+IHIYRhnnjPqqmA79sgEwxplLI7CJumeOF9au9GyycW28mXDL31rveCzHd+JVDxCrDIYk4Vm2YGD+UM4CRz+Dh8= X-Received: by 2002:a05:6402:291:b0:566:b5f5:48cc with SMTP id l17-20020a056402029100b00566b5f548ccmr295449edv.5.1709540523254; Mon, 04 Mar 2024 00:22:03 -0800 (PST) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240229170956.87290-1-kerneljasonxing@gmail.com> In-Reply-To: From: Eric Dumazet Date: Mon, 4 Mar 2024 09:21:51 +0100 Message-ID: Subject: Re: [PATCH net-next 0/2] add two missing addresses when using trace To: Jason Xing , Alexei Starovoitov Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, rostedt@goodmis.org, Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Jason Xing Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 4, 2024 at 8:01=E2=80=AFAM Jason Xing wrote: > > On Fri, Mar 1, 2024 at 1:10=E2=80=AFAM Jason Xing wrote: > > > > From: Jason Xing > > > > When I reviewed other people's patch [1], I noticed that similar thing > > also happens in tcp_event_skb class and tcp_event_sk_skb class. They > > don't print those two addrs of skb/sk which already exist. > > > > They are probably forgotten by the original authors, so this time I > > finish the work. Also, adding more trace about the socket/skb addr can > > help us sometime even though the chance is minor. > > > > I don't consider it is a bug, thus I chose to target net-next tree. > > Gentle ping...No rush. Just in case this simple patchset was lost for > some reason. This was a conscious choice I think. https://yhbt.net/lore/all/20171010173821.6djxyvrggvaivqec@ast-mbp.dhcp.thef= acebook.com/