[PATCH] rtla: Sync the help text between top tools

[PATCH] rtla: Sync the help text between top tools

[Eder Zulian]

In addition, fix a typo in the error message generated when the
specified duration is invalid. Suggested by Tomas Glozar.

Signed-off-by: Eder Zulian <ezulian@redhat.com>
---
 tools/tracing/rtla/src/osnoise_top.c  | 2 +-
 tools/tracing/rtla/src/timerlat_top.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c
index 73106683c281..50e97dbc951d 100644
--- a/tools/tracing/rtla/src/osnoise_top.c
+++ b/tools/tracing/rtla/src/osnoise_top.c
@@ -442,7 +442,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
 		case 'd':
 			params->duration = parse_seconds_duration(optarg);
 			if (!params->duration)
-				osnoise_top_usage(params, "Invalid -D duration\n");
+				osnoise_top_usage(params, "Invalid -d duration\n");
 			break;
 		case 'e':
 			tevent = trace_event_alloc(optarg);
diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src/timerlat_top.c
index 94a2f5bbaeb7..312fc7e833ba 100644
--- a/tools/tracing/rtla/src/timerlat_top.c
+++ b/tools/tracing/rtla/src/timerlat_top.c
@@ -459,7 +459,7 @@ static void timerlat_top_usage(char *usage)
 		"	  -c/--cpus cpus: run the tracer only on the given cpus",
 		"	  -H/--house-keeping cpus: run rtla control threads only on the given cpus",
 		"	  -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",
-		"	  -d/--duration time[m|h|d]: duration of the session in seconds",
+		"	  -d/--duration time[s|m|h|d]: duration of the session",
 		"	  -D/--debug: print debug info",
 		"	     --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",
 		"	  -t/--trace[file]: save the stopped trace to [file|timerlat_trace.txt]",
@@ -613,7 +613,7 @@ static struct timerlat_top_params
 		case 'd':
 			params->duration = parse_seconds_duration(optarg);
 			if (!params->duration)
-				timerlat_top_usage("Invalid -D duration\n");
+				timerlat_top_usage("Invalid -d duration\n");
 			break;
 		case 'e':
 			tevent = trace_event_alloc(optarg);
-- 
2.46.0

Re: [PATCH] rtla: Sync the help text between top tools

[Tomas Glozar]

út 13. 8. 2024 v 17:58 odesílatel Eder Zulian <ezulian@redhat.com> napsal:
>
> In addition, fix a typo in the error message generated when the
> specified duration is invalid. Suggested by Tomas Glozar.
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>
> ---
>  tools/tracing/rtla/src/osnoise_top.c  | 2 +-
>  tools/tracing/rtla/src/timerlat_top.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c
> index 73106683c281..50e97dbc951d 100644
> --- a/tools/tracing/rtla/src/osnoise_top.c
> +++ b/tools/tracing/rtla/src/osnoise_top.c
> @@ -442,7 +442,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv)
>                 case 'd':
>                         params->duration = parse_seconds_duration(optarg);
>                         if (!params->duration)
> -                               osnoise_top_usage(params, "Invalid -D duration\n");
> +                               osnoise_top_usage(params, "Invalid -d duration\n");
>                         break;
>                 case 'e':
>                         tevent = trace_event_alloc(optarg);
> diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src/timerlat_top.c
> index 94a2f5bbaeb7..312fc7e833ba 100644
> --- a/tools/tracing/rtla/src/timerlat_top.c
> +++ b/tools/tracing/rtla/src/timerlat_top.c
> @@ -459,7 +459,7 @@ static void timerlat_top_usage(char *usage)
>                 "         -c/--cpus cpus: run the tracer only on the given cpus",
>                 "         -H/--house-keeping cpus: run rtla control threads only on the given cpus",
>                 "         -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",
> -               "         -d/--duration time[m|h|d]: duration of the session in seconds",
> +               "         -d/--duration time[s|m|h|d]: duration of the session",
>                 "         -D/--debug: print debug info",
>                 "            --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",
>                 "         -t/--trace[file]: save the stopped trace to [file|timerlat_trace.txt]",
> @@ -613,7 +613,7 @@ static struct timerlat_top_params
>                 case 'd':
>                         params->duration = parse_seconds_duration(optarg);
>                         if (!params->duration)
> -                               timerlat_top_usage("Invalid -D duration\n");
> +                               timerlat_top_usage("Invalid -d duration\n");
>                         break;
>                 case 'e':
>                         tevent = trace_event_alloc(optarg);
> --
> 2.46.0
>

Yes, this is what I was referring to in
https://lore.kernel.org/linux-trace-kernel/20240813114931.360823-1-ezulian@redhat.com/T/#mc4e07c9fd633f00366d48ea3c6e9b6bad1ebaf4b.
Looks good!

Reviewed-by: Tomas Glozar <tglozar@redhat.com>

Tomas