From: Song Liu <song@kernel.org>
To: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
pmladek@suse.com, joe.lawrence@redhat.com, nathan@kernel.org,
morbo@google.com, justinstitt@google.com, mcgrof@kernel.org,
thunder.leizhen@huawei.com, kees@kernel.org,
kernel-team@meta.com, mmaurer@google.com,
samitolvanen@google.com, mhiramat@kernel.org,
rostedt@goodmis.org
Subject: Re: [PATCH 0/3] Fix kallsyms with CONFIG_LTO_CLANG
Date: Mon, 29 Jul 2024 22:36:50 -0700 [thread overview]
Message-ID: <CAPhsuW6fXrgL-r+XRs_pVg-3XSv21pbSPcZ8djYRjcs2sHDj7g@mail.gmail.com> (raw)
In-Reply-To: <20240730005433.3559731-1-song@kernel.org>
On Mon, Jul 29, 2024 at 5:54 PM Song Liu <song@kernel.org> wrote:
>
> With CONFIG_LTO_CLANG, the compiler/linker adds .llvm.<hash> suffix to
> local symbols to avoid duplications. Existing scripts/kallsyms sorts
> symbols without .llvm.<hash> suffix. However, this causes quite some
> issues later on. Some users of kallsyms, such as livepatch, have to match
> symbols exactly; while other users, such as kprobe, would match symbols
> without the suffix.
>
> Address this by sorting full symbols (with .llvm.<hash>) at build time, and
> split kallsyms APIs to explicitly match full symbols or without suffix.
> Specifically, exiting APIs will match symbols exactly. Two new APIs are
> added to match symbols with suffix. Use the new APIs in tracing/kprobes.
Forgot to mention: This is to follow up the discussions in this thread:
https://lore.kernel.org/live-patching/20240605032120.3179157-1-song@kernel.org/T/#u
Thanks,
Song
prev parent reply other threads:[~2024-07-30 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 0:54 [PATCH 0/3] Fix kallsyms with CONFIG_LTO_CLANG Song Liu
2024-07-30 0:54 ` [PATCH 1/3] kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbols Song Liu
2024-07-30 0:54 ` [PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv.<hash> suffix Song Liu
2024-07-30 13:03 ` Masami Hiramatsu
2024-07-31 1:00 ` Song Liu
2024-08-02 1:18 ` Leizhen (ThunderTown)
2024-08-02 3:45 ` Song Liu
2024-08-02 6:53 ` Leizhen (ThunderTown)
2024-08-02 13:04 ` Masami Hiramatsu
2024-08-02 15:45 ` Petr Mladek
2024-08-02 17:09 ` Song Liu
2024-08-05 12:53 ` Masami Hiramatsu
2024-08-02 17:16 ` Song Liu
2024-07-30 0:54 ` [PATCH 3/3] tracing/kprobes: Use APIs that matches symbols with .llvm.<hash> suffix Song Liu
2024-07-30 13:04 ` Masami Hiramatsu
2024-07-31 1:09 ` Song Liu
2024-07-30 5:36 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW6fXrgL-r+XRs_pVg-3XSv21pbSPcZ8djYRjcs2sHDj7g@mail.gmail.com \
--to=song@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mmaurer@google.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).