From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>
Cc: <linux-riscv@lists.infradead.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
<linux-kernel@vger.kernel.org>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
"Anil S Keshavamurthy" <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
<linux-trace-kernel@vger.kernel.org>,
"Calvin Owens" <jcalvinowens@gmail.com>
Subject: Re: [PATCH v2] arch/riscv: Enable kprobes when CONFIG_MODULES=n
Date: Mon, 25 Mar 2024 21:11:56 +0200 [thread overview]
Message-ID: <D032IFOPKJI8.3TKDPQQI9I6LG@kernel.org> (raw)
In-Reply-To: <D031SE4QN1CG.18GY6AS20QF1J@kernel.org>
On Mon Mar 25, 2024 at 8:37 PM EET, Jarkko Sakkinen wrote:
> > You also should consider using IS_ENABLED(CONFIG_MODULE) in the code to
> > avoid using #ifdefs.
Hmm... I need make a couple of remarks but open for feedback ofc.
First, trace_kprobe_module_exist depends on find_module()
Second, there is a notifier callback that heavily binds to the module
subsystem.
In both cases using IS_ENABLED would emit a lot of compilation errors.
BR, Jarkko
next prev parent reply other threads:[~2024-03-25 19:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 23:29 [PATCH v2] arch/riscv: Enable kprobes when CONFIG_MODULES=n Jarkko Sakkinen
2024-03-23 23:31 ` Jarkko Sakkinen
2024-03-24 0:37 ` Randy Dunlap
2024-03-24 2:09 ` Jarkko Sakkinen
2024-03-25 2:56 ` Masami Hiramatsu
2024-03-25 3:58 ` Calvin Owens
2024-03-25 18:37 ` Jarkko Sakkinen
2024-03-25 19:11 ` Jarkko Sakkinen [this message]
2024-03-25 19:16 ` Jarkko Sakkinen
2024-03-26 14:46 ` Mark Rutland
2024-03-26 15:24 ` Masami Hiramatsu
2024-03-26 16:15 ` Calvin Owens
2024-03-26 16:45 ` Mark Rutland
2024-03-26 17:09 ` Jarkko Sakkinen
2024-03-26 16:38 ` Mark Rutland
2024-03-26 17:11 ` Jarkko Sakkinen
2024-03-26 17:08 ` Jarkko Sakkinen
2024-03-26 17:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D032IFOPKJI8.3TKDPQQI9I6LG@kernel.org \
--to=jarkko@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=davem@davemloft.net \
--cc=jcalvinowens@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).