From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013000.outbound.protection.outlook.com [40.93.201.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF1C2D8DBB; Sat, 28 Feb 2026 01:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772241395; cv=fail; b=ZkSyODVaQwRW1iA6jBNbo3faquZeZP1YBMyqEjYoE2wOR7uPLMM+ZjcsnB+xCUqCWQKuo7VWwluQ9xX8lF1L92DLkrKd8RiiTLnhWHp6G7thTd8+b+EUQY8NYsX9HZe03lni9WxNX5Nw19j2kyM192zfurUKffAtlR7rIMry/YQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772241395; c=relaxed/simple; bh=oFHN4wgrWfUw/ERHtAIX9nwAb2niaCLQqxykcbJmKOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=YJT/WZXTSHgWhDNs1MI1D6DOngacZZMm1X53bhLhNo3EJkJeh9+tHkvAc1dKPBBwItVzWG5iMEVQCM+mAT+d4kC7eJ4AbO6Rh9HVDf96jITEG4ssgbYmqGCtPEFj/uXbfawg+QtJaksZECnDfik3hCCCrkGrQuyHvNdRb9kg7qA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HjBf+T0g; arc=fail smtp.client-ip=40.93.201.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HjBf+T0g" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dfgNqmhSTOHDJ6JfrCXk1BQDLPH6RYXAW7mB2T1XlLRzzRyiHjDdDi4Xez+Smwk1YXJjTxsrDwxoo0giqwGYbOnmk0jujllSCEkJUW9WT12ibp8n5ZtoNhiAUDLnbL/YSP/vv8xOhr3wcEzbiWkGE9UV4zCvjYeP8RQFOr99yI1DiLj9VfvVe0tE6/xDpGBsPCKibrobH1N24kC49LBTG6AIZ/nnTtyhoY8bqF61TjAjKxdCYoqJXuow7Cvff1otq82HFlNa3hPof3xoPVFnID+HEHyqBZsiAFxxKUAi1583uRDdVdtRkld4kZI6Wx/9VYeqpYqiNvwm9aYDEsDsuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B444r8/1VE+2bEDpsn1Rv3q3aOW+LOZUxy2NYEFPh5g=; b=Q7oLqNYFMmQnSszylLu4rOech/57nzlVFUgIH/ZYJa5jCjJYdFJJzS3+FDLFQwMHovnpOXbWDPd5brJyp+3TM0mqJeKyKdmnXXZQq9Lspz093bhr/BX5NLr3NI8+Qd1NgddpBMXeXyS9oBY/voIqFrkrVuXG872t3nTUkvnDA7OKvHQhzi2u7KyFiYIZx4M583qR2dh0ZC7Jtlhh6XUjTYqp4U9up/qJz7h946R56hcfFE6+GirHqDAbHaE08ZaVK+bvUZnEkuyYjFW6L4z+gAob+a8nWfqWv3+ccPmkWhg99soKKLp/lxKu35Zo7CsZY2s5z7lQhmlnYyTYsFVOOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B444r8/1VE+2bEDpsn1Rv3q3aOW+LOZUxy2NYEFPh5g=; b=HjBf+T0g0gug+YuaQann9yxuUm9ETAMjMdzUN16NjaGHZ1ov018/yYvS7UVNVu53cdOuFgf1OYL7T2DP3k0EooCTy//iMekDoYcqkAfQqMIicwF6wbZ9ndeROLBPNaDoYg79RJcGsVPLRFwfU1Q3ny/XBbP3WXKUKMhbm70mk3Iz5WCaVT/qrZPdk983pflqRjv+2wDMjNWzuPjgocfqomKDjHbvYJ+/C+cMArA6X+axbTb6cp23CQrM/0/k7gNbQisz+/SpbEA5KKt/469nycyL/6+SiDKHjqrXZBIst0FegK8ri7PBBe01h8OGLga0ds67MZMvNfggMzWvo/lXIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by PH8PR12MB7326.namprd12.prod.outlook.com (2603:10b6:510:216::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.11; Sat, 28 Feb 2026 01:16:30 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9654.014; Sat, 28 Feb 2026 01:16:30 +0000 From: Zi Yan To: Dmitry Ilvokhin Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Brendan Jackman , Johannes Weiner , Oscar Salvador , Qi Zheng , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 3/5] mm: convert compaction to zone lock wrappers Date: Fri, 27 Feb 2026 20:16:24 -0500 X-Mailer: MailMate (2.0r6290) Message-ID: In-Reply-To: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> References: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> Content-Type: text/plain X-ClientProxiedBy: BYAPR08CA0041.namprd08.prod.outlook.com (2603:10b6:a03:117::18) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|PH8PR12MB7326:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c16e996-6610-4a4f-5efe-08de766700c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: kNAKVoWjLLyCeWt4kxJweMwiVE7orI42OD3O2f4YOM+JdVYkwAfRWqZ5EzQEfs7IvxJmcX2edQ7Tz0M99BcOs9MfZuNGOAdEUuGIe2CswnLI5UyYWGHDDD4l0hg9OefqoSwnDnZsfvqJKB8RckDbSLxvwZze6xa8/zaGMLadlJugMyazo5gvzc8uCpITwarWxfSdZMVXiKrlffN4EKZAUp3ARg2zo8qzYGKWA9a4Z3nhOuDAQbS0mH0w8l0UwxWJRQ7SMwPZ55ruRheQxwxSJI8iyLReM0smgFFZ/gcS7cwnsQ9bLafFMQVGRU0wCoEHuwrTiB36YYYlNKTSeSsGusBfxZ4TCq4ieGh+rP8wnaP70KrVzr2T12Cz0WojZGi48JE8mZsZO3NQmLP8Iulj2L0ViCuoVu7+pFrKBgeKD8X3h50O4FBTS4+GvwhcSuQ/sjNGcu2mzvLRCC/q6293YMIFaAfqMnA7BMB4MHfVWAwOCj4YhjKjkNIadTiOyJ643MIOADbzOBC7hE3AXBnvP+qlzdvAG/c26IJzqEbDVD0at7GoH/KoP5f86FS0U0Op3NoeGTDlU87ucm9fjconK/1n6ilLCORNfLxi1YPwsdZpBaNSCzKYX7Bggk5ET3DaWyKikEsD3PxhS2Pnd2KNQaulUZ++bMyULzGGETjlWdMCEryZ2QzO6So3/xHb0gTyO53WONE9qKrtJHU+qaHT8Z+kcYRekUCn4fjmZgrGvqA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zjacgqenjw1UAi6OWPulePWjJeub4ZWbCzG/wPDVMrBLbHDcpX9YVXT/7SPy?= =?us-ascii?Q?qGZhw4mL0FrjVMXx4NHfwnAivLCO1h3cGjs9xTDvyfCIFTgt7pFt4Yww1NDA?= =?us-ascii?Q?H3uXl+K/osd2zSKfM42otUIzuWmtHWvRG+KS5AyeADF0APeroU8HUsJhTmQl?= =?us-ascii?Q?P8K/bOgUhfKj/W3hpARkwlcpUwBFrEMxGvC1/3zRm7tve2B6/DxHJmAwuxAX?= =?us-ascii?Q?rL6HK/eOg2XA07BLxeu8VXXO0pEQmm9oLkCmTLFg7wPFeSFnItdb73HPpAGl?= =?us-ascii?Q?oK23TAKsKeMz6v8ekk1fbpPITbxB9Z1rtmYXGy0S0fvaEDR18Z3cjFpO627Z?= =?us-ascii?Q?xBzTQ/gGbD23WbRvftC8bjLwxEkomSUsClcVgM7UaHdw4/MJijr1sPnxmFb4?= =?us-ascii?Q?89/MW7WQuDE/CjCViSA87aPKXWXlgcYERv3oOQthw7YA8Cq2Al/yU0XOCgOW?= =?us-ascii?Q?7bHCNNIV9PYWsVVHEFVwgNHI8cPiM+vPiOEPscaoyTYKypk2aXgYl/9ClcD5?= =?us-ascii?Q?TQ2zVkTTkBJMRTpqwa/Axc2pLRPFWekhFMyq2Jwe4mlDrcnh23LWVattoBMR?= =?us-ascii?Q?l9zRyNkARcEUN7PJ7C5XqNzjOYnjftLU8zrttgaH1YhSg2Piol/0LHDejU0Q?= =?us-ascii?Q?45nCgbigOeD//5RtXXncyoD8lCKdAlxidrYHmie+BMqczhfLjdJ0geJJ1SSC?= =?us-ascii?Q?ET4OLQn2x5KHLjeoQbyxsmCiJNDu8MAko6C/EnqiFhFjtjFzHrvID8jgZIa6?= =?us-ascii?Q?vzJN0XU6SQCdef2MmproY2nJMFfpTY1Rd6+RlQ7ttvN06Bebw56amvH7R2Nt?= =?us-ascii?Q?yvJUENO59lmJN4Kjy18KcBguOhHZvIcuX11llm2f3FSSyfPhHWbeUPSvzyt6?= =?us-ascii?Q?QtRJAL5DarZSyjDgQIba+P2AJI5RTXih1SdDXh2weHiOISeuN4wIV2vWpDmZ?= =?us-ascii?Q?KuzHNKx0+5QHlIEUOYok0cDlEBSfq5R4y7hGpPLqoSnVZBLPZ/5serQ+aUoz?= =?us-ascii?Q?q+BNyhAzEitS5uInthzMKBMG/3sdw7b1TPvK0mB2DDhFAjkmwZOknGFa+S+b?= =?us-ascii?Q?WduR4cVUj/KYsq4aV8B/qq819RwYF/mBRPGM2pp0FxBjvuLXEKpcVSafkK+q?= =?us-ascii?Q?nsAehsd/tnyGdX8/5hG8hY+5G8cfPsM//L7hDqFiQouSQgXxoJtb1O7INIzS?= =?us-ascii?Q?e5hX0VVCVgHQPVj5Au+GBxVGKjv1XmT1TDMv0tEBO2tGkjA3ZNVCgZdGtTaV?= =?us-ascii?Q?6YTbNisKP7lw9VBvO6HgGsUGD3Agqts1ijezm8Pw5GFt/gfQIQvVno9Jonxr?= =?us-ascii?Q?cNZmB+pN657kmsa8DZIBOpeS1Vo1Mk4LL0MsB6Z3CLRSopHXv1bjOYaU1koU?= =?us-ascii?Q?ZC2W5KptqMxqx998R8to7EEQ6xuYGQMnlZQuE59L9F7Okp/dF38Vc5sxyZDj?= =?us-ascii?Q?shqmDrWqGGlnSywcLLU/o3wZAEDZ7lWC/03fKRA59/zW7v0SctEWdNo7GmG9?= =?us-ascii?Q?K48zEwfN+FhXpG/GQI+ZgbrBD+J56y8PUpfT6loBSP/kUb4VjreV5nhLkDdz?= =?us-ascii?Q?59c/gmuKsLBhnJMcGV53Y4m67y2JKr8OldTvwHDXRE+XOQJvkL9nBsBx8K8Y?= =?us-ascii?Q?ZozmahYXDNmiIxuTO3H3y99QQYhqFygh1LlSK/UxmtLO0sQwmQZMB23lGKfo?= =?us-ascii?Q?DMibyKqHpRwZ0irYLME+WsEYNCbBpsShmMahttwJW1zA4WJh?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c16e996-6610-4a4f-5efe-08de766700c8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2026 01:16:30.2664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lOqx+nrhj8iJWHa021mrtJHnbjRwPdCwiM86jsAlUVCnY4mOSwonzbQlFW6t/Zef X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7326 On 27 Feb 2026, at 11:00, Dmitry Ilvokhin wrote: > Compaction uses compact_lock_irqsave(), which currently operates > on a raw spinlock_t pointer so it can be used for both zone->lock > and lruvec->lru_lock. Since zone lock operations are now wrapped, > compact_lock_irqsave() can no longer directly operate on a > spinlock_t when the lock belongs to a zone. > > Split the helper into compact_zone_lock_irqsave() and > compact_lruvec_lock_irqsave(), duplicating the small amount of > shared logic. As there are only two call sites and both statically > know the lock type, this avoids introducing additional abstraction > or runtime dispatch in the compaction path. > > No functional change intended. > > Signed-off-by: Dmitry Ilvokhin > Acked-by: Shakeel Butt > --- > mm/compaction.c | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) > Acked-by: Zi Yan Best Regards, Yan, Zi