From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AABF37F8C7 for ; Thu, 17 Sep 2026 02:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789611867; cv=none; b=WnQETUajVlHZnWb3BVS/GkLJhHwE4pRauY1lBh2AY+EPGSnczHizYk7BQVJn6TB8+LpWbkLSgDP+5RolqDEEYfBoU5MAplQ2JGuyptXnlo5UGZRguKzfumtPPNHKcydrcZ9AM8WLvkgTxcic/v8p7iiMMAgM7n4bPEPwSf3fZWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789611867; c=relaxed/simple; bh=E+msnkVkMuv7EW3/XyJSZb0DiTqaEOW4e8lxU2bUdDk=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=WHtlHNkGHPbNUhMXtVI0BBEnKP8ObdBpjXBXeiYhwATyu0orihaKiUyqtCFSAVJrsxFEkESwawtAWWiLfIlEbZbNoZAK4hSskQEQkzyDcXZ81REZwe1dp9Ge7W+cYfFTrTLtpRPeAsIqTFKtKxsh3iWnuqx6jIhJN83UavYgrKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DfozeCmU; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfozeCmU" Received: by mail-pj2-f43.google.com with SMTP id d9443c01a7336-2d93ff61046so3138595ad.3 for ; Wed, 16 Sep 2026 19:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789611865; x=1790216665; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=6EKmqByiGxzJPh+0Mll6vjXYdVK/vy8pIRVPNPfe0KQ=; b=DfozeCmU42c3ZQt6zeu2eLYJawKiY6mKFmktJGlatz7kS0KtK38o/GFcK0d5SnwSzg Mjdec2QO6eboPe2Jz4IkKLjF/iIv0aBkjdGl8vvrUkCEtctay+UHUKqR9DVS+y+KVpob tncm79dXTOTPcDu9g9fjUDBbfMrrWN2AQ9kgDGSwv2d3BckJdz4kWNueJQrwT2QE+PI7 EH8vqv5Tjnq6dBxaNOQhZeBpEqZcgXhQglEoY7nbKJDPfzEdiS0Zrafzhhq6OdQYBxWH dbUC21FZJB4V4N6W5UsLx6JZ1N41Q/dd4w4rYK3UVq+xlao0i/8nLQZPfdyxgebsGQDe YxSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789611865; x=1790216665; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6EKmqByiGxzJPh+0Mll6vjXYdVK/vy8pIRVPNPfe0KQ=; b=IVtftX1sAoqDLaghxfEhognU6HhOQN+dA6OxuR5UjxWk9tDesGpnLKy5A1p13AnEt5 roTsCjehramJAUcQd2clhDAl2wbYdLzE6hUt7pSJcRMBkSSXPgcgA9+hzGF6mLRLvOes 727fGVe4u39M9oYCXjWLYSccIJ+ESzYu5Rm1RISkY/hJixZX4QAVxj8Af89O0IP9rdlQ Bq72L3efA8UrFcAJLdYiJe8Z5IqZ7EQwmutO9/vsGq8Wiujgzmf94qj36+lpK0K5VB2y PHioNY7KehgXa00OmOA7dm9q3r2jgjXUm2hALh6ubz8sO4aIbS6SunahrM0KijLmeKTu HHfA== X-Forwarded-Encrypted: i=1; AKwUvBwoesFCZelknjVC5pHlYEtUIo2LyjUWKJqIEqQDmeO4LBa50DgtiKgW516qtoXD+qIv5b3MYKacHkjtvJZZES2VIig=@vger.kernel.org X-Gm-Message-State: AFuF++ndhw2JKwdTRjdkhYQK96r0DJ3PveSAkUfcqmARtJ+vVwfl7Hmw bhFBN3LMGZ1/mGKH1NyqA/OCX51Q1ubsYgNAyr5L15lrTbA+c65WrhFE X-Gm-Gg: AYBFou3UTIGG4cxV6/PJXCH0TCCGrcgJmOJaOjIyWnq8GHbGdIJ6tvLKvFzS2roHyQn zQKzZGuatvajsh0Md8NDHUp/P/bVgKa+5qPThwMl7zgzVTw0XjoU/y9V+iac6Uc6LOHSD2Ucbpb 5BHCry0FpFKP1MdwJIegxGnZ3GIOl3E5qIU9+UbBgqEH4pEjMINtaVKWSiGAVlviflWz7lK4mj6 ZqNDuHrF672QDwJxPCHvwaDGGuB2ybOu9CYhkJsC/5Vx9+XeceMRW5ls9h1h6RUedzjJwA9othR BXjxk05MCTaLOHsmfPokPU5tHMQZr2xaMcamzvli+sUJMqcunsRCa3Q8a3KR5sYK9t2SLIEX2hD VGpV/O3KfaYnyP9Pi4sSYV7CiTPQFJXJqZH9nd8J4JbbgEcfVkxgcekQVFdzN3iuUHmPSUYiy2R JCVbM+78QgAjahQyrIa/4jK7tjfn3DBh5R0ha3T/s6vqRO8shFv6LSwNqA5trP+OgY6HubSEYR3 x4Rwyt4tWPzihbg1JyTLws8T0NDjRM2xDyqwwd1Hrk8XyNpihE7yseHH2gDv5za0IdnOBGqlVAg dCIT X-Received: by 2002:a17:903:1ac7:b0:2dd:60d:8b7c with SMTP id d9443c01a7336-2dd8e3f57f8mr114351815ad.13.1789611865419; Wed, 16 Sep 2026 19:24:25 -0700 (PDT) Received: from localhost ([153.61.198.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd89ee3557sm18694235ad.52.2026.09.16.19.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2026 19:24:24 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 17 Sep 2026 02:24:24 +0000 Message-Id: To: "Josef Bacik" Cc: "Paul E. McKenney" , "Frederic Weisbecker" , "Neeraj Upadhyay" , "Joel Fernandes" , "Boqun Feng" , "Thomas Gleixner" , "Peter Zijlstra" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , "Jiri Olsa" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , , "Catalin Marinas" , "Will Deacon" , "Puranjay Mohan" , "Xu Kuohai" , "Andy Lutomirski" , "Josh Triplett" , "Uladzislau Rezki" , "Mathieu Desnoyers" , "Lai Jiangshan" , "Zqiang" , "Juergen Gross" , "Luis Chamberlain" , "Ihor Solodrai" , , , , , , Subject: Re: [PATCH RFC v3 06/13] bpf: Take a Tasks Trace reader in the trampoline glue From: "Alexei Starovoitov" X-Mailer: aerc 0.17.0 References: <20260915-b4-rcu-tasks-preempt-qs-v3-0-0ad30c4c5ee7@toxicpanda.com> <20260915-b4-rcu-tasks-preempt-qs-v3-6-0ad30c4c5ee7@toxicpanda.com> In-Reply-To: On Thu Sep 17, 2026 at 1:16 AM UTC, Josef Bacik wrote: > On Wed, 16 Sep 2026 03:45:16 +0000, Alexei Starovoitov wrote: > > On Tue Sep 15, 2026 at 1:17 PM UTC, Josef Bacik wrote: > > > __acquires(RCU) > > > { > > > + bpf_tramp_read_lock_trace(); > > > rcu_read_lock_dont_migrate(); > > > > This is double increment. rcu_read_lock_dont_migrate() includes > > rcu_read_lock_trace(). > > Unless I'm looking at the wrong tree it doesn't, on Linus' master and on > bpf-next it is > > static __always_inline void rcu_read_lock_dont_migrate(void) > { > if (IS_ENABLED(CONFIG_PREEMPT_RCU)) > migrate_disable(); > rcu_read_lock(); > } > > so plain RCU plus migrate_disable(), no Tasks Trace reader. That is why > the non-sleepable glue needs one added here: on these architectures the > trampoline image the glue returns into is only kept alive by Tasks RCU > while the task is a rcu_read_lock_trace() reader, and rcu_read_lock() > does not give us that. Right. I got confused. Since rcu_read_lock_trace() CS will cover both sleepable and non-sleepable prog types let's do it once per fentry+fmod_ret region and 2nd time for fexit region. We probably don't want to hold it for the whole trampoline, since orig_call will delay freeing of progs.