From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51034BA9F2 for ; Mon, 28 Sep 2026 12:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597322; cv=none; b=Eb4tLZLuiLCIkYAxYjiOE+nEKnI5TlLiT87qJokHZ98LK0DgHAs2Mb+7vC+gU1fGr0L1KWs1Rxwr/0nd2TgStRPwqZQY3XWU/E+rBMpov7tokEYiZTcb4uScruI415Gw5vSSrf9ZV7yNKkWxYrkMFhz2fKveGSbtJuFOgRo7wYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597322; c=relaxed/simple; bh=ngTtFusTfZr+Of7JLZyU1CxmNJum730Dky6yyjZX8hM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=lyXriN0PVXrsJ9Nr+E+iPuB/Gup/tpreDq7etjHOG4yoo60koCuNuB70JONA9JTcgcqQsvFaVQQiuBdmC/qyCvdrKGMQjZlHmgeMie3cQ6o86fVgB43i4lHrQO9sXT9VgucTUi4u9bzwmcIYRo6oSN17zLfFBUIL46nEODbLVAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=exO8AcIo; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="exO8AcIo" X-Envelope-To: linux-trace-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ngTtFusTfZr+Of7JLZyU1CxmNJum730Dky6yyjZX8hM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790597317; v=1; x=1791202117; b=exO8AcIopGtVEY45vqBpq1JN4Temm8AG2wOgr+XOdedY/hhBYnHRN9wRIFREBNxwQt/MQzyP +Dn6cSne7XZbaXI8ORzFEqIBZU2bNnvn0jdWYJMU9QsSydJD9ipLPi8jeY3NxG2JzlN4pLlvbGv QUm9aXmEP7ljh7C0pXZCjNMo= X-Envelope-To: linux-trace-kernel@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id 17011efc67c7e6a9; Mon, 28 Sep 2026 12:08:37 +0000 X-Mizu-Trace-ID: 17011efc67c7e6a9 X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.11\)) Subject: Re: [PATCH RFC v2 1/7] mm/memcontrol: drop unused vmscan tracepoint include From: Muchun Song In-Reply-To: <20260928114625.3609130-2-ridong.chen@linux.dev> Date: Mon, 28 Sep 2026 20:08:16 +0800 Cc: Steven Rostedt , Masami Hiramatsu , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton , Dave Chinner , Mathieu Desnoyers , Qi Zheng , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , David Hildenbrand , Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , Ridong Chen Content-Transfer-Encoding: 7bit Message-Id: References: <20260928114625.3609130-1-ridong.chen@linux.dev> <20260928114625.3609130-2-ridong.chen@linux.dev> To: Ridong Chen X-Mailer: Apple Mail (2.3901.100.1.1.11) > On Sep 28, 2026, at 19:46, Ridong Chen wrote: > > From: Ridong Chen > > memcontrol.c includes but does not use any of > the tracepoints or macros it defines: all tracepoints invoked here come > from memcg.h and writeback.h. Removing the include still compiles > cleanly. > > Assisted-by: Claude:claude-opus-4-8 Since commit 816d9992d9ed, the label we recommend is Assisted-by: LLM. > Signed-off-by: Ridong Chen > --- > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index aad0498a7bd6..95c2322d4a6f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -77,8 +77,6 @@ > #include > #undef CREATE_TRACE_POINTS > > -#include > - > struct cgroup_subsys memory_cgrp_subsys __read_mostly; > EXPORT_SYMBOL(memory_cgrp_subsys); Acked-by: Muchun Song Thanks.