From: Ross Zwisler <zwisler@google.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: Ross Zwisler <zwisler@chromium.org>,
linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Hao Luo <haoluo@google.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Leon Romanovsky <leon@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-rdma@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: use canonical ftrace path
Date: Tue, 14 Feb 2023 09:23:48 -0700 [thread overview]
Message-ID: <Y+u1lL49CB86VSuE@google.com> (raw)
In-Reply-To: <Y+r4jLwWvhcvyuih@google.com>
On Mon, Feb 13, 2023 at 06:57:16PM -0800, Stanislav Fomichev wrote:
> On 02/13, Ross Zwisler wrote:
> > The canonical location for the tracefs filesystem is at
> > /sys/kernel/tracing.
>
> > But, from Documentation/trace/ftrace.rst:
>
> > Before 4.1, all ftrace tracing control files were within the debugfs
> > file system, which is typically located at /sys/kernel/debug/tracing.
> > For backward compatibility, when mounting the debugfs file system,
> > the tracefs file system will be automatically mounted at:
>
> > /sys/kernel/debug/tracing
>
> > Many comments and samples in the bpf code still refer to this older
> > debugfs path, so let's update them to avoid confusion. There are a few
> > spots where the bpf code explicitly checks both tracefs and debugfs
> > (tools/bpf/bpftool/tracelog.c and tools/lib/api/fs/fs.c) and I've left
> > those alone so that the tools can continue to work with both paths.
>
> Doesn't seem to apply cleanly to bpf-next?
>
> https://github.com/kernel-patches/bpf/pull/4584
Oh, apologies, I was using Linus's master branch as my baseline.
I'll send out a v2.
prev parent reply other threads:[~2023-02-14 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 22:18 [PATCH bpf-next 1/2] bpf: use canonical ftrace path Ross Zwisler
2023-02-13 22:18 ` [PATCH bpf-next 2/2] selftests/bpf: " Ross Zwisler
2023-02-14 2:57 ` [PATCH bpf-next 1/2] bpf: " Stanislav Fomichev
2023-02-14 16:23 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+u1lL49CB86VSuE@google.com \
--to=zwisler@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jgg@ziepe.ca \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mst@redhat.com \
--cc=mykolal@fb.com \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).