From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77450C63797 for ; Tue, 17 Jan 2023 12:00:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236352AbjAQMAP (ORCPT ); Tue, 17 Jan 2023 07:00:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236593AbjAQMAB (ORCPT ); Tue, 17 Jan 2023 07:00:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C4EA36FD9; Tue, 17 Jan 2023 03:59:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16A12B81187; Tue, 17 Jan 2023 11:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B004C433D2; Tue, 17 Jan 2023 11:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673956794; bh=aTQYYKmLmNf07nxBHwjaA+StqUovg0SS7JYEnCH+EZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JcktzRZbthNjyz+5qDuk41oZMxJYCCPDkgEXy01vFYTwlnZjxjziBy/fjRBFrmcSa E+PMfnpmsxQOvk4Nnoif+2kebtJFzsk6MLmCF0naHyrUxRwLUY0egDjGMueOewYX9U jY95uj2yF2tCHsBQgxOnBrKJInMJKFTeLLsroP9Qz+Zmb5S5ohasJ2sIlHVuXyrdKU +JQlAVyRuTN0m1l13Oc+TNnPPuP7Sr59v4b9nO4VxcqClgsxIrXN9pyrNM8z/w85BT oBD2AKo9teesJp1MkdO9eUCNiMo/mj0umhmkVIhKlpMUQYQSsiQ5U2bWLoyBYl3VOM zsK3K8o3KkQoA== Date: Tue, 17 Jan 2023 13:59:51 +0200 From: Leon Romanovsky To: Chaitanya Kulkarni Cc: Jason Gunthorpe , Israel Rukshin , Bryan Tan , Christoph Hellwig , Eric Dumazet , Jakub Kicinski , Jens Axboe , Keith Busch , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-rdma@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , Masami Hiramatsu , Max Gurtovoy , "netdev@vger.kernel.org" , Paolo Abeni , Saeed Mahameed , Sagi Grimberg , Selvin Xavier , Steven Rostedt , Vishnu Dasa , Yishai Hadas Subject: Re: [PATCH rdma-next 11/13] nvme: Introduce a local variable Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 12:32:59AM +0000, Chaitanya Kulkarni wrote: > On 1/16/23 05:05, Leon Romanovsky wrote: > > From: Israel Rukshin > > > > The patch doesn't change any logic. > > > > Signed-off-by: Israel Rukshin > > Signed-off-by: Leon Romanovsky > > --- > > drivers/nvme/host/core.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > > index 7be562a4e1aa..51a9880db6ce 100644 > > --- a/drivers/nvme/host/core.c > > +++ b/drivers/nvme/host/core.c > > @@ -1870,6 +1870,7 @@ static void nvme_update_disk_info(struct gendisk *disk, > > sector_t capacity = nvme_lba_to_sect(ns, le64_to_cpu(id->nsze)); > > unsigned short bs = 1 << ns->lba_shift; > > u32 atomic_bs, phys_bs, io_opt = 0; > > + struct nvme_ctrl *ctrl = ns->ctrl; > > > > I don't think this patch is needed, existing code is more readable and > gives much clarity that we are accessing ctrl from namespace since we > are in nvme_update_disk_info() which is namespace based. I don't have strong opinion here. Thanks > > -ck >