From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BC4C678D4 for ; Tue, 17 Jan 2023 12:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236197AbjAQMEA (ORCPT ); Tue, 17 Jan 2023 07:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236976AbjAQMD0 (ORCPT ); Tue, 17 Jan 2023 07:03:26 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F66936FCD; Tue, 17 Jan 2023 04:03:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B59E3CE1688; Tue, 17 Jan 2023 12:03:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E677C433D2; Tue, 17 Jan 2023 12:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673956993; bh=93tzp+RSOFf3+k4VJuc6vDivUrGEcUxrSIufHOvJ2kk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=of5w9Xji5VNt/i6LxdxPZcYFz/Uw2hYN4b1Dd1rF2g8GNW0eiNQDJ+Y8y1aEEeE/a NYxCsYslSsLRlIH33cntH+tV20HVHqrJQC/0Q1VBorj/mqOH7yHvAPVNLBD4TnP8bX kSdSUi++Jh+XfjjAEcozg0vsEg+6lVk8BcOg+BxODigDLV6JzXKuIWJpSrNS1ZvgsF 0kfgA+p4Oo3b3+EprhLqWQjlKdQwvR4bGaaB6nGu9tfws4+mG4rXxdh75g16JMVJtM FEt2NMAXwJ6dD8alBSLP5SfCNjN1jeHTEg7dJD/Bz3ND9ClbQIwMvdb/UolK6yOVRb LFVB1lvT2qqdw== Date: Tue, 17 Jan 2023 14:03:07 +0200 From: Leon Romanovsky To: Jason Gunthorpe Cc: Israel Rukshin , Bryan Tan , Christoph Hellwig , Eric Dumazet , Jakub Kicinski , Jens Axboe , Keith Busch , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Max Gurtovoy , netdev@vger.kernel.org, Paolo Abeni , Saeed Mahameed , Sagi Grimberg , Selvin Xavier , Steven Rostedt , Vishnu Dasa , Yishai Hadas Subject: Re: [PATCH rdma-next 03/13] RDMA: Split kernel-only create QP flags from uverbs create QP flags Message-ID: References: <6e46859a58645d9f16a63ff76592487aabc9971d.1673873422.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, Jan 16, 2023 at 01:39:38PM -0400, Jason Gunthorpe wrote: > On Mon, Jan 16, 2023 at 03:05:50PM +0200, Leon Romanovsky wrote: > > > diff --git a/drivers/infiniband/hw/mlx4/mlx4_ib.h b/drivers/infiniband/hw/mlx4/mlx4_ib.h > > index 17fee1e73a45..c553bf0eb257 100644 > > --- a/drivers/infiniband/hw/mlx4/mlx4_ib.h > > +++ b/drivers/infiniband/hw/mlx4/mlx4_ib.h > > @@ -184,7 +184,7 @@ enum mlx4_ib_qp_flags { > > /* Mellanox specific flags start from IB_QP_CREATE_RESERVED_START */ > > MLX4_IB_ROCE_V2_GSI_QP = MLX4_IB_QP_CREATE_ROCE_V2_GSI, > > MLX4_IB_SRIOV_TUNNEL_QP = 1 << 30, > > - MLX4_IB_SRIOV_SQP = 1 << 31, > > + MLX4_IB_SRIOV_SQP = 1ULL << 31, > > }; > > These should be moved to a uapi if we are saying they are userspace > available > > But I'm not sure they are? I don't think so. > > > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > index 949cf4ffc536..cc2ddd4e6c12 100644 > > --- a/include/rdma/ib_verbs.h > > +++ b/include/rdma/ib_verbs.h > > @@ -1140,16 +1140,15 @@ enum ib_qp_type { > > IB_QPT_RESERVED10, > > }; > > > > +/* > > + * bits 0, 5, 6 and 7 may be set by old kernels and should not be used. > > + */ > > This is backwards "bits 0 5 6 7 were understood by older kernels and > should not be used" will change > > > enum ib_qp_create_flags { > > - IB_QP_CREATE_IPOIB_UD_LSO = 1 << 0, > > IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK = > > IB_UVERBS_QP_CREATE_BLOCK_MULTICAST_LOOPBACK, > > IB_QP_CREATE_CROSS_CHANNEL = 1 << 2, > > IB_QP_CREATE_MANAGED_SEND = 1 << 3, > > IB_QP_CREATE_MANAGED_RECV = 1 << 4, > > - IB_QP_CREATE_NETIF_QP = 1 << 5, > > - IB_QP_CREATE_INTEGRITY_EN = 1 << 6, > > - IB_QP_CREATE_NETDEV_USE = 1 << 7, > > IB_QP_CREATE_SCATTER_FCS = > > IB_UVERBS_QP_CREATE_SCATTER_FCS, > > IB_QP_CREATE_CVLAN_STRIPPING = > > @@ -1159,7 +1158,18 @@ enum ib_qp_create_flags { > > IB_UVERBS_QP_CREATE_PCI_WRITE_END_PADDING, > > /* reserve bits 26-31 for low level drivers' internal use */ > > IB_QP_CREATE_RESERVED_START = 1 << 26, > > - IB_QP_CREATE_RESERVED_END = 1 << 31, > > + IB_QP_CREATE_RESERVED_END = 1ULL << 31, > > And these should be shifted to the uapi header No problem. > > Jason