From: Tycho Andersen <tycho@tycho.pizza>
To: Ross Zwisler <zwisler@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ross Zwisler <zwisler@google.com>,
"Tobin C. Harding" <me@tobin.cc>,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 8/9] leaking_addresses: also skip canonical ftrace path
Date: Mon, 30 Jan 2023 12:34:18 -0700 [thread overview]
Message-ID: <Y9gbus4wRYUqz7QS@tycho.pizza> (raw)
In-Reply-To: <20230130181915.1113313-9-zwisler@google.com>
On Mon, Jan 30, 2023 at 11:19:14AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is typically located at /sys/kernel/debug/tracing.
> For backward compatibility, when mounting the debugfs file system,
> the tracefs file system will be automatically mounted at:
>
> /sys/kernel/debug/tracing
>
> scripts/leaking_addresses.pl only skipped this older debugfs path, so
> let's add the canonical path as well.
>
> Signed-off-by: Ross Zwisler <zwisler@google.com>
> ---
> scripts/leaking_addresses.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 8f636a23bc3f..e695634d153d 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -61,6 +61,7 @@ my @skip_abs = (
> '/proc/device-tree',
> '/proc/1/syscall',
> '/sys/firmware/devicetree',
> + '/sys/kernel/tracing/trace_pipe',
> '/sys/kernel/debug/tracing/trace_pipe',
> '/sys/kernel/security/apparmor/revision');
Thanks.
Acked-by: Tycho Andersen <tycho@tycho.pizza>
next prev parent reply other threads:[~2023-01-30 19:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 18:19 [PATCH 0/9] use canonical ftrace path whenever possible Ross Zwisler
2023-01-30 18:19 ` [PATCH 1/9] tracing: always use canonical ftrace path Ross Zwisler
2023-01-30 18:19 ` [PATCH 2/9] bpf: " Ross Zwisler
2023-01-30 18:19 ` [PATCH 3/9] selftests/bpf: " Ross Zwisler
2023-01-30 19:52 ` Alexei Starovoitov
2023-01-30 19:59 ` Steven Rostedt
2023-01-30 20:03 ` Alexei Starovoitov
2023-01-30 23:34 ` Steven Rostedt
2023-01-31 0:53 ` Alexei Starovoitov
2023-01-31 19:50 ` Steven Rostedt
2023-01-31 23:25 ` Alexei Starovoitov
2023-02-01 0:05 ` Ross Zwisler
2023-01-30 18:19 ` [PATCH 4/9] perf docs: " Ross Zwisler
2023-02-02 1:24 ` Arnaldo Carvalho de Melo
2023-01-30 18:19 ` [PATCH 5/9] tools/power: " Ross Zwisler
2023-02-02 14:47 ` Rafael J. Wysocki
2023-01-30 18:19 ` [PATCH 6/9] selftests: " Ross Zwisler
2023-01-30 18:19 ` [PATCH 7/9] tools/virtio: " Ross Zwisler
2023-01-30 19:26 ` Michael S. Tsirkin
2023-02-01 22:07 ` Ross Zwisler
2023-01-30 18:19 ` [PATCH 8/9] leaking_addresses: also skip " Ross Zwisler
2023-01-30 19:34 ` Tycho Andersen [this message]
2023-01-30 18:19 ` [PATCH 9/9] tools/kvm_stat: use " Ross Zwisler
2023-01-30 19:26 ` [PATCH 0/9] use canonical ftrace path whenever possible Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9gbus4wRYUqz7QS@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=rostedt@goodmis.org \
--cc=zwisler@chromium.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).