linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vincent Donnefort <vdonnefort@google.com>,
	Vlastimil Babka <vbabka@suse.cz>, Kees Cook <kees@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tracing: ring-buffer: Have the ring buffer code do the vmap of physical memory
Date: Tue, 1 Apr 2025 20:58:43 +0300	[thread overview]
Message-ID: <Z-wpU6649BjlHZFU@kernel.org> (raw)
In-Reply-To: <20250401115423.3b6a926d@gandalf.local.home>

On Tue, Apr 01, 2025 at 11:54:23AM -0400, Steven Rostedt wrote:
> On Tue, 1 Apr 2025 18:26:43 +0300
> Mike Rapoport <rppt@kernel.org> wrote:
> 
> > > But if I use vmap_page_range(), how do I give that back to the memory allocator?  
> > 
> > But you don't need neither vmap() nor vmap_page_range() to have kernel page
> > tables for memory that you get from reserve_mem. It's already mapped and
> > plain phys_to_virt() gives you the virtual address you can use.
> 
> Oh! That makes things so much easier! Especially since that means it should
> work like the normal buffer where virt_to_page() should also work. Right?

Right.
 
> Now I do support mapping the persistent ring buffer via memmap, but I can
> just give up on allowing that to be memory mapped to user space, or even
> freed.

It can't be freed without jumping through some hoops, and mapping it to
user space is hassle as well. 
  
-- 
Sincerely yours,
Mike.

  reply	other threads:[~2025-04-01 17:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 14:34 [PATCH v2 0/2] ring-buffer: Allow persistent memory to be user space mmapped Steven Rostedt
2025-03-31 14:34 ` [PATCH v2 1/2] tracing: ring-buffer: Have the ring buffer code do the vmap of physical memory Steven Rostedt
2025-03-31 16:55   ` Linus Torvalds
2025-03-31 17:39     ` Steven Rostedt
2025-03-31 19:12       ` Linus Torvalds
2025-03-31 20:58         ` Steven Rostedt
2025-03-31 21:42           ` Linus Torvalds
2025-03-31 23:42             ` Steven Rostedt
2025-04-01  0:09               ` Jann Horn
2025-04-01  1:02                 ` Steven Rostedt
2025-04-01  1:28                   ` Jann Horn
2025-04-01  1:50                     ` Steven Rostedt
2025-04-01  2:23                       ` Mathieu Desnoyers
2025-04-01  1:30                   ` Linus Torvalds
2025-04-01  1:41                     ` Steven Rostedt
2025-04-01  1:55                       ` Linus Torvalds
2025-04-01  9:53                         ` Ingo Molnar
2025-04-01  0:11               ` Linus Torvalds
2025-04-01  0:27                 ` Linus Torvalds
2025-04-01  0:30                 ` Steven Rostedt
2025-04-01  0:38                   ` Linus Torvalds
2025-04-01  0:49                     ` Linus Torvalds
2025-04-01  1:36                       ` Steven Rostedt
2025-04-01  1:44                         ` Linus Torvalds
2025-04-03  5:59                     ` Herbert Xu
2025-04-03 16:47                       ` Linus Torvalds
2025-04-01  9:56             ` Mike Rapoport
2025-04-01 15:11               ` Steven Rostedt
2025-04-01 15:26                 ` Mike Rapoport
2025-04-01 15:54                   ` Steven Rostedt
2025-04-01 17:58                     ` Mike Rapoport [this message]
2025-04-03 16:45       ` Kees Cook
2025-04-03 16:51         ` Linus Torvalds
2025-04-03 17:15           ` Steven Rostedt
2025-03-31 14:34 ` [PATCH v2 2/2] ring-buffer: Allow persistent ring buffers to be mmapped Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-wpU6649BjlHZFU@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gpiccoli@igalia.com \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).