From: Michal Hocko <mhocko@suse.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
linux-trace-kernel@vger.kernel.org, peterz@infradead.org,
mingo@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
oleg@redhat.com, brauner@kernel.org, glider@google.com,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] exit: add trace_task_exit() tracepoint before current->mm is reset
Date: Wed, 2 Apr 2025 09:18:34 +0200 [thread overview]
Message-ID: <Z-zkylk6r_rZ5V_K@tiehlicka> (raw)
In-Reply-To: <20250401173416.45a164c8@gandalf.local.home>
On Tue 01-04-25 17:34:16, Steven Rostedt wrote:
> On Tue, 1 Apr 2025 17:32:49 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > static void exit_mm(void)
> > {
> > struct mm_struct *mm = current->mm;
> >
> > exit_mm_release(current, mm);
> > trace_exit_mm(mm);
> >
> > ??
>
> That should have been:
>
> static void exit_mm(void)
> {
> struct mm_struct *mm = current->mm;
>
> trace_exit_mm(mm);
> exit_mm_release(current, mm);
If the primary usecase is to get an overview of the mm before exiting
then this is more appropriate.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2025-04-02 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 18:40 [PATCH] exit: add trace_task_exit() tracepoint before current->mm is reset Andrii Nakryiko
2025-04-01 21:32 ` Steven Rostedt
2025-04-01 21:34 ` Steven Rostedt
2025-04-02 7:18 ` Michal Hocko [this message]
2025-04-01 22:04 ` Andrii Nakryiko
2025-04-01 22:13 ` Steven Rostedt
2025-04-01 22:17 ` Andrii Nakryiko
2025-04-02 10:27 ` Jiri Olsa
2025-04-02 7:20 ` Michal Hocko
2025-04-02 13:58 ` Steven Rostedt
2025-04-02 15:56 ` Andrii Nakryiko
2025-04-02 8:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-zkylk6r_rZ5V_K@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=glider@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox