Re: [PATCH] ftrace: Show timings of how long nop patching took

[Mike Rapoport <rppt@kernel.org>]

On Sun, Dec 01, 2024 at 03:04:06PM -0500, Steven Rostedt wrote:
> On Sun, 1 Dec 2024 20:37:42 +0100
> Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> 
> > Hi Steven,
> > 
> > Le 17/10/2024 à 17:31, Steven Rostedt a écrit :
> > > From: Steven Rostedt <rostedt@goodmis.org>
> > > 
> > > Since the beginning of ftrace, the code that did the patching had its
> > > timings saved on how long it took to complete. But this information was
> > > never exposed. It was used for debugging and exposing it was always
> > > something that was on the TODO list. Now it's time to expose it. There's
> > > even a file that is where it should go!
> > > 
> > > Also include how long patching modules took as a separate value.
> > > 
> > >   # cat /sys/kernel/tracing/dyn_ftrace_total_info
> > >   57680 pages:231 groups: 9
> > >   ftrace boot update time = 14024666 (ns)
> > >   ftrace module total update time = 126070 (ns)  
> > 
> > What is this supposed to report / measure ?
> > 
> > On powerpc I get:
> > 
> > 25850 pages:14 groups: 3
> > ftrace boot update time = 0 (ns)
> > ftrace module total update time = 0 (ns)
> 
> Hmm, does powerpc support "trace_clock_local()" at early boot? I
> probably can just switch from using "ftrace_now()" to using
> ktime_get_real_ts64(). Hmm.

The calls to timekeeping_init() and time_init() are after ftrace_init() so
unless an architecture sets up some clock in setup_arch() like x86 does
there won't be a clock to use.
 
> -- Steve

-- 
Sincerely yours,
Mike.