From: Sasha Levin <sashal@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
mhiramat@kernel.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, linux-trace-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn_slot()
Date: Sun, 24 Nov 2024 09:15:56 -0500 [thread overview]
Message-ID: <Z0M1HLLE_ufLcGMO@sashalap> (raw)
In-Reply-To: <20241124131357.GA28360@redhat.com>
On Sun, Nov 24, 2024 at 02:13:57PM +0100, Oleg Nesterov wrote:
>Hi Sasha,
>
>but why do you think it makes sense to backport these "uprobes" cleanups?
If it doesn't, I'm happy to drop them. This commit was selected mostly
because of:
>> 1. Clear utask->xol_vaddr unconditionally, even if this addr is not valid,
>> xol_free_insn_slot() should never return with utask->xol_vaddr != NULL.
Which sounded to me like more than a cleanup.
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-11-24 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 12:46 [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn_slot() Sasha Levin
2024-11-24 13:13 ` Oleg Nesterov
2024-11-24 14:15 ` Sasha Levin [this message]
2024-11-24 14:36 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0M1HLLE_ufLcGMO@sashalap \
--to=sashal@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).