From: Jiri Olsa <olsajiri@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>, Kees Cook <kees@kernel.org>,
luto@amacapital.net, wad@chromium.org, oleg@redhat.com,
ldv@strace.io, mhiramat@kernel.org, andrii@kernel.org,
alexei.starovoitov@gmail.com, cyphar@cyphar.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
peterz@infradead.org, tglx@linutronix.de, bp@alien8.de,
daniel@iogearbox.net, ast@kernel.org, andrii.nakryiko@gmail.com,
rafi@rbk.io, shmulik.ladkani@gmail.com, bpf@vger.kernel.org,
linux-api@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] seccomp: passthrough uretprobe systemcall without filtering
Date: Tue, 21 Jan 2025 17:55:37 +0100 [thread overview]
Message-ID: <Z4_Riahgmj-bMR8s@krava> (raw)
In-Reply-To: <20250121111631.6e830edd@gandalf.local.home>
On Tue, Jan 21, 2025 at 11:16:31AM -0500, Steven Rostedt wrote:
>
> [ Watching this with popcorn from the sidelines, but I'll chime in anyway ]
>
> On Tue, 21 Jan 2025 15:38:48 +0100
> Jiri Olsa <olsajiri@gmail.com> wrote:
>
> > I'm still trying to come up with some other solution but wanted
> > to exhaust all the options I could think of
>
> I think this may have been mentioned, but is there a way that the kernel
> could know that this system call is being monitored by seccomp, and if so,
> just stick with the interrupt version? If not, enable the system call?
yes [1], the problem with that solution is that we install uretprobe
trampoline at function's uprobe entry probe, so we won't catch case
where seccomp is enabled in this probed function, like:
foo
uprobe -> install uretprobe trampoline
...
seccomp(SECCOMP_MODE_STRICT..
...
ret -> execute uretprobe trampoline with sys_uretprobe
I thought we could perhaps switch existing uretprobe trampoline to
int3 when we are in sys_seccomp, but another user thread might be
already executing the existing uretprobe trampoline, so I don't
think we can do that
jirka
[1] https://lore.kernel.org/bpf/20250114123257.GD19816@redhat.com/
next prev parent reply other threads:[~2025-01-21 16:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 0:55 [PATCH] seccomp: passthrough uretprobe systemcall without filtering Eyal Birger
2025-01-17 1:39 ` Oleg Nesterov
2025-01-17 8:02 ` Masami Hiramatsu
2025-01-17 13:36 ` Eyal Birger
2025-01-17 14:09 ` Oleg Nesterov
2025-01-17 17:51 ` Andrii Nakryiko
2025-01-17 19:24 ` Eyal Birger
2025-01-17 19:34 ` Andrii Nakryiko
2025-01-18 15:05 ` Oleg Nesterov
2025-01-17 18:34 ` Dmitry V. Levin
2025-01-17 18:52 ` Eyal Birger
2025-01-18 20:21 ` Kees Cook
2025-01-18 20:31 ` Darrick J. Wong
2025-01-18 20:45 ` Eyal Birger
2025-01-19 2:24 ` Kees Cook
2025-01-19 3:39 ` Eyal Birger
2025-01-19 10:44 ` Jiri Olsa
2025-01-20 21:34 ` Kees Cook
2025-01-27 19:24 ` Eyal Birger
2025-01-27 19:33 ` Kees Cook
2025-01-27 19:39 ` Eyal Birger
2025-01-27 19:43 ` Kees Cook
2025-01-21 14:38 ` Jiri Olsa
2025-01-21 14:47 ` Eyal Birger
2025-01-21 16:16 ` Steven Rostedt
2025-01-21 16:44 ` Oleg Nesterov
2025-01-21 16:55 ` Jiri Olsa [this message]
2025-01-21 22:38 ` Andrii Nakryiko
2025-01-21 22:46 ` Steven Rostedt
2025-01-21 23:13 ` Eyal Birger
2025-01-21 23:29 ` Steven Rostedt
2025-01-19 18:36 ` Andy Lutomirski
2025-01-19 12:40 ` Oleg Nesterov
2025-01-20 21:32 ` Kees Cook
2025-01-21 15:28 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4_Riahgmj-bMR8s@krava \
--to=olsajiri@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=daniel@iogearbox.net \
--cc=eyal.birger@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kees@kernel.org \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhiramat@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rafi@rbk.io \
--cc=rostedt@goodmis.org \
--cc=shmulik.ladkani@gmail.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).