From: Mark Rutland <mark.rutland@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Rix <trix@redhat.com>,
mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: set direct_ops storage-class-specifier to static
Date: Tue, 21 Mar 2023 09:28:13 +0000 [thread overview]
Message-ID: <ZBl4rZz/fULw+sWp@FVFF77S0Q05N> (raw)
In-Reply-To: <20230320135132.26b29f36@gandalf.local.home>
On Mon, Mar 20, 2023 at 01:51:32PM -0400, Steven Rostedt wrote:
> On Mon, 20 Mar 2023 17:44:13 +0000
> Mark Rutland <mark.rutland@arm.com> wrote:
> > On Sat, Mar 11, 2023 at 08:51:13AM -0500, Tom Rix wrote:
> > > smatch reports this warning
> > > kernel/trace/ftrace.c:2594:19: warning:
> > > symbol 'direct_ops' was not declared. Should it be static?
> > >
> > > The variable direct_ops is only used in ftrace.c, so it should be static
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > This makes sense, and as this stands:
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> >
> > ... but Florent's rework of the API is going to remove this anyway:
> >
> > https://lore.kernel.org/all/20230316173811.1223508-1-revest@chromium.org/
> > https://lore.kernel.org/all/20230316173811.1223508-4-revest@chromium.org/
> >
> > ... so if we take Florent's series, this patch isn't necessary.
>
> Except that it's already upstream:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8732565549011cabbea08329a1aefd78a68d96c7
>
> I had to rebase Florent's patch to accommodate this change.
Sorry for the noise; my fault for being so far behind with patch review!
Mark.
prev parent reply other threads:[~2023-03-21 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 13:51 [PATCH] ftrace: set direct_ops storage-class-specifier to static Tom Rix
2023-03-15 8:48 ` Masami Hiramatsu
2023-03-20 17:44 ` Mark Rutland
2023-03-20 17:51 ` Steven Rostedt
2023-03-21 9:28 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBl4rZz/fULw+sWp@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox