From: Matthew Wilcox <willy@infradead.org>
To: Zehao Zhang <zhangzehao@vivo.com>
Cc: linkinjeon@kernel.org, sj1557.seo@samsung.com,
rostedt@goodmis.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] exfat: Add ftrace support for exfat and add some tracepoints
Date: Tue, 11 Jul 2023 14:34:33 +0100 [thread overview]
Message-ID: <ZK1aaREkOh/0aIj8@casper.infradead.org> (raw)
In-Reply-To: <20230711122208.65020-1-zhangzehao@vivo.com>
On Tue, Jul 11, 2023 at 08:22:08PM +0800, Zehao Zhang wrote:
> Add ftrace support for exFAT file system,
> and add some tracepoints:
Why? I don't believe these are useful. Because if you actually had use
for them, you would have noticed that you're missing 99% of the reads
issued to the filesystem from the VFS -- through exfat_readahead(),
which you didn't instrument.
So what do you actually want to know, and why can't you get that
information already?
prev parent reply other threads:[~2023-07-11 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 12:22 [PATCH v2] exfat: Add ftrace support for exfat and add some tracepoints Zehao Zhang
2023-07-11 13:13 ` Masami Hiramatsu
2023-07-11 13:34 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK1aaREkOh/0aIj8@casper.infradead.org \
--to=willy@infradead.org \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sj1557.seo@samsung.com \
--cc=zhangzehao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).