From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496ABC001DC for ; Mon, 17 Jul 2023 16:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbjGQQun (ORCPT ); Mon, 17 Jul 2023 12:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjGQQum (ORCPT ); Mon, 17 Jul 2023 12:50:42 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61C15FA; Mon, 17 Jul 2023 09:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J0V5hV3Q+TS5tLVW5XW3ouizk5qxGr8MqtaRegwhqZc=; b=Z8mq/QYAjoh0dqYla8C9CtAFzt bwLmfk75nM/6hQubJHdZxiixAVS6fndkY2oLmBQ1Cs5X9uGJ7kerjsZnKlTUz4NX+exOVlRoMyYd+ xBWNIoc7kz3cT4xZCzuFgTkYIJrXF/OFUzvXowH6x0AvoOpfr+86How26Wvqyy3T1G4Pf1lqmutXN 7MDUEn4x0UBrExFVTTeRiDL+LAW4KF5VX5N/ydgLzPc9iiFL8uFF8QkURp99AA0veMm0OHJPTtWQd n2uE5mjgsxSwlQZ8uqbyKvECkdrO0YrtLazppU6eIQoJ1N3Ny9lv2crLlv9tP67fWnn4mU4tEMMVT zopy598Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qLRQX-004aby-0S; Mon, 17 Jul 2023 16:50:25 +0000 Date: Mon, 17 Jul 2023 09:50:25 -0700 From: Luis Chamberlain To: Steven Rostedt Cc: Alessandro Carminati , Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Masami Hiramatsu , Daniel Bristot de Oliveira , Viktor Malik , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Nick Alcock , eugene.loh@oracle.com, kris.van.hees@oracle.com, live-patching@vger.kernel.org Subject: Re: [PATCH v2] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms Message-ID: References: <20230714150326.1152359-1-alessandro.carminati@gmail.com> <20230717105240.3d986331@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717105240.3d986331@gandalf.local.home> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 10:52:40AM -0400, Steven Rostedt wrote: > Honestly, I think the "_alias_" is useless. It doesn't > give you any clue to what function you are actually attaching to. Agreed. > There's > been other approaches that show module and/or file names. I know there's > still some issues with getting those accepted, but I much rather have them > than this! > > See: https://lore.kernel.org/all/20221205163157.269335-1-nick.alcock@oracle.com/ Yes, please coordinate with Nick and review each other's work, now we have two separate efforts with different reasons but hopefully we'll come back with one unified solution. Please Cc live-patching also, as they had suggested before just to provide the file filename + line number, that'll make it even more valuable. Luis