Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config

Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config

[Namhyung Kim]

Hello,

On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote:
>
> Hi Namhyung, Arnaldo,
>
> Here is version 3 of the patchset. I see the change to send output to devnull
> has already been applied, so I am submitting the remaining work only.
>
> The difference with previous changes is that in v3 rather than add tests with
> pkg-config to check if dependencies are actually installed, we just set the
> flags and send any warning to devnull. The change that remains in this patchset
> is the fix for the other tools, which were inadvertently broken when the include
> for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h>
> since the flags for the feature check are not set in the other tools Makefiles,
> it currently only works for perf. I recommend to either take at least patch 2/5
> that moves setting the flags to tools/build/Makefile.feature or to revert the two
> patches that have been applied. You can easily test the fix with the commands below:
>
> make -B -C tools/verification/rv VF=1
> make -B -C tools/tracing/latency VF=1
> make -B -C tools/tracing/rtla VF=1
>
> from the root of the repository. Only after the feature check flags are moved to
> Makefile.feature that it also fixes the other tools. Apologies for the breakage
> there.

Steve, are you ok with having this patchset in the perf-tools tree?

Thanks,
Namhyung

Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config

[Steven Rostedt]

On Wed, 17 Jul 2024 09:27:58 -0700
Namhyung Kim <namhyung@kernel.org> wrote:

> Hello,
> 
> On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote:
> >
> > Hi Namhyung, Arnaldo,
> >
> > Here is version 3 of the patchset. I see the change to send output to devnull
> > has already been applied, so I am submitting the remaining work only.
> >
> > The difference with previous changes is that in v3 rather than add tests with
> > pkg-config to check if dependencies are actually installed, we just set the
> > flags and send any warning to devnull. The change that remains in this patchset
> > is the fix for the other tools, which were inadvertently broken when the include
> > for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h>
> > since the flags for the feature check are not set in the other tools Makefiles,
> > it currently only works for perf. I recommend to either take at least patch 2/5
> > that moves setting the flags to tools/build/Makefile.feature or to revert the two
> > patches that have been applied. You can easily test the fix with the commands below:
> >
> > make -B -C tools/verification/rv VF=1
> > make -B -C tools/tracing/latency VF=1
> > make -B -C tools/tracing/rtla VF=1
> >
> > from the root of the repository. Only after the feature check flags are moved to
> > Makefile.feature that it also fixes the other tools. Apologies for the breakage
> > there.  
> 
> Steve, are you ok with having this patchset in the perf-tools tree?
> 

I don't know as this is the first I've seen it. If you could have this
resend with me Cc'd and/or Cc linux-trace-devel@vger.kernel.org then I
can review and possibly ack it.

-- Steve

Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config

[Guilherme Amadio]

On Wed, Jul 17, 2024 at 12:31:47PM -0400, Steven Rostedt wrote:
> On Wed, 17 Jul 2024 09:27:58 -0700
> Namhyung Kim <namhyung@kernel.org> wrote:
> 
> > Hello,
> > 
> > On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote:
> > >
> > > Hi Namhyung, Arnaldo,
> > >
> > > Here is version 3 of the patchset. I see the change to send output to devnull
> > > has already been applied, so I am submitting the remaining work only.
> > >
> > > The difference with previous changes is that in v3 rather than add tests with
> > > pkg-config to check if dependencies are actually installed, we just set the
> > > flags and send any warning to devnull. The change that remains in this patchset
> > > is the fix for the other tools, which were inadvertently broken when the include
> > > for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h>
> > > since the flags for the feature check are not set in the other tools Makefiles,
> > > it currently only works for perf. I recommend to either take at least patch 2/5
> > > that moves setting the flags to tools/build/Makefile.feature or to revert the two
> > > patches that have been applied. You can easily test the fix with the commands below:
> > >
> > > make -B -C tools/verification/rv VF=1
> > > make -B -C tools/tracing/latency VF=1
> > > make -B -C tools/tracing/rtla VF=1
> > >
> > > from the root of the repository. Only after the feature check flags are moved to
> > > Makefile.feature that it also fixes the other tools. Apologies for the breakage
> > > there.  
> > 
> > Steve, are you ok with having this patchset in the perf-tools tree?
> > 
> 
> I don't know as this is the first I've seen it. If you could have this
> resend with me Cc'd and/or Cc linux-trace-devel@vger.kernel.org then I
> can review and possibly ack it.

I will resend with the extra CC suggestions shortly and a cover letter
explaining everything.

Best regards,
-Guilherme