From: Luis Chamberlain <mcgrof@kernel.org>
To: Song Liu <song@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>, "KE.LI" <like1@oppo.com>,
Padmanabha Srinivasaiah <treasure4paddy@gmail.com>,
Sami Tolvanen <samitolvanen@google.com>,
Fangrui Song <maskray@google.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, jpoimboe@kernel.org,
jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com,
joe.lawrence@redhat.com, morbo@google.com,
justinstitt@google.com, thunder.leizhen@huawei.com,
kees@kernel.org, kernel-team@meta.com, mmaurer@google.com,
mhiramat@kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG
Date: Mon, 12 Aug 2024 09:57:37 -0700 [thread overview]
Message-ID: <Zro_AeCacGaLL3jq@bombadil.infradead.org> (raw)
In-Reply-To: <CAPhsuW64RyYhHsFeJSj7=+4uHBo7LucWtWY5xOxN20aujxadGg@mail.gmail.com>
On Mon, Aug 12, 2024 at 09:21:02AM -0700, Song Liu wrote:
> Hi folks,
>
> Do we have more concerns and/or suggestions with this set? If not,
> what would be the next step for it?
I'm all for simplifying things, and this does just that, however,
I'm not the one you need to convince, the folks who added the original
hacks should provide their Reviewed-by / Tested-by not just for CONFIG_LTO_CLANG
but also given this provides an alternative fix, don't we want to invert
the order so we don't regress CONFIG_LTO_CLANG ? And shouldn't the patches
also have their respective Fixes tag?
Provided the commit logs are extended with Fixes and order is maintained
to be able to bisect correctly:
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
next prev parent reply other threads:[~2024-08-12 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 22:05 [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG Song Liu
2024-08-07 22:05 ` [PATCH v3 1/2] kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbols Song Liu
2024-08-13 21:15 ` Song Liu
2024-08-07 22:05 ` [PATCH v3 2/2] kallsyms: Match symbols exactly with CONFIG_LTO_CLANG Song Liu
2024-08-13 21:16 ` Song Liu
2024-08-12 16:21 ` [PATCH v3 0/2] Fix kallsyms " Song Liu
2024-08-12 16:57 ` Luis Chamberlain [this message]
2024-08-12 18:13 ` Song Liu
2024-08-15 16:05 ` Kees Cook
2024-08-15 16:09 ` Song Liu
2024-08-13 4:29 ` Masami Hiramatsu
2024-08-13 21:20 ` Song Liu
2024-08-13 21:55 ` Sami Tolvanen
2024-08-14 12:09 ` Petr Mladek
2024-08-15 16:34 ` Kees Cook
2024-08-30 13:57 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zro_AeCacGaLL3jq@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel-team@meta.com \
--cc=like1@oppo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=maskray@google.com \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=mmaurer@google.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=treasure4paddy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).