From: Petr Mladek <pmladek@suse.com>
To: Song Liu <song@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, jpoimboe@kernel.org,
jikos@kernel.org, mbenes@suse.cz, joe.lawrence@redhat.com,
nathan@kernel.org, morbo@google.com, justinstitt@google.com,
mcgrof@kernel.org, thunder.leizhen@huawei.com, kees@kernel.org,
kernel-team@meta.com, mmaurer@google.com,
samitolvanen@google.com, mhiramat@kernel.org,
rostedt@goodmis.org
Subject: Re: [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG
Date: Wed, 14 Aug 2024 14:09:42 +0200 [thread overview]
Message-ID: <ZryehvKuUogvtYhW@pathway.suse.cz> (raw)
In-Reply-To: <20240807220513.3100483-1-song@kernel.org>
On Wed 2024-08-07 15:05:11, Song Liu wrote:
> With CONFIG_LTO_CLANG, the compiler/linker adds .llvm.<hash> suffix to
> local symbols to avoid duplications. Existing scripts/kallsyms sorts
> symbols without .llvm.<hash> suffix. However, this causes quite some
> issues later on. Some users of kallsyms, such as livepatch, have to match
> symbols exactly.
>
> Address this by sorting full symbols at build time, and let kallsyms
> lookup APIs to match the symbols exactly.
The changes look good from the livepatching POV. For both patches,
feel free to use:
Acked-by: Petr Mladek <pmladek@suse.com>
I made a quick glance over the code changes. They look sane. But I did
not check them deep enough to provide a valuable Reviewed-by ;-)
Best Regards,
Petr
next prev parent reply other threads:[~2024-08-14 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 22:05 [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG Song Liu
2024-08-07 22:05 ` [PATCH v3 1/2] kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbols Song Liu
2024-08-13 21:15 ` Song Liu
2024-08-07 22:05 ` [PATCH v3 2/2] kallsyms: Match symbols exactly with CONFIG_LTO_CLANG Song Liu
2024-08-13 21:16 ` Song Liu
2024-08-12 16:21 ` [PATCH v3 0/2] Fix kallsyms " Song Liu
2024-08-12 16:57 ` Luis Chamberlain
2024-08-12 18:13 ` Song Liu
2024-08-15 16:05 ` Kees Cook
2024-08-15 16:09 ` Song Liu
2024-08-13 4:29 ` Masami Hiramatsu
2024-08-13 21:20 ` Song Liu
2024-08-13 21:55 ` Sami Tolvanen
2024-08-14 12:09 ` Petr Mladek [this message]
2024-08-15 16:34 ` Kees Cook
2024-08-30 13:57 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZryehvKuUogvtYhW@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mmaurer@google.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).