From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9146212623; Fri, 11 Oct 2024 10:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728643474; cv=none; b=R9nXaVSwmmhRd2Y32N81IhZx/TfNJfmkkzX+CfUiYTipwimnEceDYKkqQyUjGB7pKSwkaUuSzk6HLVYCQQYLUO7HzFYsdrK3C6VDAP8wu7K6sDCHHrvLJ6DbYnsBz+dzeCJfpOUA79aH100q9Kao6VIyNPmdMur68ifcSJsTYqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728643474; c=relaxed/simple; bh=aLkwNoL+Bumhk3uwLGo9YRl0ADW9V4dVzznxlZue0eM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=by5z1+hPF5q4R4kQpleb/D8hPKScypKnCyRYPnJM5RIgyA65Y1izLdvg23O6z+K/HwHtq6EFNOFNzKZcYuoz/uGqPKjnNcbqvOIOF3421vqymLfcztwU1Db20fTPDCW/m5cwAOBBBwpYTCW3Cz6mm/ioF1ae5yxYVPC0Tdnf/uM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 5Qzed0R0Tzmb8OsOfJEdlw== X-CSE-MsgGUID: fUouArolRPCUnmxyqtrKRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11221"; a="31945375" X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="31945375" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 03:44:31 -0700 X-CSE-ConnectionGUID: i7HRo/ZrRyqIZExO8A9FwA== X-CSE-MsgGUID: C8b20lxITgu7qel/zjZDuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="77078265" Received: from smile.fi.intel.com ([10.237.72.154]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 03:44:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1szD86-00000001rYz-2dPC; Fri, 11 Oct 2024 13:44:18 +0300 Date: Fri, 11 Oct 2024 13:44:18 +0300 From: Andy Shevchenko To: David Gow Cc: Andrew Morton , Shuah Khan , Brendan Higgins , Rae Moar , Kees Cook , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Stephen Rothwell , Yury Norov , Rasmus Villemoes , "Jason A . Donenfeld" , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" , Masami Hiramatsu , Mark Brown , linux-hardening@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Palmer Dabbelt , Christophe Leroy , Charlie Jenkins , Simon Horman , Jakub Kicinski , Arnd Bergmann , Daniel Latypov , Guenter Roeck , David Howells , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Marco Elver , Mark Rutland , "Gustavo A. R. Silva" , Vlastimil Babka , Geert Uytterhoeven , Nathan Chancellor , Fangrui Song , "Steven Rostedt (Google)" Subject: Re: [PATCH 3/6] lib: Move KUnit tests into tests/ subdirectory Message-ID: References: <20241011072509.3068328-2-davidgow@google.com> <20241011072509.3068328-5-davidgow@google.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011072509.3068328-5-davidgow@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Oct 11, 2024 at 03:25:07PM +0800, David Gow wrote: > From: Kees Cook > > Following from the recent KUnit file naming discussion[1], move all > KUnit tests in lib/ into lib/tests/. > > Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@kernel.org/ [1] > Signed-off-by: Kees Cook > Acked-by: "Steven Rostedt (Google)" > Acked-by: Jakub Kicinski > Acked-by: "Masami Hiramatsu (Google)" > Reviewed-by: David Gow > [Rebased onto mm-nonmm-unstable, moved usercopy_kunit] > Signed-off-by: David Gow > rename lib/{ => tests}/bitfield_kunit.c (100%) > rename lib/{ => tests}/checksum_kunit.c (100%) > rename lib/{ => tests}/cmdline_kunit.c (100%) > rename lib/{ => tests}/cpumask_kunit.c (100%) > rename lib/{ => tests}/fortify_kunit.c (100%) > rename lib/{ => tests}/hashtable_test.c (100%) > rename lib/{ => tests}/is_signed_type_kunit.c (100%) > rename lib/{ => tests}/kunit_iov_iter.c (100%) > rename lib/{ => tests}/list-test.c (100%) > rename lib/{ => tests}/memcpy_kunit.c (100%) > rename lib/{ => tests}/overflow_kunit.c (100%) > rename lib/{ => tests}/siphash_kunit.c (100%) > rename lib/{ => tests}/slub_kunit.c (100%) > rename lib/{ => tests}/stackinit_kunit.c (100%) > rename lib/{ => tests}/string_helpers_kunit.c (100%) > rename lib/{ => tests}/string_kunit.c (100%) > rename lib/{ => tests}/test_bits.c (100%) > rename lib/{ => tests}/test_fprobe.c (100%) > rename lib/{ => tests}/test_hash.c (100%) > rename lib/{ => tests}/test_kprobes.c (100%) > rename lib/{ => tests}/test_linear_ranges.c (100%) > rename lib/{ => tests}/test_list_sort.c (100%) > rename lib/{ => tests}/test_sort.c (100%) > rename lib/{ => tests}/usercopy_kunit.c (100%) While I support the idea, I think this adds an additional churn in creating a duplicate 'test' in the filenames. Why they all can't be cut while removing? (at least this question is not answered in the commit message) -- With Best Regards, Andy Shevchenko