From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Neil Brown <neilb@suse.de>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] sunrpc: remove newlines from tracepoints
Date: Tue, 29 Oct 2024 15:39:49 -0400 [thread overview]
Message-ID: <ZyE6BWVxzHh5IiAT@tissot.1015granger.net> (raw)
In-Reply-To: <20241029-tpfix-v1-1-19f69fcf915a@kernel.org>
On Tue, Oct 29, 2024 at 03:21:43PM -0400, Jeff Layton wrote:
> Tracepoint strings don't require newlines (and in fact, they are
> undesirable).
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> include/trace/events/sunrpc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> index 5e8495216689549f1c0bb377911eac4a7bb7b1a8..b13dc275ef4a79940a940dd463b7a3eef5ca428b 100644
> --- a/include/trace/events/sunrpc.h
> +++ b/include/trace/events/sunrpc.h
> @@ -719,7 +719,7 @@ TRACE_EVENT(rpc_xdr_overflow,
> ),
>
> TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> - " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> + " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> __entry->task_id, __entry->client_id,
> __get_str(progname), __entry->version, __get_str(procedure),
> __entry->requested, __entry->p, __entry->end,
> @@ -777,7 +777,7 @@ TRACE_EVENT(rpc_xdr_alignment,
> ),
>
> TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> - " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> + " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> __entry->task_id, __entry->client_id,
> __get_str(progname), __entry->version, __get_str(procedure),
> __entry->offset, __entry->copied,
>
> ---
> base-commit: 9c9cb4242c49bbadd010e8f0a9e7daf4b392ff6b
> change-id: 20241029-tpfix-252e1f852ae4
>
> Best regards,
> --
> Jeff Layton <jlayton@kernel.org>
>
Looks like a client-side trace point.
Acked-by: Chuck Lever <chuck.lever@oracle.com>
--
Chuck Lever
next prev parent reply other threads:[~2024-10-29 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 19:21 [PATCH] sunrpc: remove newlines from tracepoints Jeff Layton
2024-10-29 19:39 ` Chuck Lever [this message]
2024-10-29 19:42 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyE6BWVxzHh5IiAT@tissot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=Dai.Ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=okorniev@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox