From: Lukas Wunner <lukas@wunner.de>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bhelgaas@google.com, tony.luck@intel.com, bp@alien8.de,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, oleg@redhat.com,
naveen@kernel.org, davem@davemloft.net,
anil.s.keshavamurthy@intel.com, mark.rutland@arm.com,
peterz@infradead.org
Subject: Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event
Date: Thu, 21 Nov 2024 10:27:07 +0100 [thread overview]
Message-ID: <Zz786zZljAy2J5i7@wunner.de> (raw)
In-Reply-To: <20241120124328.19111-1-xueshuai@linux.alibaba.com>
On Wed, Nov 20, 2024 at 08:43:28PM +0800, Shuai Xue wrote:
> $ echo 1 > /sys/kernel/debug/tracing/events/hotplug/pci_hp_event/enable
^^^^^^^
I think this should now be "pci_hotplug" because you've renamed the
TRACE_SYSTEM in v3.
I'm wondering if we'll have other categories besides "pci_hp_event"
below "pci_hotplug". Maybe not. Is it possible to omit the "pci_hotplug"
and make "pci_hp_event" top level? Or should this be grouped below "pci"
instead of "pci_hotplug"? I'm somewhat at a loss here as I'm not
familiar with the conventions used in the tracing subsystem.
From a PCI hotplug perspective, this patch LGTM, so:
Reviewed-by: Lukas Wunner <lukas@wunner.de>
next prev parent reply other threads:[~2024-11-21 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 12:43 [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event Shuai Xue
2024-11-21 9:27 ` Lukas Wunner [this message]
2024-11-21 11:34 ` Shuai Xue
2024-11-21 13:43 ` Steven Rostedt
2024-11-21 23:09 ` Lukas Wunner
2024-11-22 0:08 ` Steven Rostedt
2024-11-22 6:25 ` Shuai Xue
2024-11-22 10:29 ` Lukas Wunner
2024-11-22 1:53 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz786zZljAy2J5i7@wunner.de \
--to=lukas@wunner.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).