Linux Trace Kernel
 help / color / mirror / Atom feed
From: Shivank Garg <shivankg@amd.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Matthew Wilcox <willy@infradead.org>
Cc: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, david@redhat.com,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC] mm: use folio_expected_ref_count() helper for reference counting
Date: Tue, 10 Jun 2025 14:29:20 +0530	[thread overview]
Message-ID: <a0e0bdbf-c8a1-48af-9287-9de023adc065@amd.com> (raw)
In-Reply-To: <20250609161454.27122eb4@gandalf.local.home>



On 6/10/2025 1:44 AM, Steven Rostedt wrote:
> On Mon, 9 Jun 2025 20:51:00 +0100
> Matthew Wilcox <willy@infradead.org> wrote:
> 
>> On Mon, Jun 09, 2025 at 03:31:40PM -0400, Steven Rostedt wrote:
>>>
>>>
>>> On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox <willy@infradead.org> wrote:  
>>>> On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote:  
>>>>> Replace open-coded folio reference count calculations with the
>>>>> folio_expected_ref_count() helper to improve code maintainability
>>>>> and reduce duplication.  
>>>>
>>>> If it needs this much additional commentary, perhaps it's not actually
>>>> clearer?  
>>>
>>> I don't know. I tend to over explain as I rather make it totally
>>> obvious what is happening. I wouldn't say excessive commentary is
>>> necessarily a sign that it's not clearer.  
>>
>> That was a Socratic question, not for you to answer.
>>
>> My opinion is that the extra commentary is obfuscatory and should be
>> removed.
> 
> 
> Ah, sorry, your response wasn't clear ;-)

Thank you Willy, Steve for the discussion.
Fair point about extra comments, I'll remove them.

Thanks,
Shivank

  reply	other threads:[~2025-06-10  8:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 17:08 [RFC] mm: use folio_expected_ref_count() helper for reference counting Shivank Garg
2025-06-09 19:21 ` Matthew Wilcox
2025-06-09 19:31   ` Steven Rostedt
2025-06-09 19:51     ` Matthew Wilcox
2025-06-09 20:14       ` Steven Rostedt
2025-06-10  8:59         ` Shivank Garg [this message]
2025-06-10  7:05       ` David Hildenbrand
2025-06-10  2:26 ` Alistair Popple
2025-06-10  5:50   ` Shivank Garg
2025-06-10  7:08 ` David Hildenbrand
2025-06-10  9:00   ` Shivank Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0e0bdbf-c8a1-48af-9287-9de023adc065@amd.com \
    --to=shivankg@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=david@redhat.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox