linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Remus <jremus@linux.ibm.com>
To: Steven Rostedt <rostedt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	bpf@vger.kernel.org, x86@kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrii Nakryiko <andrii@kernel.org>,
	Indu Bhagat <indu.bhagat@oracle.com>,
	"Jose E. Marchesi" <jemarch@gnu.org>,
	Beau Belgrave <beaub@linux.microsoft.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, Florian Weimer <fweimer@redhat.com>,
	Sam James <sam@gentoo.org>
Subject: Re: [PATCH v15 02/10] unwind_user/deferred: Add unwind_user_faultable()
Date: Mon, 28 Jul 2025 17:29:31 +0200	[thread overview]
Message-ID: <a47d0d23-8518-4146-b97a-bf18753bc483@linux.ibm.com> (raw)
In-Reply-To: <20250725185739.399622407@kernel.org>

On 25.07.2025 20:55, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> Add a new API to retrieve a user space callstack called
> unwind_user_faultable(). The difference between this user space stack
> tracer from the current user space stack tracer is that this must be
> called from faultable context as it may use routines to access user space
> data that needs to be faulted in.
> 
> It can be safely called from entering or exiting a system call as the code
> can still be faulted in there.
> 
> This code is based on work by Josh Poimboeuf's deferred unwinding code:
> 
> Link: https://lore.kernel.org/all/6052e8487746603bdb29b65f4033e739092d9925.1737511963.git.jpoimboe@kernel.org/
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Reviewed-by: Jens Remus <jremus@linux.ibm.com>

> ---
>  include/linux/sched.h                 |  5 +++
>  include/linux/unwind_deferred.h       | 24 +++++++++++
>  include/linux/unwind_deferred_types.h |  9 ++++
>  kernel/fork.c                         |  4 ++
>  kernel/unwind/Makefile                |  2 +-
>  kernel/unwind/deferred.c              | 60 +++++++++++++++++++++++++++
>  6 files changed, 103 insertions(+), 1 deletion(-)
>  create mode 100644 include/linux/unwind_deferred.h
>  create mode 100644 include/linux/unwind_deferred_types.h
>  create mode 100644 kernel/unwind/deferred.c

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/


  reply	other threads:[~2025-07-28 15:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 18:55 [PATCH v15 00/10] unwind_user: Deferred unwinding infrastructure Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 01/10] unwind_user: Add user space unwinding API with frame pointer support Steven Rostedt
2025-07-28 15:24   ` Jens Remus
2025-07-28 16:08     ` Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 02/10] unwind_user/deferred: Add unwind_user_faultable() Steven Rostedt
2025-07-28 15:29   ` Jens Remus [this message]
2025-07-25 18:55 ` [PATCH v15 03/10] unwind_user/deferred: Add unwind cache Steven Rostedt
2025-07-28 15:46   ` Jens Remus
2025-07-28 16:15     ` Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 04/10] unwind_user/deferred: Add deferred unwinding interface Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 05/10] unwind_user/deferred: Make unwind deferral requests NMI-safe Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 06/10] unwind deferred: Use bitmask to determine which callbacks to call Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 07/10] unwind deferred: Add unwind_completed mask to stop spurious callbacks Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 08/10] unwind: Add USED bit to only have one conditional on way back to user space Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 09/10] unwind deferred: Use SRCU unwind_deferred_task_work() Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 10/10] unwind: Finish up unwind when a task exits Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a47d0d23-8518-4146-b97a-bf18753bc483@linux.ibm.com \
    --to=jremus@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=beaub@linux.microsoft.com \
    --cc=bpf@vger.kernel.org \
    --cc=fweimer@redhat.com \
    --cc=indu.bhagat@oracle.com \
    --cc=jemarch@gnu.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@kernel.org \
    --cc=sam@gentoo.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).