From: Tejun Heo <tj@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Kees Cook <kees@kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
bpf <bpf@vger.kernel.org>, Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@inria.fr
Subject: Re: [RFC][PATCH 2/2] treewide: Have the task->flags & PF_KTHREAD check use the helper functions
Date: Mon, 28 Apr 2025 08:34:45 -1000 [thread overview]
Message-ID: <aA_KRQQXt646y37K@slm.duckdns.org> (raw)
In-Reply-To: <CAADnVQKdWSuDm52GmNor75rFZGNBLcoCto3oecA3D3QHD_MyCQ@mail.gmail.com>
On Fri, Apr 25, 2025 at 08:22:59PM -0700, Alexei Starovoitov wrote:
> > > tools/sched_ext/scx_central.bpf.c | 2 +-
> > > tools/sched_ext/scx_flatcg.bpf.c | 2 +-
> > > tools/sched_ext/scx_qmap.bpf.c | 2 +-
> >
> > I think these are fine. The Makefile is pulling in standard kbuild
> > Makefiles, so I think the correct include directories (outside of
> > tools/) are being used.
>
> I suspect they are not fine.
> I don't think they #include linux/sched.h
> I would drop them for now.
Oh, this won't work. Those get all the kernel defs from the BTF generated
vmlinux.h file which doesn't include any inline functions or macros, so
please don't include them in this conversion.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-04-28 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 20:41 [RFC][PATCH 0/2] Add is_user_thread() and is_kernel_thread() helper functions Steven Rostedt
2025-04-25 20:41 ` [RFC][PATCH 1/2] kthread: " Steven Rostedt
2025-04-25 23:03 ` Kees Cook
2025-04-26 12:36 ` Steven Rostedt
2025-04-26 11:08 ` Borislav Petkov
2025-04-26 12:37 ` Steven Rostedt
2025-04-25 20:41 ` [RFC][PATCH 2/2] treewide: Have the task->flags & PF_KTHREAD check use the " Steven Rostedt
2025-04-25 23:09 ` Kees Cook
2025-04-26 3:22 ` Alexei Starovoitov
2025-04-28 18:34 ` Tejun Heo [this message]
2025-04-25 23:14 ` [RFC][PATCH 0/2] Add is_user_thread() and is_kernel_thread() " Andrew Morton
2025-04-26 10:41 ` Julia Lawall
2025-04-26 12:43 ` Steven Rostedt
2025-04-26 18:42 ` [PATCH] sched/core: Introduce task_*() helpers for PF_ flags Ingo Molnar
2025-04-26 18:51 ` Ingo Molnar
2025-04-26 20:06 ` Steven Rostedt
2025-04-28 12:12 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA_KRQQXt646y37K@slm.duckdns.org \
--to=tj@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cocci@inria.fr \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas.palix@imag.fr \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox