From: Alison Schofield <alison.schofield@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
<nvdimm@lists.linux.dev>, Dan Williams <dan.j.williams@intel.com>,
Shiyang Ruan <ruansy.fnst@fujitsu.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Ross Zwisler <zwisler@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] fsdax: Remove unused trace events for dax insert mapping
Date: Thu, 29 May 2025 20:06:11 -0700 [thread overview]
Message-ID: <aDkgo81JQykBKCY6@aschofie-mobl2.lan> (raw)
In-Reply-To: <20250529152211.688800c9@gandalf.local.home>
On Thu, May 29, 2025 at 03:22:11PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> When the dax_fault_actor() helper was factored out, it removed the calls
> to the dax_pmd_insert_mapping and dax_insert_mapping events but never
> removed the events themselves. As each event created takes up memory
> (roughly 5K each), this is a waste as it is never used.
>
> Remove the unused dax_pmd_insert_mapping and dax_insert_mapping trace
> events.
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
>
> Fixes: c2436190e492 ("fsdax: factor out a dax_fault_actor() helper")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> Changes since v1: https://lore.kernel.org/all/20250529150722.19e04332@gandalf.local.home/
>
> - Removed dax_insert_mapping too
>
> include/trace/events/fs_dax.h | 78 -----------------------------------
> 1 file changed, 78 deletions(-)
>
next prev parent reply other threads:[~2025-05-30 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:22 [PATCH v2] fsdax: Remove unused trace events for dax insert mapping Steven Rostedt
2025-05-30 3:06 ` Alison Schofield [this message]
2025-05-31 20:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDkgo81JQykBKCY6@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=ruansy.fnst@fujitsu.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox